Repository navigation
Pin llama.cpp 8792923f: the SET_ROWS hook the private kernels need (fixes the main build) - #477
Merged
Merged
Conversation
…need (census G1) gpu-kernels be68256d (#476) compiles addons/hip-hrx/dispatch-hip-set-rows-q8.cpp against HipSetRowsArgs, which only the fork branch 1bit/hrx-set-rows-q8 had: with the private kernels the release build failed at dispatch-hip-set-rows-q8.cpp:39. Fork #116 squash-merged that branch onto 1bit/hrx-vulkan-patched (8792923f8, the same tree as the head proven here). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Engine main 1834ceb (#476) does not build with the private HIP kernels. gpu-kernels be68256d's
addons/hip-hrx/dispatch-hip-set-rows-q8.cpp:39usesHipSetRowsArgs, and that type only existed on the fork branch1bit/hrx-set-rows-q8, the fork half of census G1, which was never merged.1bit/hrx-vulkan-patchedas 8792923f8. 8792923f8 has the same tree (a284de6e) as the PR head c532b4ec9 that the build below used.third_party/llama.cppb14a28362 -> 8792923f8 (the tip of its.gitmodulesbranch). The README pin note is updated.tools/registry_build.pyis regenerated;--check-pinsand--checkare clean, andtools/check_pins.py origin/mainreports "ahead".Proof on ryzen, with no GPU or NPU used (
ROCR_VISIBLE_DEVICES=-1, nice 19, -j8):WEEKLY_DRY_RUN=1 scripts/weekly.sh build testwith HRX on and the private fetch (gpu-kernels be68256d, NPU runtime 0fb58e1), at llama.cpp c532b4ec9. Build PASS in 295 s.dispatch-hip-set-rows-q8.cpp.ocompiled,libggml-hrx.soexportsggml_hrx_hip_addon_registerand carries 40 amdgcn code objects, and 11 strings name the set_rows q8 kernels.registry_pinson that proof commit, because its registry still recorded b14a28362; this PR's regenerated registry fixes that.1bit/hw-gate-private-kernels), on the same box: at b14a28362 it fails withdispatch-hip-set-rows-q8.cpp:39:28: error: unknown type name 'HipSetRowsArgs'; at 8792923f8 it passes.🤖 Generated with Claude Code