Repository navigation
feat(android): large navbar titles that collapse like iOS - #80
Merged
Merged
Conversation
`large: true` now works on Android. The navbar grows by 52dp (same as iOS 44 to 96) and shows a bold 32sp title in its own row under the toolbar. Sending `large: false` with the same title collapses it to the inline toolbar title with a 220ms animation: the bar shrinks, the large title fades out and the inline title fades in. A new title snaps, since the page transition already animates. Insets follow the target state so the page moves once, not on every frame. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Beta npm buildMaintainers can publish this PR to npm for fast testing. Comment The workflow will:
Security note: beta publish is only enabled for branches inside this repository. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 44 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
largewas iOS-only; Android ignored it. Now Android shows a large title too.large: true: the bar grows by 52dp (iOS goes 44 → 96, same row) and shows a bold 32sp title under the toolbar row. Toolbar items stay in the top row, like iOS.large: falsewith the same title: animated collapse (220ms). The bar shrinks, the large title fades out, then the inline toolbar title fades in, so the two never overlap.top,navbarHeight) follow the target state so the WebView reflows once, not per frame. Animation frames only resize the navbar container.NavbarLargeTitleSupportwith unit tests.Tested in the Mimesis app on an API 36 emulator: tab pages show the large title, scrolling collapses and expands it, tab switches and push pages (back button, no large title) are fine, no crashes.
./gradlew build test, eslint and prettier pass.🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmith-botwith what you need.