Implementing Thresholds for Incremental PR Reviews

[zmeir]

PR Type:

Enhancement

---

PR Description:

This PR introduces new configurations to manage the frequency of automatic incremental reviews triggered by a push event. The main changes include:

• Added properties first_new_commit_sha and last_seen_commit_sha in the IncrementalPR class in git_provider.py.
• Modified get_commit_range method in github_provider.py to assign commit objects instead of commit SHA to first_new_commit and last_seen_commit.
• Updated run method in pr_reviewer.py to check for the number of new commits and their recency before starting the review.
• Added new configurations in configuration.toml to specify the minimum number of commits and minimum time elapsed for an incremental review.

---

PR Main Files Walkthrough:

files:

pr_agent/git_providers/git_provider.py: Introduced properties first_new_commit_sha and last_seen_commit_sha in the IncrementalPR class.
pr_agent/git_providers/github_provider.py: Updated get_commit_range method to assign commit objects instead of commit SHA to first_new_commit and last_seen_commit.
pr_agent/tools/pr_reviewer.py: Modified run method to check for the number of new commits and their recency before starting the review.
pr_agent/settings/configuration.toml: Added new configurations to specify the minimum number of commits and minimum time elapsed for an incremental review.

---

User Description:

These new configurations allow limiting the rate of automatic incremental reviews when triggered by a push event to reduce the noise it may generate in the PR

[zmeir]

/describe --pr_description.add_original_user_description=true

[mrT23]

@zmeir please move all of this to a dedicated, self-contained function.

this is too much content to appear directly

[mrT23]

can you stack all the 'incremental' parameters ?
i don't want the config to be just a long incoherent list

something like

/# incremental parameters:
minimal_commits_for_incremental_review=0
minimal_minutes_for_incremental_review=0
...

[mrT23]

@zmeir i gave some comments.

in addition, this is a complicated ability.
Even after reviewing the code, I didn't fully understand what each parameter meant.
please add 3-4 lines of documentation the help make this ability accessible.

[zmeir]

@okotek @mrT23 Thanks for the review - I've implemented all of your suggestions, please let me know if anything else is missing, or if you have any further questions.

[hussam789]

@zmeir Thanks for adding this configuration / criteria!