Use eslint-seatbelt baseline instead of inline eslint-disable comments

Co-authored-by: Linh Vo <linhvovan29546@users.noreply.github.com>

Author: MelvinBot

config/eslint/eslint.config.mjs

@@ -721,6 +721,8 @@ const config = defineConfig([
     // This uses the typescript-eslint variant of `no-restricted-imports` (a separate rule name, so it stacks
     // with the base rule above instead of overriding it) because only that variant supports `allowTypeImports`,
     // and `src/types/onyx/Request.ts` legitimately does `import type OnyxUtils from 'react-native-onyx/dist/OnyxUtils'`.
+    // The 14 existing runtime imports are grandfathered via the seatbelt baseline so they stay visible and can be
+    // paid down under https://github.com/Expensify/App/issues/98610; this only blocks NEW usages.
     {
         files: ['**/*.ts', '**/*.tsx'],
         plugins: {

config/eslint/eslint.seatbelt.tsv

@@ -883,6 +883,7 @@
 "../../src/libs/memoize/cache/ArrayCache.ts"	"@typescript-eslint/no-unsafe-type-assertion"	1
 "../../src/libs/memoize/index.ts"	"@typescript-eslint/no-unsafe-type-assertion"	8
 "../../src/libs/memoize/utils.ts"	"@typescript-eslint/no-unsafe-type-assertion"	7
+"../../src/libs/migrations/MoveFilesOutOfDocuments/index.native.ts"	"@typescript-eslint/no-restricted-imports"	1
 "../../src/libs/models/BankAccount.ts"	"@typescript-eslint/no-unsafe-type-assertion"	1
 "../../src/libs/prepareRequestPayload/index.native.ts"	"@typescript-eslint/no-unsafe-type-assertion"	5
 "../../src/libs/prepareRequestPayload/index.ts"	"@typescript-eslint/no-unsafe-type-assertion"	1
@@ -1382,28 +1383,41 @@
 "../../tests/actions/IOUTest/TrackExpenseTest.ts"	"no-restricted-imports"	1
 "../../tests/actions/IOUTest/UpdateMoneyRequestTest.ts"	"no-restricted-imports"	1
 "../../tests/actions/OdometerTransactionUtilsTest.ts"	"no-restricted-imports"	1
+"../../tests/actions/OnyxUpdateManagerTest.ts"	"@typescript-eslint/no-restricted-imports"	1
+"../../tests/actions/PolicyCategoryTest.ts"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/actions/PolicyProfileTest.ts"	"no-restricted-imports"	1
+"../../tests/actions/PolicyTagTest.ts"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/actions/PolicyTest.ts"	"no-restricted-imports"	1
 "../../tests/actions/ReportFieldTest.ts"	"no-restricted-imports"	1
 "../../tests/actions/ReportPreviewActionUtilsTest.ts"	"no-restricted-imports"	2
+"../../tests/actions/ReportTest.ts"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/actions/ReportTest.ts"	"no-restricted-imports"	1
 "../../tests/actions/TaskTest.ts"	"no-restricted-imports"	1
 "../../tests/actions/TransactionTest.ts"	"no-restricted-imports"	1
 "../../tests/ui/ComposerTest.tsx"	"rulesdir/no-raw-typography"	1
 "../../tests/ui/MoneyRequestReportPreview.test.tsx"	"no-restricted-imports"	1
+"../../tests/ui/UnreadIndicatorsTest.tsx"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/ui/WorkspaceMoreFeaturesPageTest.tsx"	"no-restricted-imports"	1
 "../../tests/ui/components/Button.tsx"	"no-restricted-imports"	1
+"../../tests/ui/components/IOURequestStepConfirmationPageTest.tsx"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/unit/FormulaTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/HomePage/YourSpendSection/useYourSpendDataTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/IOUUtilsTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/ModifiedExpenseMessageTest.ts"	"no-restricted-imports"	1
+"../../tests/unit/OnyxDerivedSelfHealTest.ts"	"@typescript-eslint/no-restricted-imports"	1
+"../../tests/unit/OnyxDerivedTest.tsx"	"@typescript-eslint/no-restricted-imports"	1
+"../../tests/unit/PersistedRequests.ts"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/unit/QuickActionUtilsTest.ts"	"no-restricted-imports"	2
 "../../tests/unit/ReportPrimaryActionUtilsTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/ReportSecondaryActionUtilsTest.ts"	"no-restricted-imports"	2
 "../../tests/unit/ReportTitleUtilsTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/ReportUtilsTest.ts"	"no-restricted-imports"	1
+"../../tests/unit/SearchAutocompleteListTest.tsx"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/unit/SidebarUtilsTest.ts"	"no-restricted-imports"	1
+"../../tests/unit/TransactionTest.ts"	"@typescript-eslint/no-restricted-imports"	1
+"../../tests/unit/WorkspacesSettingsUtilsTest.ts"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/unit/canEditFieldOfMoneyRequestTest.ts"	"@typescript-eslint/no-deprecated/randomReportAction.originalMessage"	3
+"../../tests/unit/canEditFieldOfMoneyRequestTest.ts"	"@typescript-eslint/no-restricted-imports"	1
 "../../tests/unit/components/HTMLEngineProvider/VictoryChartAttributesParsers.test.ts"	"rulesdir/no-raw-typography"	1
 "../../tests/unit/navigateAfterOnboardingTest.ts"	"no-restricted-imports"	1
 "../../tests/unit/navigateToWorkspacesPageTest.ts"	"no-restricted-imports"	1

src/libs/migrations/MoveFilesOutOfDocuments/index.native.ts

@@ -9,7 +9,6 @@ import type {OnyxCollection} from 'react-native-onyx';
 
 import RNFS from 'react-native-fs';
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 const OLD_ATTACHMENT_DIR = `${RNFS.DocumentDirectoryPath}/attachments`;

tests/actions/OnyxUpdateManagerTest.ts

@@ -15,7 +15,6 @@ import type * as OnyxTypes from '@src/types/onyx';
 import type {OnyxEntry} from 'react-native-onyx';
 
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 import createMock from '../utils/createMock';

tests/actions/PolicyCategoryTest.ts

@@ -22,7 +22,6 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import type {Policy, PolicyCategory} from '@src/types/onyx';
 
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 import type {MockFetch} from '../utils/TestHelper';

tests/actions/PolicyTagTest.ts

@@ -30,7 +30,6 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import type {PolicyTagLists, PolicyTags, RecentlyUsedTags} from '@src/types/onyx';
 
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 import type {MockFetch} from '../utils/TestHelper';

tests/actions/ReportTest.ts

@@ -47,7 +47,6 @@ import type {OnyxCollection, OnyxEntry, OnyxUpdate} from 'react-native-onyx';
 import {addSeconds, format, subMinutes} from 'date-fns';
 import {toZonedTime} from 'date-fns-tz';
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 import type {MockFetch} from '../utils/TestHelper';

tests/ui/UnreadIndicatorsTest.tsx

@@ -26,7 +26,6 @@ import {toZonedTime} from 'date-fns-tz';
 import React from 'react';
 import {AppState, DeviceEventEmitter} from 'react-native';
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 import type {NativeNavigationMock} from '../../__mocks__/@react-navigation/native';

tests/ui/components/IOURequestStepConfirmationPageTest.tsx

@@ -21,7 +21,6 @@ import type {OnyxEntry} from 'react-native-onyx';
 
 import React from 'react';
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 import * as MoneyRequest from '../../../src/libs/actions/IOU/MoneyRequest';

tests/unit/OnyxDerivedSelfHealTest.ts

@@ -6,7 +6,6 @@ import ONYXKEYS from '@src/ONYXKEYS';
 import type {Transaction} from '@src/types/onyx';
 
 import Onyx from 'react-native-onyx';
-// eslint-disable-next-line @typescript-eslint/no-restricted-imports -- pre-existing usage, tracked for removal in https://github.com/Expensify/App/issues/98610
 import OnyxUtils from 'react-native-onyx/dist/OnyxUtils';
 
 import createRandomTransaction from '../utils/collections/transaction';