From 9ea6b2fdd2b4a59de2ff14eb88a922355b6e63a6 Mon Sep 17 00:00:00 2001 From: Alberto Date: Tue, 12 Sep 2023 14:49:22 +0800 Subject: [PATCH 1/3] Display correct title when missing details --- src/languages/en.ts | 1 + src/libs/ReportUtils.js | 4 ++++ 2 files changed, 5 insertions(+) diff --git a/src/languages/en.ts b/src/languages/en.ts index d797e8adfa93..c6fff4bd4835 100755 --- a/src/languages/en.ts +++ b/src/languages/en.ts @@ -498,6 +498,7 @@ export default { pending: 'Pending', deleteReceipt: 'Delete receipt', receiptScanning: 'Receipt scan in progress…', + receiptMissingDetails: 'Receipt missing details', receiptStatusTitle: 'Scanning…', receiptStatusText: "Only you can see this receipt when it's scanning. Check back later or enter the details now.", requestCount: ({count, scanningReceipts = 0}: RequestCountParams) => `${count} requests${scanningReceipts > 0 ? `, ${scanningReceipts} scanning` : ''}`, diff --git a/src/libs/ReportUtils.js b/src/libs/ReportUtils.js index 8b84555ca2a9..d559e268d902 100644 --- a/src/libs/ReportUtils.js +++ b/src/libs/ReportUtils.js @@ -1399,6 +1399,10 @@ function getTransactionReportName(reportAction) { return Localize.translateLocal('iou.receiptScanning'); } + if (TransactionUtils.hasMissingSmartscanFields(transaction)) { + return Localize.translateLocal('iou.receiptMissingDetails'); + } + const {amount, currency, comment} = getTransactionDetails(transaction); return Localize.translateLocal(ReportActionsUtils.isSentMoneyReportAction(reportAction) ? 'iou.threadSentMoneyReportName' : 'iou.threadRequestReportName', { From 29e383c9ad9d918c56b6e168b404df14e5734dc6 Mon Sep 17 00:00:00 2001 From: Alberto Date: Tue, 12 Sep 2023 14:51:08 +0800 Subject: [PATCH 2/3] translation --- src/languages/es.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/languages/es.ts b/src/languages/es.ts index 3c5d98b724d2..d20f70bd782b 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -499,6 +499,7 @@ export default { pending: 'Pendiente', deleteReceipt: 'Eliminar recibo', receiptScanning: 'Escaneo de recibo en curso…', + receiptMissingDetails: 'Receipt con campos vacíos', receiptStatusTitle: 'Escaneando…', receiptStatusText: 'Solo tú puedes ver este recibo cuando se está escaneando. Vuelve más tarde o introduce los detalles ahora.', requestCount: ({count, scanningReceipts = 0}: RequestCountParams) => `${count} solicitudes${scanningReceipts > 0 ? `, ${scanningReceipts} escaneando` : ''}`, From 3b26aa2d83fb5b691523fc2c084dea57644b5174 Mon Sep 17 00:00:00 2001 From: Alberto Date: Tue, 12 Sep 2023 15:57:55 +0800 Subject: [PATCH 3/3] typo --- src/languages/es.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/languages/es.ts b/src/languages/es.ts index d20f70bd782b..42ae5103b043 100644 --- a/src/languages/es.ts +++ b/src/languages/es.ts @@ -499,7 +499,7 @@ export default { pending: 'Pendiente', deleteReceipt: 'Eliminar recibo', receiptScanning: 'Escaneo de recibo en curso…', - receiptMissingDetails: 'Receipt con campos vacíos', + receiptMissingDetails: 'Recibo con campos vacíos', receiptStatusTitle: 'Escaneando…', receiptStatusText: 'Solo tú puedes ver este recibo cuando se está escaneando. Vuelve más tarde o introduce los detalles ahora.', requestCount: ({count, scanningReceipts = 0}: RequestCountParams) => `${count} solicitudes${scanningReceipts > 0 ? `, ${scanningReceipts} escaneando` : ''}`,