From 80ad89ba46c98044ad9461c4d7b86a0bc038c5a5 Mon Sep 17 00:00:00 2001 From: Rodrigo Lino da Costa Date: Tue, 24 Sep 2024 17:42:07 -0300 Subject: [PATCH 1/2] not showing three dot menu in members page if not admin --- src/pages/workspace/WorkspaceMembersPage.tsx | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/pages/workspace/WorkspaceMembersPage.tsx b/src/pages/workspace/WorkspaceMembersPage.tsx index a3fc5efc1346..113e79ff5792 100644 --- a/src/pages/workspace/WorkspaceMembersPage.tsx +++ b/src/pages/workspace/WorkspaceMembersPage.tsx @@ -565,6 +565,10 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson }; const threeDotsMenuItems = useMemo(() => { + if (!isPolicyAdmin) { + return []; + } + const menuItems = [ { icon: Expensicons.Table, @@ -610,7 +614,7 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson testID={WorkspaceMembersPage.displayName} shouldShowLoading={false} shouldShowOfflineIndicatorInWideScreen - shouldShowThreeDotsButton + shouldShowThreeDotsButton={isPolicyAdmin} threeDotsMenuItems={threeDotsMenuItems} threeDotsAnchorPosition={styles.threeDotsPopoverOffsetNoCloseButton(windowWidth)} shouldShowNonAdmin From a752d0c0096a53d7fffa442c5338f01f4e02dee9 Mon Sep 17 00:00:00 2001 From: Rodrigo Lino da Costa Date: Tue, 24 Sep 2024 17:54:08 -0300 Subject: [PATCH 2/2] adding isPolicyAdmin to memo --- src/pages/workspace/WorkspaceMembersPage.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/workspace/WorkspaceMembersPage.tsx b/src/pages/workspace/WorkspaceMembersPage.tsx index 113e79ff5792..5593881354a3 100644 --- a/src/pages/workspace/WorkspaceMembersPage.tsx +++ b/src/pages/workspace/WorkspaceMembersPage.tsx @@ -600,7 +600,7 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson ]; return menuItems; - }, [policyID, translate, isOffline]); + }, [policyID, translate, isOffline, isPolicyAdmin]); const selectionModeHeader = selectionMode?.isEnabled && shouldUseNarrowLayout;