diff --git a/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx b/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx index b24dd3c4d17c..b404f876c9b6 100644 --- a/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx +++ b/src/components/MoneyRequestReportView/MoneyRequestReportTransactionList.tsx @@ -28,7 +28,7 @@ import Parser from '@libs/Parser'; import {getIOUActionForTransactionID} from '@libs/ReportActionsUtils'; import {getMoneyRequestSpendBreakdown, isExpenseReport} from '@libs/ReportUtils'; import {compareValues, getColumnsToShow, isTransactionAmountTooLong, isTransactionTaxAmountTooLong} from '@libs/SearchUIUtils'; -import {getAmount, getCategory, getCreated, getMerchant, getTag, getTransactionPendingAction, isTransactionPendingDelete} from '@libs/TransactionUtils'; +import {getAmount, getCategory, getCreated, getMerchant, getTag, getTransactionPendingAction, isTransactionPendingDelete, shouldShowViolation} from '@libs/TransactionUtils'; import shouldShowTransactionYear from '@libs/TransactionUtils/shouldShowTransactionYear'; import Navigation from '@navigation/Navigation'; import type {ReportsSplitNavigatorParamList} from '@navigation/types'; @@ -159,6 +159,28 @@ function MoneyRequestReportTransactionList({ const isMobileSelectionModeEnabled = useMobileSelectionMode(); const personalDetailsList = usePersonalDetails(); + // Filter violations based on user visibility + const filteredViolations = useMemo(() => { + if (!violations || !report || !policy || !transactions) { + return violations; + } + + const filtered: Record = {}; + + for (const transaction of transactions) { + const transactionViolations = violations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`]; + if (transactionViolations) { + const filteredTransactionViolations = transactionViolations.filter((violation) => shouldShowViolation(report, policy, violation.name)); + + if (filteredTransactionViolations.length > 0) { + filtered[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`] = filteredTransactionViolations; + } + } + } + + return filtered; + }, [violations, report, policy, transactions]); + const toggleTransaction = useCallback( (transactionID: string) => { let newSelectedTransactionIDs = selectedTransactionIDs; @@ -348,7 +370,7 @@ function MoneyRequestReportTransactionList({ { + if (!violations || !searchResults?.data) { + return violations; + } + + const filtered: Record = {}; + + const transactionKeys = Object.keys(searchResults.data).filter((key) => key.startsWith(ONYXKEYS.COLLECTION.TRANSACTION)); + + for (const key of transactionKeys) { + const transaction = searchResults.data[key as keyof typeof searchResults.data] as SearchTransaction; + if (!transaction || typeof transaction !== 'object' || !('transactionID' in transaction) || !('reportID' in transaction)) { + continue; + } + + const report = searchResults.data[`${ONYXKEYS.COLLECTION.REPORT}${transaction.reportID}`]; + const policy = searchResults.data[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`]; + + if (report && policy) { + const transactionViolations = violations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`]; + if (transactionViolations) { + const filteredTransactionViolations = transactionViolations.filter((violation) => + shouldShowViolation(report as OnyxEntry, policy as OnyxEntry, violation.name), + ); + + if (filteredTransactionViolations.length > 0) { + filtered[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`] = filteredTransactionViolations; + } + } + } + } + + return filtered; + }, [violations, searchResults]); + const [archivedReportsIdSet = new Set()] = useOnyx(ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS, { canBeMissing: true, selector: selectArchivedReportsIdSet, @@ -904,7 +945,7 @@ function Search({queryJSON, searchResults, onSearchListScroll, contentContainerS queryJSON={queryJSON} columns={columnsToShow} areAllOptionalColumnsHidden={areAllOptionalColumnsHidden} - violations={violations} + violations={filteredViolations} onLayout={onLayout} isMobileSelectionModeEnabled={isMobileSelectionModeEnabled} shouldAnimate={type === CONST.SEARCH.DATA_TYPES.EXPENSE} diff --git a/src/libs/ReportPreviewActionUtils.ts b/src/libs/ReportPreviewActionUtils.ts index ad9223b3cf9b..8305564efc73 100644 --- a/src/libs/ReportPreviewActionUtils.ts +++ b/src/libs/ReportPreviewActionUtils.ts @@ -29,6 +29,7 @@ import { } from './ReportUtils'; import {getSession} from './SessionUtils'; import {allHavePendingRTERViolation, isPending, isScanning, shouldShowBrokenConnectionViolationForMultipleTransactions} from './TransactionUtils'; +import ViolationsUtils from './Violations/ViolationsUtils'; function canSubmit(report: Report, violations: OnyxCollection, isReportArchived: boolean, policy?: Policy, transactions?: Transaction[]) { if (isReportArchived) { @@ -181,12 +182,13 @@ function canExport(report: Report, violations: OnyxCollection, isReportArchived: boolean, policy?: Policy, transactions?: Transaction[]) { const hasAnyViolations = hasMissingSmartscanFields(report.reportID, transactions) || hasAnyViolationsUtil(report.reportID, violations); + const hasVisibleViolations = hasAnyViolations && ViolationsUtils.hasVisibleViolationsForUser(report, violations, policy, transactions); const isSubmitter = isCurrentUserSubmitter(report); const isOpen = isOpenExpenseReport(report); const isReimbursed = isSettled(report); if ( - !hasAnyViolations || + !hasVisibleViolations || isReimbursed || (!(isSubmitter && isOpen && policy?.areWorkflowsEnabled) && !canApprove(report, violations, policy, transactions, false) && diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index 4676cc560998..0aa9401739fc 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -8430,9 +8430,12 @@ function shouldDisplayViolationsRBRInLHN(report: OnyxEntry, transactionV if (!potentialReport) { return false; } + const policy = allPolicies?.[`${ONYXKEYS.COLLECTION.POLICY}${potentialReport.policyID}`]; + const transactions = getReportTransactions(potentialReport.reportID); return ( !isInvoiceReport(potentialReport) && + ViolationsUtils.hasVisibleViolationsForUser(potentialReport, transactionViolations, policy, transactions) && (hasViolations(potentialReport.reportID, transactionViolations, true) || hasWarningTypeViolations(potentialReport.reportID, transactionViolations, true) || hasNoticeTypeViolations(potentialReport.reportID, transactionViolations, true)) diff --git a/src/libs/SearchUIUtils.ts b/src/libs/SearchUIUtils.ts index 84bd229c0fee..8322c67b6fb7 100644 --- a/src/libs/SearchUIUtils.ts +++ b/src/libs/SearchUIUtils.ts @@ -121,6 +121,7 @@ import { isViolationDismissed, } from './TransactionUtils'; import shouldShowTransactionYear from './TransactionUtils/shouldShowTransactionYear'; +import ViolationsUtils from './Violations/ViolationsUtils'; const transactionColumnNamesToSortingProperty = { [CONST.SEARCH.TABLE_COLUMNS.TO]: 'formattedTo' as const, @@ -1149,8 +1150,11 @@ function getActions( const chatReportRNVP = data[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${report.chatReportID}`] ?? undefined; const isChatReportArchived = isArchivedReport(chatReportRNVP); + const hasAnyViolationsForReport = hasAnyViolations(report.reportID, allViolations, allReportTransactions); + const hasVisibleViolationsForReport = hasAnyViolationsForReport && ViolationsUtils.hasVisibleViolationsForUser(report, allViolations, policy, allReportTransactions); + // Only check for violations if we need to (when user has permission to review) - if ((isSubmitter || isApprover || isAdmin) && hasAnyViolations(report.reportID, allViolations, allReportTransactions)) { + if ((isSubmitter || isApprover || isAdmin) && hasVisibleViolationsForReport) { if (isSubmitter && !isApprover && !isAdmin && !canReview(report, allViolations, isIOUReportArchived || isChatReportArchived, policy, allReportTransactions)) { allActions.push(CONST.SEARCH.ACTION_TYPES.VIEW); } else { diff --git a/src/libs/Violations/ViolationsUtils.ts b/src/libs/Violations/ViolationsUtils.ts index 9e01bc72b326..80999381f056 100644 --- a/src/libs/Violations/ViolationsUtils.ts +++ b/src/libs/Violations/ViolationsUtils.ts @@ -1,8 +1,8 @@ import isEmpty from 'lodash/isEmpty'; import keyBy from 'lodash/keyBy'; import reject from 'lodash/reject'; +import type {OnyxCollection, OnyxEntry, OnyxUpdate} from 'react-native-onyx'; import Onyx from 'react-native-onyx'; -import type {OnyxUpdate} from 'react-native-onyx'; import type {LocaleContextProps} from '@components/LocaleContextProvider'; import * as CurrencyUtils from '@libs/CurrencyUtils'; import DateUtils from '@libs/DateUtils'; @@ -10,9 +10,10 @@ import {isReceiptError} from '@libs/ErrorUtils'; import Parser from '@libs/Parser'; import {getDistanceRateCustomUnitRate, getPerDiemRateCustomUnitRate, getSortedTagKeys} from '@libs/PolicyUtils'; import * as TransactionUtils from '@libs/TransactionUtils'; +import {shouldShowViolation} from '@libs/TransactionUtils'; import CONST from '@src/CONST'; import ONYXKEYS from '@src/ONYXKEYS'; -import type {Policy, PolicyCategories, PolicyTagLists, ReportAction, Transaction, TransactionViolation, ViolationName} from '@src/types/onyx'; +import type {Policy, PolicyCategories, PolicyTagLists, Report, ReportAction, Transaction, TransactionViolation, ViolationName} from '@src/types/onyx'; import type {Errors} from '@src/types/onyx/OnyxCommon'; import type {ReceiptError, ReceiptErrors} from '@src/types/onyx/Transaction'; @@ -611,6 +612,29 @@ const ViolationsUtils = { .filter(Boolean) .join(' '); }, + + /** + * Checks if any transactions in the report have violations that should be visible to the current user. + * Filters violations based on user role (submitter, admin, policy member) and report state. + */ + hasVisibleViolationsForUser(report: OnyxEntry, violations: OnyxCollection, policy?: OnyxEntry, transactions?: Transaction[]): boolean { + if (!report || !violations || !transactions) { + return false; + } + + // Check if any transaction has at least one violation visible to the current user + return transactions.some((transaction) => { + const transactionViolations = violations[`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${transaction.transactionID}`]; + if (!transactionViolations) { + return false; + } + + // Check if any violation should be shown based on user role and violation type + return transactionViolations.some((violation: TransactionViolation) => { + return shouldShowViolation(report, policy, violation.name); + }); + }); + }, }; export default ViolationsUtils; diff --git a/tests/actions/ReportPreviewActionUtilsTest.ts b/tests/actions/ReportPreviewActionUtilsTest.ts index 78c41f468d2b..5c9329cdd423 100644 --- a/tests/actions/ReportPreviewActionUtilsTest.ts +++ b/tests/actions/ReportPreviewActionUtilsTest.ts @@ -489,13 +489,23 @@ describe('getReportPreviewAction', () => { name: CONST.VIOLATIONS.OVER_LIMIT, } as TransactionViolation, ]); + const violations: OnyxCollection = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${TRANSACTION_ID}`]: [ + { + name: CONST.VIOLATIONS.OVER_LIMIT, + type: CONST.VIOLATION_TYPES.VIOLATION, + } as TransactionViolation, + ], + }; + const transaction = { + transactionID: `${TRANSACTION_ID}`, reportID: `${REPORT_ID}`, } as unknown as Transaction; const {result: isReportArchived} = renderHook(() => useReportIsArchived(report?.parentReportID)); await waitForBatchedUpdatesWithAct(); - expect(getReportPreviewAction(VIOLATIONS, isReportArchived.current, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW); + expect(getReportPreviewAction(violations, isReportArchived.current, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW); }); it('canReview should return true for reports with RTER violations regardless of workspace workflow configuration', async () => { @@ -519,20 +529,25 @@ describe('getReportPreviewAction', () => { } as unknown as ReportViolations; await Onyx.set(`${ONYXKEYS.COLLECTION.REPORT_VIOLATIONS}${REPORT_ID}`, REPORT_VIOLATION); - await Onyx.set(`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${TRANSACTION_ID}`, [ - { - name: CONST.VIOLATIONS.RTER, - data: { - pendingPattern: true, - rterType: CONST.RTER_VIOLATION_TYPES.SEVEN_DAY_HOLD, - }, - } as TransactionViolation, - ]); + const violations: OnyxCollection = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${TRANSACTION_ID}`]: [ + { + name: CONST.VIOLATIONS.RTER, + type: CONST.VIOLATION_TYPES.VIOLATION, + data: { + pendingPattern: true, + rterType: CONST.RTER_VIOLATION_TYPES.SEVEN_DAY_HOLD, + }, + } as TransactionViolation, + ], + }; + const transaction = { + transactionID: `${TRANSACTION_ID}`, reportID: `${REPORT_ID}`, } as unknown as Transaction; - expect(getReportPreviewAction(VIOLATIONS, false, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW); + expect(getReportPreviewAction(violations, false, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW); }); it('canView should return true for reports in which we are waiting for user to add a bank account', async () => { @@ -557,4 +572,122 @@ describe('getReportPreviewAction', () => { await waitForBatchedUpdatesWithAct(); expect(getReportPreviewAction(VIOLATIONS, isReportArchived.current, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.VIEW); }); + + it('canReview should return false for submitters when RECEIPT_NOT_SMART_SCANNED violation exists but is hidden from submitter', async () => { + (ReportUtils.hasAnyViolations as jest.Mock).mockReturnValue(true); + const report: Report = { + ...createRandomReport(REPORT_ID), + statusNum: 0, + stateNum: 0, + type: CONST.REPORT.TYPE.EXPENSE, + ownerAccountID: CURRENT_USER_ACCOUNT_ID, + isWaitingOnBankAccount: false, + }; + + const policy = createRandomPolicy(0); + policy.areWorkflowsEnabled = true; + policy.type = CONST.POLICY.TYPE.CORPORATE; + + await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report); + + // Create a RECEIPT_NOT_SMART_SCANNED violation that should be hidden from submitter + const violations: OnyxCollection = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${TRANSACTION_ID}`]: [ + { + name: CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED, + type: CONST.VIOLATION_TYPES.VIOLATION, + } as TransactionViolation, + ], + }; + + const transaction = { + transactionID: `${TRANSACTION_ID}`, + reportID: `${REPORT_ID}`, + } as unknown as Transaction; + + const {result: isReportArchived} = renderHook(() => useReportIsArchived(report?.parentReportID)); + // Should return VIEW instead of REVIEW because the violation is hidden from submitter + expect(getReportPreviewAction(violations, isReportArchived.current, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.VIEW); + }); + + it('canReview should return true when report has mix of visible and hidden violations but at least one is visible', async () => { + (ReportUtils.hasAnyViolations as jest.Mock).mockReturnValue(true); + const report: Report = { + ...createRandomReport(REPORT_ID), + statusNum: 0, + stateNum: 0, + type: CONST.REPORT.TYPE.EXPENSE, + ownerAccountID: CURRENT_USER_ACCOUNT_ID, + isWaitingOnBankAccount: false, + }; + + const policy = createRandomPolicy(0); + policy.areWorkflowsEnabled = true; + policy.type = CONST.POLICY.TYPE.CORPORATE; + + await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report); + + // Mix of hidden and visible violations + const violations: OnyxCollection = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${TRANSACTION_ID}`]: [ + { + name: CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED, + type: CONST.VIOLATION_TYPES.VIOLATION, + } as TransactionViolation, + { + name: CONST.VIOLATIONS.MISSING_CATEGORY, + type: CONST.VIOLATION_TYPES.VIOLATION, + } as TransactionViolation, + ], + }; + + const transaction = { + transactionID: `${TRANSACTION_ID}`, + reportID: `${REPORT_ID}`, + } as unknown as Transaction; + + const {result: isReportArchived} = renderHook(() => useReportIsArchived(report?.parentReportID)); + // Should return REVIEW because at least one violation (MISSING_CATEGORY) is visible + expect(getReportPreviewAction(violations, isReportArchived.current, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.REVIEW); + }); + + it('canReview should return false when report has no visible violations for current user role', async () => { + (ReportUtils.hasAnyViolations as jest.Mock).mockReturnValue(true); + const report: Report = { + ...createRandomReport(REPORT_ID), + statusNum: 0, + stateNum: 0, + type: CONST.REPORT.TYPE.EXPENSE, + ownerAccountID: CURRENT_USER_ACCOUNT_ID, + isWaitingOnBankAccount: false, + }; + + const policy = createRandomPolicy(0); + policy.areWorkflowsEnabled = true; + policy.type = CONST.POLICY.TYPE.CORPORATE; + + await Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${REPORT_ID}`, report); + + // All violations hidden from submitter + const violations: OnyxCollection = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${TRANSACTION_ID}`]: [ + { + name: CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED, + type: CONST.VIOLATION_TYPES.NOTICE, + } as TransactionViolation, + { + name: CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED, + type: CONST.VIOLATION_TYPES.WARNING, + } as TransactionViolation, + ], + }; + + const transaction = { + transactionID: `${TRANSACTION_ID}`, + reportID: `${REPORT_ID}`, + } as unknown as Transaction; + + const {result: isReportArchived} = renderHook(() => useReportIsArchived(report?.parentReportID)); + expect(getReportPreviewAction(violations, isReportArchived.current, report, policy, [transaction])).toBe(CONST.REPORT.REPORT_PREVIEW_ACTIONS.VIEW); + }); }); diff --git a/tests/unit/ViolationUtilsTest.ts b/tests/unit/ViolationUtilsTest.ts index c0c26e0af5a1..afffa0890a96 100644 --- a/tests/unit/ViolationUtilsTest.ts +++ b/tests/unit/ViolationUtilsTest.ts @@ -6,7 +6,7 @@ import {getTransactionViolations, hasWarningTypeViolation, isViolationDismissed} import ViolationsUtils from '@libs/Violations/ViolationsUtils'; import CONST from '@src/CONST'; import ONYXKEYS from '@src/ONYXKEYS'; -import type {Policy, PolicyCategories, PolicyTagLists, Transaction, TransactionViolation} from '@src/types/onyx'; +import type {Policy, PolicyCategories, PolicyTagLists, Report, Transaction, TransactionViolation} from '@src/types/onyx'; import type {TransactionCollectionDataSet} from '@src/types/onyx/Transaction'; const categoryOutOfPolicyViolation = { @@ -716,3 +716,163 @@ describe('getRBRMessages', () => { expect(result).toBe(expectedResult); }); }); + +describe('hasVisibleViolationsForUser', () => { + const submitterAccountID = 12345; + const testReportID = 'test-report-123'; + const testTransactionID = 'test-transaction-123'; + const testPolicyID = 'test-policy-123'; + + const mockReport = { + reportID: testReportID, + ownerAccountID: submitterAccountID, + policyID: testPolicyID, + stateNum: CONST.REPORT.STATE_NUM.OPEN, + statusNum: CONST.REPORT.STATUS_NUM.OPEN, + } as Report; + + const mockPolicy = { + id: testPolicyID, + role: CONST.POLICY.ROLE.ADMIN, + type: CONST.POLICY.TYPE.TEAM, + } as Policy; + + const mockTransaction = { + transactionID: testTransactionID, + reportID: testReportID, + accountID: submitterAccountID, + amount: 1000, + created: '2023-01-01', + currency: 'USD', + merchant: 'Test Merchant', + } as Transaction; + + beforeEach(() => { + Onyx.set(ONYXKEYS.SESSION, {accountID: submitterAccountID}); + }); + + it('should return false when report is null', () => { + const violations = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${testTransactionID}`]: [missingCategoryViolation], + }; + + const result = ViolationsUtils.hasVisibleViolationsForUser(undefined, violations, mockPolicy, [mockTransaction]); + expect(result).toBe(false); + }); + + it('should return false when violations is null', () => { + const result = ViolationsUtils.hasVisibleViolationsForUser(mockReport, undefined, mockPolicy, [mockTransaction]); + expect(result).toBe(false); + }); + + it('should return false when transactions is null', () => { + const violations = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${testTransactionID}`]: [missingCategoryViolation], + }; + + const result = ViolationsUtils.hasVisibleViolationsForUser(mockReport, violations, mockPolicy); + expect(result).toBe(false); + }); + + it('should return false when no violations exist for transactions', () => { + const violations = {}; + + const result = ViolationsUtils.hasVisibleViolationsForUser(mockReport, violations, mockPolicy, [mockTransaction]); + expect(result).toBe(false); + }); + + it('should return true when violations are visible to submitter', () => { + const violations = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${testTransactionID}`]: [missingCategoryViolation], + }; + + // Mock shouldShowViolation to return true for missing category + jest.spyOn(require('@src/libs/TransactionUtils'), 'shouldShowViolation').mockReturnValue(true); + + const result = ViolationsUtils.hasVisibleViolationsForUser(mockReport, violations, mockPolicy, [mockTransaction]); + expect(result).toBe(true); + }); + + it('should return false when violations are hidden from submitter', () => { + const violations = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${testTransactionID}`]: [ + { + name: CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED, + type: CONST.VIOLATION_TYPES.NOTICE, + }, + ], + }; + + // Mock shouldShowViolation to return false for RECEIPT_NOT_SMART_SCANNED (hidden from submitter) + jest.spyOn(require('@src/libs/TransactionUtils'), 'shouldShowViolation').mockImplementation((report, policy, violationName) => { + if (violationName === CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED) { + return false; // Hidden from submitter + } + return true; + }); + + const result = ViolationsUtils.hasVisibleViolationsForUser(mockReport, violations, mockPolicy, [mockTransaction]); + expect(result).toBe(false); + }); + + it('should return true when at least one violation is visible', () => { + const violations = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${testTransactionID}`]: [ + { + name: CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED, + type: CONST.VIOLATION_TYPES.NOTICE, + }, + missingCategoryViolation, + ], + }; + + jest.spyOn(require('@src/libs/TransactionUtils'), 'shouldShowViolation').mockImplementation((report, policy, violationName) => { + if (violationName === CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED) { + return false; + } + if (violationName === CONST.VIOLATIONS.MISSING_CATEGORY) { + return true; + } + return true; + }); + + const result = ViolationsUtils.hasVisibleViolationsForUser(mockReport, violations, mockPolicy, [mockTransaction]); + expect(result).toBe(true); + }); + + it('should handle multiple transactions correctly', () => { + const secondTransactionID = 'test-transaction-456'; + const secondTransaction = { + transactionID: secondTransactionID, + reportID: testReportID, + accountID: submitterAccountID, + amount: 2000, + created: '2023-01-02', + currency: 'USD', + merchant: 'Test Merchant 2', + } as Transaction; + + const violations = { + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${testTransactionID}`]: [ + { + name: CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED, + type: CONST.VIOLATION_TYPES.NOTICE, + }, + ], + [`${ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS}${secondTransactionID}`]: [missingCategoryViolation], + }; + + jest.spyOn(require('@src/libs/TransactionUtils'), 'shouldShowViolation').mockImplementation((report, policy, violationName) => { + if (violationName === CONST.VIOLATIONS.RECEIPT_NOT_SMART_SCANNED) { + return false; + } + if (violationName === CONST.VIOLATIONS.MISSING_CATEGORY) { + return true; + } + return true; + }); + + const result = ViolationsUtils.hasVisibleViolationsForUser(mockReport, violations, mockPolicy, [mockTransaction, secondTransaction]); + expect(result).toBe(true); + }); +});