From edabeb5ab31bc2551c0061d07f827246b77f036f Mon Sep 17 00:00:00 2001 From: Maruf Sharifi Date: Sun, 7 Dec 2025 14:41:44 +0430 Subject: [PATCH 1/6] fix: ensure pending notifications are delivered when user comes back online --- src/libs/Notification/triggerNotifications.ts | 22 +++++++++++++++++++ src/libs/actions/OnyxUpdates.ts | 5 +++++ src/libs/actions/User.ts | 19 +--------------- 3 files changed, 28 insertions(+), 18 deletions(-) create mode 100644 src/libs/Notification/triggerNotifications.ts diff --git a/src/libs/Notification/triggerNotifications.ts b/src/libs/Notification/triggerNotifications.ts new file mode 100644 index 000000000000..276af1553ac2 --- /dev/null +++ b/src/libs/Notification/triggerNotifications.ts @@ -0,0 +1,22 @@ +import type {OnyxCollection} from 'react-native-onyx'; +import {showReportActionNotification} from '@libs/actions/Report'; +import ONYXKEYS from '@src/ONYXKEYS'; +import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; +import type ReportAction from '@src/types/onyx/ReportAction'; + +export default function triggerNotifications(onyxUpdates: OnyxServerUpdate[]) { + for (const update of onyxUpdates) { + if (!update.shouldNotify && !update.shouldShowPushNotification) { + continue; + } + + const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); + const reportActions = Object.values((update.value as OnyxCollection) ?? {}); + + for (const action of reportActions) { + if (action) { + showReportActionNotification(reportID, action); + } + } + } +} diff --git a/src/libs/actions/OnyxUpdates.ts b/src/libs/actions/OnyxUpdates.ts index 053a0b739140..f40de1aa5836 100644 --- a/src/libs/actions/OnyxUpdates.ts +++ b/src/libs/actions/OnyxUpdates.ts @@ -3,6 +3,7 @@ import Onyx from 'react-native-onyx'; import type {Merge} from 'type-fest'; import {READ_COMMANDS, SIDE_EFFECT_REQUEST_COMMANDS, WRITE_COMMANDS} from '@libs/API/types'; import Log from '@libs/Log'; +import triggerNotifications from '@libs/Notification/triggerNotifications'; import Performance from '@libs/Performance'; import PusherUtils from '@libs/PusherUtils'; import CONST from '@src/CONST'; @@ -53,6 +54,10 @@ function applyHTTPSOnyxUpdates(request: Request, response: Response, lastUpdateI return onyxDataUpdatePromise .then(() => { + // Trigger notifications only on successful responses. + if (response.jsonCode === 200 && response.onyxData?.length) { + triggerNotifications(response.onyxData); + } // Handle the request's success/failure data (client-side data) if (response.jsonCode === 200 && request.successData) { return updateHandler(request.successData); diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts index be0d271da85a..8e2afc960eb3 100644 --- a/src/libs/actions/User.ts +++ b/src/libs/actions/User.ts @@ -34,6 +34,7 @@ import Log from '@libs/Log'; import Navigation from '@libs/Navigation/Navigation'; import {isOffline} from '@libs/Network/NetworkStore'; import * as SequentialQueue from '@libs/Network/SequentialQueue'; +import triggerNotifications from '@libs/Notification/triggerNotifications'; import * as NumberUtils from '@libs/NumberUtils'; import * as PersonalDetailsUtils from '@libs/PersonalDetailsUtils'; import Pusher from '@libs/Pusher'; @@ -57,7 +58,6 @@ import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {reconnectApp} from './App'; import applyOnyxUpdatesReliably from './applyOnyxUpdatesReliably'; import {openOldDotLink} from './Link'; -import {showReportActionNotification} from './Report'; import {resendValidateCode as sessionResendValidateCode} from './Session'; import Timing from './Timing'; @@ -660,23 +660,6 @@ function isBlockedFromConcierge(blockedFromConciergeNVP: OnyxEntry) ?? {}); - - for (const action of reportActions) { - if (action) { - showReportActionNotification(reportID, action); - } - } - } -} - const isChannelMuted = (reportId: string) => new Promise((resolve) => { const connection = Onyx.connect({ From ffbd8879028ab6c7c5ac6afa09926f0ef0ac6b34 Mon Sep 17 00:00:00 2001 From: Maruf Sharifi Date: Tue, 9 Dec 2025 13:02:02 +0430 Subject: [PATCH 2/6] keep the fix only for desktop web --- src/libs/Notification/triggerNotifications.ts | 22 ------------------- src/libs/actions/OnyxUpdates.ts | 6 +++-- src/libs/actions/Report.ts | 19 ++++++++++++++++ src/libs/actions/User.ts | 2 +- 4 files changed, 24 insertions(+), 25 deletions(-) delete mode 100644 src/libs/Notification/triggerNotifications.ts diff --git a/src/libs/Notification/triggerNotifications.ts b/src/libs/Notification/triggerNotifications.ts deleted file mode 100644 index 276af1553ac2..000000000000 --- a/src/libs/Notification/triggerNotifications.ts +++ /dev/null @@ -1,22 +0,0 @@ -import type {OnyxCollection} from 'react-native-onyx'; -import {showReportActionNotification} from '@libs/actions/Report'; -import ONYXKEYS from '@src/ONYXKEYS'; -import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; -import type ReportAction from '@src/types/onyx/ReportAction'; - -export default function triggerNotifications(onyxUpdates: OnyxServerUpdate[]) { - for (const update of onyxUpdates) { - if (!update.shouldNotify && !update.shouldShowPushNotification) { - continue; - } - - const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); - const reportActions = Object.values((update.value as OnyxCollection) ?? {}); - - for (const action of reportActions) { - if (action) { - showReportActionNotification(reportID, action); - } - } - } -} diff --git a/src/libs/actions/OnyxUpdates.ts b/src/libs/actions/OnyxUpdates.ts index f40de1aa5836..927565ff44fb 100644 --- a/src/libs/actions/OnyxUpdates.ts +++ b/src/libs/actions/OnyxUpdates.ts @@ -1,9 +1,10 @@ +import {Platform} from 'react-native'; import type {OnyxUpdate} from 'react-native-onyx'; import Onyx from 'react-native-onyx'; import type {Merge} from 'type-fest'; import {READ_COMMANDS, SIDE_EFFECT_REQUEST_COMMANDS, WRITE_COMMANDS} from '@libs/API/types'; +import {isMobile} from '@libs/Browser'; import Log from '@libs/Log'; -import triggerNotifications from '@libs/Notification/triggerNotifications'; import Performance from '@libs/Performance'; import PusherUtils from '@libs/PusherUtils'; import CONST from '@src/CONST'; @@ -12,6 +13,7 @@ import type {OnyxUpdateEvent, OnyxUpdatesFromServer, Request} from '@src/types/o import type Response from '@src/types/onyx/Response'; import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {queueOnyxUpdates} from './QueuedOnyxUpdates'; +import {triggerNotifications} from './Report'; // This key needs to be separate from ONYXKEYS.ONYX_UPDATES_FROM_SERVER so that it can be updated without triggering the callback when the server IDs are updated. If that // callback were triggered it would lead to duplicate processing of server updates. @@ -55,7 +57,7 @@ function applyHTTPSOnyxUpdates(request: Request, response: Response, lastUpdateI return onyxDataUpdatePromise .then(() => { // Trigger notifications only on successful responses. - if (response.jsonCode === 200 && response.onyxData?.length) { + if (Platform.OS === 'web' && !isMobile() && response.jsonCode === 200 && response.onyxData?.length) { triggerNotifications(response.onyxData); } // Handle the request's success/failure data (client-side data) diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts index 7ff5e71c7adc..7f2dcd0b2843 100644 --- a/src/libs/actions/Report.ts +++ b/src/libs/actions/Report.ts @@ -199,6 +199,7 @@ import type { Transaction, TransactionViolations, } from '@src/types/onyx'; +import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; import type {Decision} from '@src/types/onyx/OriginalMessage'; import type {CurrentUserPersonalDetails, Timezone} from '@src/types/onyx/PersonalDetails'; import type {ConnectionName} from '@src/types/onyx/Policy'; @@ -6226,6 +6227,23 @@ function setOptimisticTransactionThread(reportID?: string, parentReportID?: stri }); } +function triggerNotifications(onyxUpdates: OnyxServerUpdate[]) { + for (const update of onyxUpdates) { + if (!update.shouldNotify && !update.shouldShowPushNotification) { + continue; + } + + const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); + const reportActions = Object.values((update.value as OnyxCollection) ?? {}); + + for (const action of reportActions) { + if (action) { + showReportActionNotification(reportID, action); + } + } + } +} + export type {Video, GuidedSetupData, TaskForParameters, IntroSelected}; export { @@ -6340,4 +6358,5 @@ export { openUnreportedExpense, optimisticReportLastData, setOptimisticTransactionThread, + triggerNotifications, }; diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts index 8e2afc960eb3..c51557eb4c53 100644 --- a/src/libs/actions/User.ts +++ b/src/libs/actions/User.ts @@ -34,7 +34,6 @@ import Log from '@libs/Log'; import Navigation from '@libs/Navigation/Navigation'; import {isOffline} from '@libs/Network/NetworkStore'; import * as SequentialQueue from '@libs/Network/SequentialQueue'; -import triggerNotifications from '@libs/Notification/triggerNotifications'; import * as NumberUtils from '@libs/NumberUtils'; import * as PersonalDetailsUtils from '@libs/PersonalDetailsUtils'; import Pusher from '@libs/Pusher'; @@ -58,6 +57,7 @@ import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {reconnectApp} from './App'; import applyOnyxUpdatesReliably from './applyOnyxUpdatesReliably'; import {openOldDotLink} from './Link'; +import {triggerNotifications} from './Report'; import {resendValidateCode as sessionResendValidateCode} from './Session'; import Timing from './Timing'; From c9cb0db0040baa16b17167aa1458f9c9845985fb Mon Sep 17 00:00:00 2001 From: Maruf Sharifi Date: Tue, 9 Dec 2025 21:51:48 +0430 Subject: [PATCH 3/6] fixed failure test case --- src/libs/actions/OnyxUpdates.ts | 2 +- src/libs/actions/Report.ts | 19 ------------------- src/libs/actions/User.ts | 20 +++++++++++++++++++- 3 files changed, 20 insertions(+), 21 deletions(-) diff --git a/src/libs/actions/OnyxUpdates.ts b/src/libs/actions/OnyxUpdates.ts index 927565ff44fb..ccf9f0f7c964 100644 --- a/src/libs/actions/OnyxUpdates.ts +++ b/src/libs/actions/OnyxUpdates.ts @@ -13,7 +13,7 @@ import type {OnyxUpdateEvent, OnyxUpdatesFromServer, Request} from '@src/types/o import type Response from '@src/types/onyx/Response'; import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {queueOnyxUpdates} from './QueuedOnyxUpdates'; -import {triggerNotifications} from './Report'; +import {triggerNotifications} from './User'; // This key needs to be separate from ONYXKEYS.ONYX_UPDATES_FROM_SERVER so that it can be updated without triggering the callback when the server IDs are updated. If that // callback were triggered it would lead to duplicate processing of server updates. diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts index 7f2dcd0b2843..7ff5e71c7adc 100644 --- a/src/libs/actions/Report.ts +++ b/src/libs/actions/Report.ts @@ -199,7 +199,6 @@ import type { Transaction, TransactionViolations, } from '@src/types/onyx'; -import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; import type {Decision} from '@src/types/onyx/OriginalMessage'; import type {CurrentUserPersonalDetails, Timezone} from '@src/types/onyx/PersonalDetails'; import type {ConnectionName} from '@src/types/onyx/Policy'; @@ -6227,23 +6226,6 @@ function setOptimisticTransactionThread(reportID?: string, parentReportID?: stri }); } -function triggerNotifications(onyxUpdates: OnyxServerUpdate[]) { - for (const update of onyxUpdates) { - if (!update.shouldNotify && !update.shouldShowPushNotification) { - continue; - } - - const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); - const reportActions = Object.values((update.value as OnyxCollection) ?? {}); - - for (const action of reportActions) { - if (action) { - showReportActionNotification(reportID, action); - } - } - } -} - export type {Video, GuidedSetupData, TaskForParameters, IntroSelected}; export { @@ -6358,5 +6340,4 @@ export { openUnreportedExpense, optimisticReportLastData, setOptimisticTransactionThread, - triggerNotifications, }; diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts index c51557eb4c53..f722faa39c43 100644 --- a/src/libs/actions/User.ts +++ b/src/libs/actions/User.ts @@ -57,7 +57,7 @@ import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {reconnectApp} from './App'; import applyOnyxUpdatesReliably from './applyOnyxUpdatesReliably'; import {openOldDotLink} from './Link'; -import {triggerNotifications} from './Report'; +import {showReportActionNotification} from './Report'; import {resendValidateCode as sessionResendValidateCode} from './Session'; import Timing from './Timing'; @@ -660,6 +660,23 @@ function isBlockedFromConcierge(blockedFromConciergeNVP: OnyxEntry) ?? {}); + + for (const action of reportActions) { + if (action) { + showReportActionNotification(reportID, action); + } + } + } +} + const isChannelMuted = (reportId: string) => new Promise((resolve) => { const connection = Onyx.connect({ @@ -1502,4 +1519,5 @@ export { resetValidateActionCodeSent, lockAccount, requestUnlockAccount, + triggerNotifications, }; From e0ea0bade6795cb1affd8c1fb9fa193fc0ac30e6 Mon Sep 17 00:00:00 2001 From: Maruf Sharifi Date: Tue, 9 Dec 2025 23:25:25 +0430 Subject: [PATCH 4/6] moved the triggerNotifications to report.ts to resolve the cycle dependency issue. --- src/libs/actions/OnyxUpdates.ts | 2 +- src/libs/actions/Report.ts | 19 +++++++++++++++++++ src/libs/actions/User.ts | 20 +------------------- 3 files changed, 21 insertions(+), 20 deletions(-) diff --git a/src/libs/actions/OnyxUpdates.ts b/src/libs/actions/OnyxUpdates.ts index ccf9f0f7c964..927565ff44fb 100644 --- a/src/libs/actions/OnyxUpdates.ts +++ b/src/libs/actions/OnyxUpdates.ts @@ -13,7 +13,7 @@ import type {OnyxUpdateEvent, OnyxUpdatesFromServer, Request} from '@src/types/o import type Response from '@src/types/onyx/Response'; import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {queueOnyxUpdates} from './QueuedOnyxUpdates'; -import {triggerNotifications} from './User'; +import {triggerNotifications} from './Report'; // This key needs to be separate from ONYXKEYS.ONYX_UPDATES_FROM_SERVER so that it can be updated without triggering the callback when the server IDs are updated. If that // callback were triggered it would lead to duplicate processing of server updates. diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts index 7ff5e71c7adc..13515a020f4b 100644 --- a/src/libs/actions/Report.ts +++ b/src/libs/actions/Report.ts @@ -199,6 +199,7 @@ import type { Transaction, TransactionViolations, } from '@src/types/onyx'; +import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; import type {Decision} from '@src/types/onyx/OriginalMessage'; import type {CurrentUserPersonalDetails, Timezone} from '@src/types/onyx/PersonalDetails'; import type {ConnectionName} from '@src/types/onyx/Policy'; @@ -6226,6 +6227,23 @@ function setOptimisticTransactionThread(reportID?: string, parentReportID?: stri }); } +function triggerNotifications(onyxUpdates: OnyxServerUpdate[]): void { + for (const update of onyxUpdates) { + if (!update.shouldNotify && !update.shouldShowPushNotification) { + continue; + } + + const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); + const reportActions = Object.values((update.value as OnyxCollection) ?? {}); + + for (const action of reportActions) { + if (action) { + showReportActionNotification(reportID, action); + } + } + } +} + export type {Video, GuidedSetupData, TaskForParameters, IntroSelected}; export { @@ -6340,4 +6358,5 @@ export { openUnreportedExpense, optimisticReportLastData, setOptimisticTransactionThread, + triggerNotifications, }; diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts index f722faa39c43..c51557eb4c53 100644 --- a/src/libs/actions/User.ts +++ b/src/libs/actions/User.ts @@ -57,7 +57,7 @@ import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {reconnectApp} from './App'; import applyOnyxUpdatesReliably from './applyOnyxUpdatesReliably'; import {openOldDotLink} from './Link'; -import {showReportActionNotification} from './Report'; +import {triggerNotifications} from './Report'; import {resendValidateCode as sessionResendValidateCode} from './Session'; import Timing from './Timing'; @@ -660,23 +660,6 @@ function isBlockedFromConcierge(blockedFromConciergeNVP: OnyxEntry) ?? {}); - - for (const action of reportActions) { - if (action) { - showReportActionNotification(reportID, action); - } - } - } -} - const isChannelMuted = (reportId: string) => new Promise((resolve) => { const connection = Onyx.connect({ @@ -1519,5 +1502,4 @@ export { resetValidateActionCodeSent, lockAccount, requestUnlockAccount, - triggerNotifications, }; From edd05c72f16ba3506f6832a0d4fb158eee568b32 Mon Sep 17 00:00:00 2001 From: Maruf Sharifi Date: Wed, 10 Dec 2025 22:39:26 +0430 Subject: [PATCH 5/6] fixed failure test --- src/libs/Notification/triggerNotifications.ts | 22 +++++++++++++++++++ src/libs/actions/OnyxUpdates.ts | 2 +- src/libs/actions/Report.ts | 19 ---------------- src/libs/actions/User.ts | 2 +- 4 files changed, 24 insertions(+), 21 deletions(-) create mode 100644 src/libs/Notification/triggerNotifications.ts diff --git a/src/libs/Notification/triggerNotifications.ts b/src/libs/Notification/triggerNotifications.ts new file mode 100644 index 000000000000..9de6b2c8be9e --- /dev/null +++ b/src/libs/Notification/triggerNotifications.ts @@ -0,0 +1,22 @@ +import {OnyxCollection} from 'react-native-onyx'; +import {showReportActionNotification} from '@libs/actions/Report'; +import ONYXKEYS from '@src/ONYXKEYS'; +import {ReportAction} from '@src/types/onyx'; +import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; + +export default function triggerNotifications(onyxUpdates: OnyxServerUpdate[]): void { + for (const update of onyxUpdates) { + if (!update.shouldNotify && !update.shouldShowPushNotification) { + continue; + } + + const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); + const reportActions = Object.values((update.value as OnyxCollection) ?? {}); + + for (const action of reportActions) { + if (action) { + showReportActionNotification(reportID, action); + } + } + } +} diff --git a/src/libs/actions/OnyxUpdates.ts b/src/libs/actions/OnyxUpdates.ts index 927565ff44fb..3feb758a8f07 100644 --- a/src/libs/actions/OnyxUpdates.ts +++ b/src/libs/actions/OnyxUpdates.ts @@ -5,6 +5,7 @@ import type {Merge} from 'type-fest'; import {READ_COMMANDS, SIDE_EFFECT_REQUEST_COMMANDS, WRITE_COMMANDS} from '@libs/API/types'; import {isMobile} from '@libs/Browser'; import Log from '@libs/Log'; +import triggerNotifications from '@libs/Notification/triggerNotifications'; import Performance from '@libs/Performance'; import PusherUtils from '@libs/PusherUtils'; import CONST from '@src/CONST'; @@ -13,7 +14,6 @@ import type {OnyxUpdateEvent, OnyxUpdatesFromServer, Request} from '@src/types/o import type Response from '@src/types/onyx/Response'; import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {queueOnyxUpdates} from './QueuedOnyxUpdates'; -import {triggerNotifications} from './Report'; // This key needs to be separate from ONYXKEYS.ONYX_UPDATES_FROM_SERVER so that it can be updated without triggering the callback when the server IDs are updated. If that // callback were triggered it would lead to duplicate processing of server updates. diff --git a/src/libs/actions/Report.ts b/src/libs/actions/Report.ts index 13515a020f4b..7ff5e71c7adc 100644 --- a/src/libs/actions/Report.ts +++ b/src/libs/actions/Report.ts @@ -199,7 +199,6 @@ import type { Transaction, TransactionViolations, } from '@src/types/onyx'; -import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; import type {Decision} from '@src/types/onyx/OriginalMessage'; import type {CurrentUserPersonalDetails, Timezone} from '@src/types/onyx/PersonalDetails'; import type {ConnectionName} from '@src/types/onyx/Policy'; @@ -6227,23 +6226,6 @@ function setOptimisticTransactionThread(reportID?: string, parentReportID?: stri }); } -function triggerNotifications(onyxUpdates: OnyxServerUpdate[]): void { - for (const update of onyxUpdates) { - if (!update.shouldNotify && !update.shouldShowPushNotification) { - continue; - } - - const reportID = update.key.replace(ONYXKEYS.COLLECTION.REPORT_ACTIONS, ''); - const reportActions = Object.values((update.value as OnyxCollection) ?? {}); - - for (const action of reportActions) { - if (action) { - showReportActionNotification(reportID, action); - } - } - } -} - export type {Video, GuidedSetupData, TaskForParameters, IntroSelected}; export { @@ -6358,5 +6340,4 @@ export { openUnreportedExpense, optimisticReportLastData, setOptimisticTransactionThread, - triggerNotifications, }; diff --git a/src/libs/actions/User.ts b/src/libs/actions/User.ts index c51557eb4c53..8e2afc960eb3 100644 --- a/src/libs/actions/User.ts +++ b/src/libs/actions/User.ts @@ -34,6 +34,7 @@ import Log from '@libs/Log'; import Navigation from '@libs/Navigation/Navigation'; import {isOffline} from '@libs/Network/NetworkStore'; import * as SequentialQueue from '@libs/Network/SequentialQueue'; +import triggerNotifications from '@libs/Notification/triggerNotifications'; import * as NumberUtils from '@libs/NumberUtils'; import * as PersonalDetailsUtils from '@libs/PersonalDetailsUtils'; import Pusher from '@libs/Pusher'; @@ -57,7 +58,6 @@ import {isEmptyObject} from '@src/types/utils/EmptyObject'; import {reconnectApp} from './App'; import applyOnyxUpdatesReliably from './applyOnyxUpdatesReliably'; import {openOldDotLink} from './Link'; -import {triggerNotifications} from './Report'; import {resendValidateCode as sessionResendValidateCode} from './Session'; import Timing from './Timing'; From dafa9ed1490d7ebb86bda3c202a924ad8f4acce6 Mon Sep 17 00:00:00 2001 From: Maruf Sharifi Date: Thu, 11 Dec 2025 09:21:39 +0430 Subject: [PATCH 6/6] fixed eslint issue --- src/libs/Notification/triggerNotifications.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/libs/Notification/triggerNotifications.ts b/src/libs/Notification/triggerNotifications.ts index 9de6b2c8be9e..30b6f50637bf 100644 --- a/src/libs/Notification/triggerNotifications.ts +++ b/src/libs/Notification/triggerNotifications.ts @@ -1,7 +1,7 @@ -import {OnyxCollection} from 'react-native-onyx'; +import type {OnyxCollection} from 'react-native-onyx'; import {showReportActionNotification} from '@libs/actions/Report'; import ONYXKEYS from '@src/ONYXKEYS'; -import {ReportAction} from '@src/types/onyx'; +import type {ReportAction} from '@src/types/onyx'; import type {OnyxServerUpdate} from '@src/types/onyx/OnyxUpdatesFromServer'; export default function triggerNotifications(onyxUpdates: OnyxServerUpdate[]): void {