diff --git a/src/components/Search/SearchPageHeader/SearchFiltersBarCreateButton.tsx b/src/components/Search/SearchPageHeader/SearchFiltersBarCreateButton.tsx index 97d2690cff39..e908cdd70fae 100644 --- a/src/components/Search/SearchPageHeader/SearchFiltersBarCreateButton.tsx +++ b/src/components/Search/SearchPageHeader/SearchFiltersBarCreateButton.tsx @@ -1,24 +1,36 @@ import {emailSelector} from '@selectors/Session'; import React, {useCallback, useMemo, useRef, useState} from 'react'; import {View} from 'react-native'; -import type {OnyxCollection} from 'react-native-onyx'; +import type {OnyxCollection, OnyxEntry} from 'react-native-onyx'; import Button from '@components/Button'; +import {ModalActions} from '@components/Modal/Global/ModalContext'; import type {PopoverMenuItem} from '@components/PopoverMenu'; import PopoverMenu from '@components/PopoverMenu'; +import useConfirmModal from '@hooks/useConfirmModal'; +import useCreateEmptyReportConfirmation from '@hooks/useCreateEmptyReportConfirmation'; +import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails'; +import useHasEmptyReportsForPolicy from '@hooks/useHasEmptyReportsForPolicy'; import {useMemoizedLazyExpensifyIcons} from '@hooks/useLazyAsset'; import useLocalize from '@hooks/useLocalize'; import useOnyx from '@hooks/useOnyx'; +import usePermissions from '@hooks/usePermissions'; +import usePolicyForMovingExpenses from '@hooks/usePolicyForMovingExpenses'; import usePopoverPosition from '@hooks/usePopoverPosition'; import useThemeStyles from '@hooks/useThemeStyles'; import {startDistanceRequest, startMoneyRequest} from '@libs/actions/IOU'; +import {openOldDotLink} from '@libs/actions/Link'; +import {createNewReport} from '@libs/actions/Report'; import getIconForAction from '@libs/getIconForAction'; import interceptAnonymousUser from '@libs/interceptAnonymousUser'; +import isSearchTopmostFullScreenRoute from '@libs/Navigation/helpers/isSearchTopmostFullScreenRoute'; import Navigation from '@libs/Navigation/Navigation'; -import {generateReportID} from '@libs/ReportUtils'; +import {areAllGroupPoliciesExpenseChatDisabled, getDefaultChatEnabledPolicy} from '@libs/PolicyUtils'; +import {generateReportID, hasViolations as hasViolationsReportUtils} from '@libs/ReportUtils'; +import {shouldRestrictUserBillableActions} from '@libs/SubscriptionUtils'; import CONST from '@src/CONST'; import ONYXKEYS from '@src/ONYXKEYS'; import ROUTES from '@src/ROUTES'; -import {groupPaidPoliciesWithExpenseChatEnabledSelector, shouldRedirectToExpensifyClassicSelector} from '@src/selectors/Policy'; +import {groupPaidPoliciesWithExpenseChatEnabledSelector} from '@src/selectors/Policy'; import type * as OnyxTypes from '@src/types/onyx'; function SearchFiltersBarCreateButton() { @@ -31,11 +43,80 @@ function SearchFiltersBarCreateButton() { const [createMenuPosition, setCreateMenuPosition] = useState<{horizontal: number; vertical: number}>({horizontal: 0, vertical: 0}); const {calculatePopoverPosition} = usePopoverPosition(); + const [session] = useOnyx(ONYXKEYS.SESSION); const [email] = useOnyx(ONYXKEYS.SESSION, {selector: emailSelector}); + const [allBetas] = useOnyx(ONYXKEYS.BETAS); + const [allPolicies] = useOnyx(ONYXKEYS.COLLECTION.POLICY); + const [transactionViolations] = useOnyx(ONYXKEYS.COLLECTION.TRANSACTION_VIOLATIONS); const groupPaidPoliciesWithChatEnabledSelector = useCallback((policies: OnyxCollection) => groupPaidPoliciesWithExpenseChatEnabledSelector(policies, email), [email]); const [groupPoliciesWithChatEnabled = CONST.EMPTY_ARRAY] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {selector: groupPaidPoliciesWithChatEnabledSelector}, [email]); - const [shouldRedirectToExpensifyClassic = false] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {selector: shouldRedirectToExpensifyClassicSelector}); - const shouldShowCreateReportOption = shouldRedirectToExpensifyClassic || groupPoliciesWithChatEnabled.length > 0; + const currentUserPersonalDetails = useCurrentUserPersonalDetails(); + const {isBetaEnabled} = usePermissions(); + const isASAPSubmitBetaEnabled = isBetaEnabled(CONST.BETAS.ASAP_SUBMIT); + const hasViolations = hasViolationsReportUtils(undefined, transactionViolations, session?.accountID ?? CONST.DEFAULT_NUMBER_ID, session?.email ?? ''); + const [activePolicyID] = useOnyx(ONYXKEYS.NVP_ACTIVE_POLICY_ID); + const [activePolicy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${activePolicyID}`); + const {policyForMovingExpensesID, shouldSelectPolicy} = usePolicyForMovingExpenses(); + const shouldNavigateToUpgradePath = !policyForMovingExpensesID && !shouldSelectPolicy; + const {showConfirmModal} = useConfirmModal(); + + const shouldRedirectToExpensifyClassic = useMemo(() => { + return areAllGroupPoliciesExpenseChatDisabled((allPolicies as OnyxCollection) ?? {}); + }, [allPolicies]); + + const defaultChatEnabledPolicy = useMemo( + () => getDefaultChatEnabledPolicy(groupPoliciesWithChatEnabled as Array>, activePolicy), + [activePolicy, groupPoliciesWithChatEnabled], + ); + const defaultChatEnabledPolicyID = defaultChatEnabledPolicy?.id; + + const hasEmptyReport = useHasEmptyReportsForPolicy(defaultChatEnabledPolicyID); + const [hasDismissedEmptyReportsConfirmation] = useOnyx(ONYXKEYS.NVP_EMPTY_REPORTS_CONFIRMATION_DISMISSED); + const shouldShowEmptyReportConfirmationForDefaultChatEnabledPolicy = hasEmptyReport && hasDismissedEmptyReportsConfirmation !== true; + + const showRedirectToExpensifyClassicModal = useCallback(async () => { + const {action} = await showConfirmModal({ + title: translate('sidebarScreen.redirectToExpensifyClassicModal.title'), + prompt: translate('sidebarScreen.redirectToExpensifyClassicModal.description'), + confirmText: translate('exitSurvey.goToExpensifyClassic'), + cancelText: translate('common.cancel'), + }); + if (action === ModalActions.CONFIRM) { + openOldDotLink(CONST.OLDDOT_URLS.INBOX); + } + }, [showConfirmModal, translate]); + + const handleCreateWorkspaceReport = useCallback( + (shouldDismissEmptyReportsConfirmation?: boolean) => { + if (!defaultChatEnabledPolicy?.id) { + return; + } + + const {reportID: createdReportID} = createNewReport( + currentUserPersonalDetails, + hasViolations, + isASAPSubmitBetaEnabled, + defaultChatEnabledPolicy, + allBetas, + false, + shouldDismissEmptyReportsConfirmation, + ); + Navigation.setNavigationActionToMicrotaskQueue(() => { + Navigation.navigate( + isSearchTopmostFullScreenRoute() + ? ROUTES.SEARCH_MONEY_REQUEST_REPORT.getRoute({reportID: createdReportID, backTo: Navigation.getActiveRoute()}) + : ROUTES.REPORT_WITH_ID.getRoute(createdReportID, undefined, undefined, Navigation.getActiveRoute()), + ); + }); + }, + [currentUserPersonalDetails, hasViolations, defaultChatEnabledPolicy, isASAPSubmitBetaEnabled, allBetas], + ); + + const {openCreateReportConfirmation, CreateReportConfirmationModal} = useCreateEmptyReportConfirmation({ + policyID: defaultChatEnabledPolicyID, + policyName: defaultChatEnabledPolicy?.name ?? '', + onConfirm: handleCreateWorkspaceReport, + }); const hideCreateMenu = useCallback(() => setIsCreateMenuActive(false), []); const showCreateMenu = useCallback(() => { @@ -69,24 +150,72 @@ function SearchFiltersBarCreateButton() { startDistanceRequest(CONST.IOU.TYPE.CREATE, generateReportID()); }), }, - ...(shouldShowCreateReportOption - ? [ - { - icon: expensifyIcons.Document, - text: translate('report.newReport.createReport'), - onSelected: () => - interceptAnonymousUser(() => { - Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute()); - }), - }, - ] - : []), + { + icon: expensifyIcons.Document, + text: translate('report.newReport.createReport'), + onSelected: () => + interceptAnonymousUser(() => { + if (shouldRedirectToExpensifyClassic) { + showRedirectToExpensifyClassicModal(); + return; + } + + // No valid policy at all → upgrade + create workspace flow + if (shouldNavigateToUpgradePath) { + const freshReportID = generateReportID(); + const freshTransactionID = generateReportID(); + Navigation.navigate( + ROUTES.MONEY_REQUEST_UPGRADE.getRoute({ + action: CONST.IOU.ACTION.CREATE, + iouType: CONST.IOU.TYPE.CREATE, + transactionID: freshTransactionID, + reportID: freshReportID, + upgradePath: CONST.UPGRADE_PATHS.REPORTS, + }), + ); + return; + } + + const workspaceIDForReportCreation = defaultChatEnabledPolicyID; + + // No default or restricted with multiple workspaces → workspace selector + if (!workspaceIDForReportCreation || (shouldRestrictUserBillableActions(workspaceIDForReportCreation) && groupPoliciesWithChatEnabled.length > 1)) { + Navigation.navigate(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute()); + return; + } + + // Default workspace is not restricted → create report directly + if (!shouldRestrictUserBillableActions(workspaceIDForReportCreation)) { + // Check if empty report confirmation should be shown + if (shouldShowEmptyReportConfirmationForDefaultChatEnabledPolicy) { + openCreateReportConfirmation(); + } else { + handleCreateWorkspaceReport(false); + } + return; + } + + Navigation.navigate(ROUTES.RESTRICTED_ACTION.getRoute(workspaceIDForReportCreation)); + }), + }, + ], + [ + translate, + expensifyIcons, + shouldRedirectToExpensifyClassic, + showRedirectToExpensifyClassicModal, + shouldNavigateToUpgradePath, + groupPoliciesWithChatEnabled.length, + defaultChatEnabledPolicyID, + shouldShowEmptyReportConfirmationForDefaultChatEnabledPolicy, + openCreateReportConfirmation, + handleCreateWorkspaceReport, ], - [translate, expensifyIcons, shouldShowCreateReportOption], ); return ( + {CreateReportConfirmationModal} ({ + navigate: jest.fn(), + setNavigationActionToMicrotaskQueue: jest.fn((cb: () => void) => cb()), + getActiveRoute: jest.fn(() => ''), + isTopmostRouteModalScreen: jest.fn(() => false), +})); + +jest.mock('@libs/actions/Report', () => ({ + createNewReport: jest.fn(() => ({reportID: 'mock-report-id'})), +})); + +jest.mock('@libs/interceptAnonymousUser', () => jest.fn((callback: () => void) => callback())); + +jest.mock('@libs/actions/IOU', () => ({ + startMoneyRequest: jest.fn(), + startDistanceRequest: jest.fn(), +})); + +jest.mock('@libs/actions/Link', () => ({ + openOldDotLink: jest.fn(), +})); + +jest.mock('@hooks/usePolicyForMovingExpenses'); + +jest.mock('@hooks/usePopoverPosition', () => () => ({ + calculatePopoverPosition: jest.fn(() => Promise.resolve({horizontal: 0, vertical: 0})), +})); + +jest.mock('@hooks/useHasEmptyReportsForPolicy', () => () => false); + +jest.mock('@hooks/useCreateEmptyReportConfirmation', () => () => ({ + openCreateReportConfirmation: jest.fn(), + CreateReportConfirmationModal: null, +})); + +jest.mock('@libs/Navigation/helpers/isSearchTopmostFullScreenRoute', () => () => true); + +const mockUsePolicyForMovingExpenses = jest.mocked(usePolicyForMovingExpenses); +const mockNavigate = jest.mocked(Navigation.navigate); +const mockCreateNewReport = jest.mocked(createNewReport); +const mockInterceptAnonymousUser = jest.mocked(interceptAnonymousUser); + +const CURRENT_USER_ACCOUNT_ID = 1; +const CURRENT_USER_EMAIL = 'user@test.com'; + +const MOCK_POLICY_ID = 'policy-123'; +const MOCK_POLICY = { + id: MOCK_POLICY_ID, + name: 'Test Workspace', + type: CONST.POLICY.TYPE.TEAM, + role: CONST.POLICY.ROLE.ADMIN, + isPolicyExpenseChatEnabled: true, + pendingAction: null, + avatarURL: '', + areInvoicesEnabled: false, + owner: CURRENT_USER_EMAIL, + outputCurrency: CONST.CURRENCY.USD, +}; + +function renderComponent() { + return render( + + + , + ); +} + +// Helper function to create mock events for PopoverMenuItem fireEvent.press +function createMockPressEvent(target: unknown) { + return { + nativeEvent: {}, + type: 'press', + target, + currentTarget: target, + }; +} + +describe('SearchFiltersBarCreateButton', () => { + beforeAll(() => { + Onyx.init({ + keys: ONYXKEYS, + }); + }); + + beforeEach(async () => { + mockUsePolicyForMovingExpenses.mockReturnValue({ + policyForMovingExpensesID: undefined, + policyForMovingExpenses: undefined, + shouldSelectPolicy: false, + }); + + await act(async () => { + await Onyx.merge(ONYXKEYS.SESSION, { + accountID: CURRENT_USER_ACCOUNT_ID, + email: CURRENT_USER_EMAIL, + }); + }); + await waitForBatchedUpdatesWithAct(); + }); + + afterEach(async () => { + jest.clearAllMocks(); + await act(async () => { + await Onyx.clear(); + }); + await waitForBatchedUpdatesWithAct(); + }); + + it('should always show the "Create report" menu item', async () => { + // When component is rendered + renderComponent(); + await waitForBatchedUpdatesWithAct(); + + // When Create button is pressed to open menu + const createButton = screen.getByText(translateLocal('common.create')); + fireEvent.press(createButton); + await waitForBatchedUpdatesWithAct(); + + // Then "Create report" option is visible + expect(screen.getByText(translateLocal('report.newReport.createReport'))).toBeOnTheScreen(); + }); + + it('should navigate to upgrade path when no valid policy exists', async () => { + // Given no policies exist (shouldNavigateToUpgradePath = true) + + // When component is rendered + renderComponent(); + await waitForBatchedUpdatesWithAct(); + + // When Create button is pressed to open menu + const createButton = screen.getByText(translateLocal('common.create')); + fireEvent.press(createButton); + await waitForBatchedUpdatesWithAct(); + + // When "Create report" is pressed + const createReportItem = screen.getByText(translateLocal('report.newReport.createReport')); + fireEvent.press(createReportItem, createMockPressEvent(createReportItem)); + await waitForBatchedUpdatesWithAct(); + + // Then it navigates to the upgrade path + expect(mockNavigate).toHaveBeenCalledWith(expect.stringContaining('upgrade')); + }); + + it('should navigate to workspace selector when no default policy and multiple workspaces exist', async () => { + // Given user has multiple policies (shouldSelectPolicy = true, but no single default) + mockUsePolicyForMovingExpenses.mockReturnValue({ + policyForMovingExpensesID: 'some-policy', + policyForMovingExpenses: MOCK_POLICY, + shouldSelectPolicy: false, + }); + + // Set up multiple policies with chat enabled + await act(async () => { + await Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${MOCK_POLICY_ID}`, MOCK_POLICY); + await Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}policy-456`, { + ...MOCK_POLICY, + id: 'policy-456', + name: 'Second Workspace', + }); + }); + await waitForBatchedUpdatesWithAct(); + + // When component is rendered + renderComponent(); + await waitForBatchedUpdatesWithAct(); + + // When Create button is pressed to open menu + const createButton = screen.getByText(translateLocal('common.create')); + fireEvent.press(createButton); + await waitForBatchedUpdatesWithAct(); + + // When "Create report" is pressed + const createReportItem = screen.getByText(translateLocal('report.newReport.createReport')); + fireEvent.press(createReportItem, createMockPressEvent(createReportItem)); + await waitForBatchedUpdatesWithAct(); + + // Then it navigates to workspace selection + expect(mockNavigate).toHaveBeenCalledWith(ROUTES.NEW_REPORT_WORKSPACE_SELECTION.getRoute()); + }); + + it('should create report directly when a single default workspace exists', async () => { + // Given user has a single valid policy + mockUsePolicyForMovingExpenses.mockReturnValue({ + policyForMovingExpensesID: MOCK_POLICY_ID, + policyForMovingExpenses: MOCK_POLICY, + shouldSelectPolicy: false, + }); + + await act(async () => { + await Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY}${MOCK_POLICY_ID}`, MOCK_POLICY); + await Onyx.merge(ONYXKEYS.NVP_ACTIVE_POLICY_ID, MOCK_POLICY_ID); + }); + await waitForBatchedUpdatesWithAct(); + + // When component is rendered + renderComponent(); + await waitForBatchedUpdatesWithAct(); + + // When Create button is pressed to open menu + const createButton = screen.getByText(translateLocal('common.create')); + fireEvent.press(createButton); + await waitForBatchedUpdatesWithAct(); + + // When "Create report" is pressed + const createReportItem = screen.getByText(translateLocal('report.newReport.createReport')); + fireEvent.press(createReportItem, createMockPressEvent(createReportItem)); + await waitForBatchedUpdatesWithAct(); + + // Then createNewReport is called to create the report directly + expect(mockCreateNewReport).toHaveBeenCalled(); + }); + + it('should call interceptAnonymousUser when "Create report" is pressed', async () => { + // Given component is rendered + renderComponent(); + await waitForBatchedUpdatesWithAct(); + + // When Create button is pressed to open menu + const createButton = screen.getByText(translateLocal('common.create')); + fireEvent.press(createButton); + await waitForBatchedUpdatesWithAct(); + + // When "Create report" is pressed + const createReportItem = screen.getByText(translateLocal('report.newReport.createReport')); + fireEvent.press(createReportItem, createMockPressEvent(createReportItem)); + await waitForBatchedUpdatesWithAct(); + + // Then interceptAnonymousUser is called + expect(mockInterceptAnonymousUser).toHaveBeenCalled(); + }); + + it('should also show "Create expense" and "Track distance" menu items', async () => { + // When component is rendered + renderComponent(); + await waitForBatchedUpdatesWithAct(); + + // When Create button is pressed to open menu + const createButton = screen.getByText(translateLocal('common.create')); + fireEvent.press(createButton); + await waitForBatchedUpdatesWithAct(); + + // Then all three menu items are visible + expect(screen.getByText(translateLocal('iou.createExpense'))).toBeOnTheScreen(); + expect(screen.getByText(translateLocal('iou.trackDistance'))).toBeOnTheScreen(); + expect(screen.getByText(translateLocal('report.newReport.createReport'))).toBeOnTheScreen(); + }); +});