diff --git a/.claude/skills/coding-standards/rules/clean-react-0-compiler.md b/.claude/skills/coding-standards/rules/clean-react-0-compiler.md index b679c7d3fd05..303719f6e2cf 100644 --- a/.claude/skills/coding-standards/rules/clean-react-0-compiler.md +++ b/.claude/skills/coding-standards/rules/clean-react-0-compiler.md @@ -7,7 +7,7 @@ title: React Compiler compliance ### Reasoning -React Compiler is enabled in this codebase (`babel-plugin-react-compiler` runs first in both webpack and metro configs). It automatically memoizes components and hooks at the AST level — analyzing data flow, tracking dependencies, and inserting fine-grained caching that is more precise than any hand-written `useMemo`, `useCallback`, or `React.memo`. +React Compiler is enabled in this codebase (`babel-plugin-react-compiler` runs first in both Rspack and metro configs). It automatically memoizes components and hooks at the AST level — analyzing data flow, tracking dependencies, and inserting fine-grained caching that is more precise than any hand-written `useMemo`, `useCallback`, or `React.memo`. Manual memoization is therefore: diff --git a/.claude/skills/playwright-app-testing/SKILL.md b/.claude/skills/playwright-app-testing/SKILL.md index b69ed942be3e..5ef70429a0fb 100644 --- a/.claude/skills/playwright-app-testing/SKILL.md +++ b/.claude/skills/playwright-app-testing/SKILL.md @@ -19,7 +19,7 @@ Use Playwright testing when: Before using Playwright tools, verify the dev server is running: ```bash -ps aux | grep "webpack" | grep -v grep +ps aux | grep "rspack" | grep -v grep ``` **If server not running**: Inform user to start with `cd App && npm run web` @@ -29,7 +29,7 @@ ps aux | grep "webpack" | grep -v grep ## Playwright Testing Workflow -1. **Verify server**: Check webpack process is running +1. **Verify server**: Check Rspack process is running 2. **Navigate**: Open `https://dev.new.expensify.com:8082/` in the browser 3. **Interact**: Use Playwright MCP tools to inspect, click, type, and navigate diff --git a/.github/actions/javascript/checkSVGCompression/index.js b/.github/actions/javascript/checkSVGCompression/index.js index 54a40e496926..45c32d40072a 100644 --- a/.github/actions/javascript/checkSVGCompression/index.js +++ b/.github/actions/javascript/checkSVGCompression/index.js @@ -13819,8 +13819,11 @@ function onceStrict (fn) { /***/ 2043: /***/ ((__unused_webpack_module, exports, __nccwpck_require__) => { -;(function (sax) { // wrapper for non-node envs - sax.parser = function (strict, opt) { return new SAXParser(strict, opt) } +;(function (sax) { + // wrapper for non-node envs + sax.parser = function (strict, opt) { + return new SAXParser(strict, opt) + } sax.SAXParser = SAXParser sax.SAXStream = SAXStream sax.createStream = createStream @@ -13837,9 +13840,18 @@ function onceStrict (fn) { sax.MAX_BUFFER_LENGTH = 64 * 1024 var buffers = [ - 'comment', 'sgmlDecl', 'textNode', 'tagName', 'doctype', - 'procInstName', 'procInstBody', 'entity', 'attribName', - 'attribValue', 'cdata', 'script' + 'comment', + 'sgmlDecl', + 'textNode', + 'tagName', + 'doctype', + 'procInstName', + 'procInstBody', + 'entity', + 'attribName', + 'attribValue', + 'cdata', + 'script', ] sax.EVENTS = [ @@ -13860,10 +13872,10 @@ function onceStrict (fn) { 'ready', 'script', 'opennamespace', - 'closenamespace' + 'closenamespace', ] - function SAXParser (strict, opt) { + function SAXParser(strict, opt) { if (!(this instanceof SAXParser)) { return new SAXParser(strict, opt) } @@ -13872,9 +13884,13 @@ function onceStrict (fn) { clearBuffers(parser) parser.q = parser.c = '' parser.bufferCheckPosition = sax.MAX_BUFFER_LENGTH + parser.encoding = null; parser.opt = opt || {} parser.opt.lowercase = parser.opt.lowercase || parser.opt.lowercasetags parser.looseCase = parser.opt.lowercase ? 'toLowerCase' : 'toUpperCase' + parser.opt.maxEntityCount = parser.opt.maxEntityCount || 512 + parser.opt.maxEntityDepth = parser.opt.maxEntityDepth || 4 + parser.entityCount = parser.entityDepth = 0 parser.tags = [] parser.closed = parser.closedRoot = parser.sawRoot = false parser.tag = parser.error = null @@ -13882,7 +13898,10 @@ function onceStrict (fn) { parser.noscript = !!(strict || parser.opt.noscript) parser.state = S.BEGIN parser.strictEntities = parser.opt.strictEntities - parser.ENTITIES = parser.strictEntities ? Object.create(sax.XML_ENTITIES) : Object.create(sax.ENTITIES) + parser.ENTITIES = + parser.strictEntities ? + Object.create(sax.XML_ENTITIES) + : Object.create(sax.ENTITIES) parser.attribList = [] // namespaces form a prototype chain. @@ -13895,7 +13914,7 @@ function onceStrict (fn) { // disallow unquoted attribute values if not otherwise configured // and strict mode is true if (parser.opt.unquotedAttributeValues === undefined) { - parser.opt.unquotedAttributeValues = !strict; + parser.opt.unquotedAttributeValues = !strict } // mostly just for error reporting @@ -13908,7 +13927,7 @@ function onceStrict (fn) { if (!Object.create) { Object.create = function (o) { - function F () {} + function F() {} F.prototype = o var newf = new F() return newf @@ -13923,7 +13942,7 @@ function onceStrict (fn) { } } - function checkBufferLength (parser) { + function checkBufferLength(parser) { var maxAllowed = Math.max(sax.MAX_BUFFER_LENGTH, 10) var maxActual = 0 for (var i = 0, l = buffers.length; i < l; i++) { @@ -13959,13 +13978,13 @@ function onceStrict (fn) { parser.bufferCheckPosition = m + parser.position } - function clearBuffers (parser) { + function clearBuffers(parser) { for (var i = 0, l = buffers.length; i < l; i++) { parser[buffers[i]] = '' } } - function flushBuffers (parser) { + function flushBuffers(parser) { closeText(parser) if (parser.cdata !== '') { emitNode(parser, 'oncdata', parser.cdata) @@ -13978,11 +13997,20 @@ function onceStrict (fn) { } SAXParser.prototype = { - end: function () { end(this) }, + end: function () { + end(this) + }, write: write, - resume: function () { this.error = null; return this }, - close: function () { return this.write(null) }, - flush: function () { flushBuffers(this) } + resume: function () { + this.error = null + return this + }, + close: function () { + return this.write(null) + }, + flush: function () { + flushBuffers(this) + }, } var Stream @@ -13997,11 +14025,44 @@ function onceStrict (fn) { return ev !== 'error' && ev !== 'end' }) - function createStream (strict, opt) { + function createStream(strict, opt) { return new SAXStream(strict, opt) } - function SAXStream (strict, opt) { + function determineBufferEncoding(data, isEnd) { + // BOM-based detection is the most reliable signal when present. + if (data.length >= 2) { + if (data[0] === 0xff && data[1] === 0xfe) { + return 'utf-16le' + } + + if (data[0] === 0xfe && data[1] === 0xff) { + return 'utf-16be' + } + } + + if (data.length >= 3 && data[0] === 0xef && data[1] === 0xbb && data[2] === 0xbf) { + return 'utf8' + } + + if (data.length >= 4) { + // XML documents without a BOM still start with "' || isWhitespace(c) } - function isMatch (regex, c) { + function isMatch(regex, c) { return regex.test(c) } - function notMatch (regex, c) { + function notMatch(regex, c) { return !isMatch(regex, c) } @@ -14168,271 +14282,271 @@ function onceStrict (fn) { CLOSE_TAG: S++, // SCRIPT: S++, // <% } %> - <% if (htmlWebpackPlugin.options.isWeb) { %> + <% if (isWeb) { %> @@ -151,7 +151,7 @@ - <% if (htmlWebpackPlugin.options.useThirdPartyScripts) { %> + <% if (useThirdPartyScripts) { %>