diff --git a/src/components/ReportActionAvatars/useReportActionAvatars.ts b/src/components/ReportActionAvatars/useReportActionAvatars.ts index 5c90ece0a68f..debfdd0c0563 100644 --- a/src/components/ReportActionAvatars/useReportActionAvatars.ts +++ b/src/components/ReportActionAvatars/useReportActionAvatars.ts @@ -234,7 +234,17 @@ function useReportActionAvatars({ const useNearestReportAvatars = (!accountID || !action) && accountIDs.length === 0; const getIconsWithDefaults = (onyxReport: OnyxInputOrEntry) => - getIcons(onyxReport, formatPhoneNumber, personalDetails, avatar ?? fallbackIcon ?? defaultAvatars.FallbackAvatar, defaultDisplayName, accountID, policy, invoiceReceiverPolicy); + getIcons( + onyxReport, + formatPhoneNumber, + translate, + personalDetails, + avatar ?? fallbackIcon ?? defaultAvatars.FallbackAvatar, + defaultDisplayName, + accountID, + policy, + invoiceReceiverPolicy, + ); const reportIcons = getIconsWithDefaults(chatReport?.reportID ? chatReport : iouReport); diff --git a/src/libs/OptionsListUtils/index.ts b/src/libs/OptionsListUtils/index.ts index 95204ae05c6d..9af483036408 100644 --- a/src/libs/OptionsListUtils/index.ts +++ b/src/libs/OptionsListUtils/index.ts @@ -1144,6 +1144,7 @@ function createOption({ sortedActions, }: CreateOptionParams): SearchOptionData { const {showChatPreviewLine = false, forcePolicyNamePreview = false, showPersonalDetails = false, selected, isSelected, isDisabled} = config ?? {}; + const translateFn = translate ?? translateLocal; // Initialize only the properties that are actually used in SearchOption context const result: SearchOptionData = { @@ -1210,7 +1211,6 @@ function createOption({ // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing -- below is a boolean expression hasMultipleParticipants = personalDetailList.length > 1 || result.isChatRoom || result.isPolicyExpenseChat || reportUtilsIsGroupChat(report); - const translateFn = translate ?? translateLocal; subtitle = getChatRoomSubtitle(report, policy, conciergeReportID, translateFn, true, result.private_isArchived); // If displaying chat preview line is needed, let's overwrite the default alternate text @@ -1267,6 +1267,7 @@ function createOption({ result.icons = getIcons( report, formatPhoneNumberPhoneUtils, + translateFn, personalDetails, personalDetail?.avatar, personalDetail?.login, diff --git a/src/libs/ReportUtils.ts b/src/libs/ReportUtils.ts index d78113c60d5a..9cf8c81c00a2 100644 --- a/src/libs/ReportUtils.ts +++ b/src/libs/ReportUtils.ts @@ -146,7 +146,7 @@ import Parser from './Parser'; import {getParsedMessageWithShortMentions} from './ParsingUtils'; import {getBankAccountLastFourDigits} from './PaymentUtils'; import Permissions from './Permissions'; -import {getAccountIDsByLogins, getDisplayNameOrDefault, getLoginByAccountID, getPersonalDetailByEmail} from './PersonalDetailsUtils'; +import {getAccountIDsByLogins, getDisplayNameOrDefault, getLoginByAccountID, getPersonalDetailByEmail, temporaryGetDisplayNameOrDefault} from './PersonalDetailsUtils'; import { canSendInvoiceFromWorkspace, getActivePolicies, @@ -3689,7 +3689,7 @@ function buildParticipantsFromAccountIDs(accountIDs: number[]): Participants { }, finalParticipants); } -function getParticipantIcon(accountID: number | undefined, personalDetails: OnyxInputOrEntry, shouldUseShortForm = false): Icon { +function getParticipantIcon(accountID: number | undefined, personalDetails: OnyxInputOrEntry, translate: LocalizedTranslate, shouldUseShortForm = false): Icon { if (!accountID) { return { id: CONST.DEFAULT_NUMBER_ID, @@ -3699,7 +3699,7 @@ function getParticipantIcon(accountID: number | undefined, personalDetails: Onyx }; } const details = personalDetails?.[accountID]; - const displayName = getDisplayNameOrDefault(details, '', shouldUseShortForm); + const displayName = temporaryGetDisplayNameOrDefault({passedPersonalDetails: details, defaultValue: '', shouldFallbackToHidden: shouldUseShortForm, translate}); return { id: accountID, @@ -3777,6 +3777,7 @@ function getIconsForChatThread( personalDetails: OnyxInputOrEntry, policy: OnyxInputOrEntry, formatPhoneNumber: LocaleContextProps['formatPhoneNumber'], + translate: LocalizedTranslate, ): Icon[] { if (!report?.parentReportID || !report?.parentReportActionID) { return []; @@ -3784,7 +3785,7 @@ function getIconsForChatThread( const parentReportAction = allReportActions?.[`${ONYXKEYS.COLLECTION.REPORT_ACTIONS}${report.parentReportID}`]?.[report.parentReportActionID]; const actorAccountID = getReportActionActorAccountID(parentReportAction, report as OnyxEntry, report as OnyxEntry); const actorDetails = actorAccountID ? personalDetails?.[actorAccountID] : undefined; - const actorDisplayName = getDisplayNameOrDefault(actorDetails, '', false); + const actorDisplayName = temporaryGetDisplayNameOrDefault({passedPersonalDetails: actorDetails, defaultValue: '', shouldFallbackToHidden: false, translate}); const actorIcon = { id: actorAccountID, source: actorDetails?.avatar ?? (actorAccountID ? getDefaultAvatarURL({accountID: actorAccountID}) : FallbackAvatar), @@ -3803,8 +3804,13 @@ function getIconsForChatThread( /** * Helper function to get the icons for a task report. Only to be used in getIcons(). */ -function getIconsForTaskReport(report: OnyxInputOrEntry, personalDetails: OnyxInputOrEntry, policy: OnyxInputOrEntry): Icon[] { - const ownerIcon = getParticipantIcon(report?.ownerAccountID, personalDetails, true); +function getIconsForTaskReport( + report: OnyxInputOrEntry, + personalDetails: OnyxInputOrEntry, + policy: OnyxInputOrEntry, + translate: LocalizedTranslate, +): Icon[] { + const ownerIcon = getParticipantIcon(report?.ownerAccountID, personalDetails, translate, true); if (report && isWorkspaceTaskReport(report)) { const workspaceIcon = getWorkspaceIcon(report, policy); return [ownerIcon, workspaceIcon]; @@ -3849,24 +3855,34 @@ function getIconsForPolicyRoom( /** * Helper function to get the icons for a policy expense chat. Only to be used in getIcons(). */ -function getIconsForPolicyExpenseChat(report: OnyxInputOrEntry, personalDetails: OnyxInputOrEntry, policy: OnyxInputOrEntry): Icon[] { +function getIconsForPolicyExpenseChat( + report: OnyxInputOrEntry, + personalDetails: OnyxInputOrEntry, + policy: OnyxInputOrEntry, + translate: LocalizedTranslate, +): Icon[] { if (!report) { return []; } const workspaceIcon = getWorkspaceIcon(report, policy); - const memberIcon = getParticipantIcon(report?.ownerAccountID, personalDetails, true); + const memberIcon = getParticipantIcon(report?.ownerAccountID, personalDetails, translate, true); return [workspaceIcon, memberIcon]; } /** * Helper function to get the icons for an expense report. Only to be used in getIcons(). */ -function getIconsForExpenseReport(report: OnyxInputOrEntry, personalDetails: OnyxInputOrEntry, policy: OnyxInputOrEntry): Icon[] { +function getIconsForExpenseReport( + report: OnyxInputOrEntry, + personalDetails: OnyxInputOrEntry, + policy: OnyxInputOrEntry, + translate: LocalizedTranslate, +): Icon[] { if (!report) { return []; } const workspaceIcon = getWorkspaceIcon(report, policy); - const memberIcon = getParticipantIcon(report?.ownerAccountID, personalDetails, true); + const memberIcon = getParticipantIcon(report?.ownerAccountID, personalDetails, translate, true); return [memberIcon, workspaceIcon]; } @@ -3977,6 +3993,7 @@ function getIconsForUserCreatedPolicyRoom(report: OnyxInputOrEntry, poli function getIcons( report: OnyxInputOrEntry, formatPhoneNumber: LocaleContextProps['formatPhoneNumber'], + translate: LocalizedTranslate, personalDetails: OnyxInputOrEntry = allPersonalDetails, defaultIcon: AvatarSource | null = null, defaultName = '', @@ -3999,7 +4016,7 @@ function getIcons( return getIconsForExpenseRequest(report, personalDetails, policy); } if (isExpenseReport(report)) { - return getIconsForExpenseReport(report, personalDetails, policy); + return getIconsForExpenseReport(report, personalDetails, policy, translate); } if (isIOUReport(report)) { return getIconsForIOUReport(report, personalDetails); @@ -4008,16 +4025,16 @@ function getIcons( return getIconsForInvoiceReport(report, personalDetails, policy, invoiceReceiverPolicy); } if (isChatThread(report)) { - return getIconsForChatThread(report, personalDetails, policy, formatPhoneNumber); + return getIconsForChatThread(report, personalDetails, policy, formatPhoneNumber, translate); } if (isTaskReport(report)) { - return getIconsForTaskReport(report, personalDetails, policy); + return getIconsForTaskReport(report, personalDetails, policy, translate); } if (isDomainRoom(report)) { return getIconsForDomainRoom(report); } if (isPolicyExpenseChat(report)) { - return getIconsForPolicyExpenseChat(report, personalDetails, policy); + return getIconsForPolicyExpenseChat(report, personalDetails, policy, translate); } if (isUserCreatedPolicyRoom(report)) { return getIconsForUserCreatedPolicyRoom(report, policy); diff --git a/src/libs/SearchUIUtils.ts b/src/libs/SearchUIUtils.ts index c2a22cc87b9a..d00c4e63e6ec 100644 --- a/src/libs/SearchUIUtils.ts +++ b/src/libs/SearchUIUtils.ts @@ -2298,11 +2298,12 @@ function getReportNameValuePairsFromKey(data: OnyxTypes.SearchResults['data'], r function getSearchReportAvatarProps( report: OnyxTypes.Report, formatPhoneNumber: LocaleContextProps['formatPhoneNumber'], + translate: LocalizedTranslate, personalDetailsList: OnyxTypes.PersonalDetailsList, policy?: OnyxTypes.Policy, isReportArchived = false, ) { - const avatarIcons = getIcons(report, formatPhoneNumber, personalDetailsList, null, '', -1, policy, undefined, isReportArchived); + const avatarIcons = getIcons(report, formatPhoneNumber, translate, personalDetailsList, null, '', -1, policy, undefined, isReportArchived); const hasSecondAvatar = avatarIcons.length > 1 && !!avatarIcons.at(1)?.name; let avatarType: ValueOf; @@ -2607,7 +2608,7 @@ function getTaskSections( const policy = data[`${ONYXKEYS.COLLECTION.POLICY}${parentReport.policyID}`]; const isParentReportArchived = isArchivedReport(reportNameValuePairs?.[`${ONYXKEYS.COLLECTION.REPORT_NAME_VALUE_PAIRS}${parentReport?.reportID}`]); const parentReportName = getReportName(parentReport, reportAttributesDerivedValue); - const icons = getIcons(parentReport, formatPhoneNumber, personalDetails, null, '', -1, policy, undefined, isParentReportArchived); + const icons = getIcons(parentReport, formatPhoneNumber, translate, personalDetails, null, '', -1, policy, undefined, isParentReportArchived); const parentReportIcon = icons?.at(0); result.parentReportName = parentReportName; @@ -2909,7 +2910,7 @@ function getReportSections({ const {totalDisplaySpend, nonReimbursableSpend, reimbursableSpend} = getMoneyRequestSpendBreakdown(reportItem); const reportIsArchived = isArchivedReport(getReportNameValuePairsFromKey(data, reportItem)); - const avatarProps = getSearchReportAvatarProps(reportItem, formatPhoneNumber, mergedPersonalDetails, policy, reportIsArchived); + const avatarProps = getSearchReportAvatarProps(reportItem, formatPhoneNumber, translate, mergedPersonalDetails, policy, reportIsArchived); const isRejectedReport = reportItem.stateNum === CONST.REPORT.STATE_NUM.OPEN && diff --git a/src/libs/SidebarUtils.ts b/src/libs/SidebarUtils.ts index 8f28be104bd6..c85e76fcbc0d 100644 --- a/src/libs/SidebarUtils.ts +++ b/src/libs/SidebarUtils.ts @@ -1381,6 +1381,7 @@ function getOptionData({ const reportIcons = getIcons( report, formatPhoneNumberPhoneUtils, + translate, personalDetails, personalDetail?.avatar, personalDetail?.login, diff --git a/src/libs/actions/Task.ts b/src/libs/actions/Task.ts index 4ccd7044d3bf..e3c8165f7ca7 100644 --- a/src/libs/actions/Task.ts +++ b/src/libs/actions/Task.ts @@ -1153,7 +1153,7 @@ function getShareDestination( subtitle = ReportUtils.getChatRoomSubtitle(report, policy, conciergeReportID, translate) ?? ''; } return { - icons: ReportUtils.getIcons(report, LocalePhoneNumber.formatPhoneNumber, personalDetails, FallbackAvatar), + icons: ReportUtils.getIcons(report, LocalePhoneNumber.formatPhoneNumber, translate, personalDetails, FallbackAvatar), displayName: getReportName(report, reportAttributes), subtitle, displayNamesWithTooltips, diff --git a/src/pages/DynamicReportDetailsPage.tsx b/src/pages/DynamicReportDetailsPage.tsx index d7ccb63aeaab..fd3101eef83d 100644 --- a/src/pages/DynamicReportDetailsPage.tsx +++ b/src/pages/DynamicReportDetailsPage.tsx @@ -736,8 +736,8 @@ function DynamicReportDetailsPage({policy, report, route, reportMetadata, report ]); const icons = useMemo( - () => getIcons(report, formatPhoneNumber, personalDetails, null, '', -1, policy, undefined, isReportArchived), - [report, formatPhoneNumber, personalDetails, policy, isReportArchived], + () => getIcons(report, formatPhoneNumber, translate, personalDetails, null, '', -1, policy, undefined, isReportArchived), + [report, formatPhoneNumber, translate, personalDetails, policy, isReportArchived], ); const renderedAvatar = useMemo(() => { diff --git a/src/pages/inbox/sidebar/FABPopoverContent/menuItems/QuickActionMenuItem.tsx b/src/pages/inbox/sidebar/FABPopoverContent/menuItems/QuickActionMenuItem.tsx index f030c7be4fcb..7651391d8c4c 100644 --- a/src/pages/inbox/sidebar/FABPopoverContent/menuItems/QuickActionMenuItem.tsx +++ b/src/pages/inbox/sidebar/FABPopoverContent/menuItems/QuickActionMenuItem.tsx @@ -87,10 +87,10 @@ function QuickActionMenuItem({reportID}: QuickActionMenuItemProps) { let quickActionAvatars: ReturnType = []; if (isValidReport) { - const avatars = getIcons(quickActionReport, formatPhoneNumber, personalDetails, null, undefined, undefined, undefined, undefined, isReportArchived); + const avatars = getIcons(quickActionReport, formatPhoneNumber, translate, personalDetails, null, undefined, undefined, undefined, undefined, isReportArchived); quickActionAvatars = avatars.length <= 1 || isPolicyExpenseChat(quickActionReport) ? avatars : avatars.filter((avatar) => avatar.id !== currentUserPersonalDetails.accountID); } else if (!isEmptyObject(policyChatForActivePolicy)) { - quickActionAvatars = getIcons(policyChatForActivePolicy, formatPhoneNumber, personalDetails, null, undefined, undefined, undefined, undefined, isReportArchived); + quickActionAvatars = getIcons(policyChatForActivePolicy, formatPhoneNumber, translate, personalDetails, null, undefined, undefined, undefined, undefined, isReportArchived); } let quickActionTitle = ''; diff --git a/src/pages/iou/request/step/IOURequestEditReportCommon.tsx b/src/pages/iou/request/step/IOURequestEditReportCommon.tsx index 28486f114c20..9ecf7bd8fc36 100644 --- a/src/pages/iou/request/step/IOURequestEditReportCommon.tsx +++ b/src/pages/iou/request/step/IOURequestEditReportCommon.tsx @@ -172,10 +172,21 @@ function IOURequestEditReportCommon({ isSelected: report.reportID === selectedReportID, policyID: report.policyID, reportID: report.reportID, - icons: getIconsForExpenseReport(report, personalDetails, policy), + icons: getIconsForExpenseReport(report, personalDetails, policy, translate), }; }); - }, [debouncedSearchValue, outstandingReports, selectedReportID, personalDetails, localeCompare, allPolicies, currentUserPersonalDetails.accountID, isPerDiemRequest, isTimeRequest]); + }, [ + debouncedSearchValue, + outstandingReports, + selectedReportID, + personalDetails, + localeCompare, + allPolicies, + currentUserPersonalDetails.accountID, + isPerDiemRequest, + isTimeRequest, + translate, + ]); const navigateBack = () => { Navigation.goBack(backTo); diff --git a/tests/perf-test/ReportUtils.perf-test.ts b/tests/perf-test/ReportUtils.perf-test.ts index 3cc41fffc789..d369b2407a97 100644 --- a/tests/perf-test/ReportUtils.perf-test.ts +++ b/tests/perf-test/ReportUtils.perf-test.ts @@ -130,7 +130,7 @@ describe('ReportUtils', () => { const defaultIconId = -1; await waitForBatchedUpdates(); - await measureFunction(() => getIcons(report, formatPhoneNumber, personalDetails, defaultIcon, defaultName, defaultIconId, policy)); + await measureFunction(() => getIcons(report, formatPhoneNumber, translateLocal, personalDetails, defaultIcon, defaultName, defaultIconId, policy)); }); test('[ReportUtils] getDisplayNamesWithTooltips 1k participants', async () => { diff --git a/tests/ui/SearchReportAvatarTest.tsx b/tests/ui/SearchReportAvatarTest.tsx index 06722b0d6e64..bdfdc2a6b1d2 100644 --- a/tests/ui/SearchReportAvatarTest.tsx +++ b/tests/ui/SearchReportAvatarTest.tsx @@ -23,6 +23,7 @@ import {actionR14932} from '../../__mocks__/reportData/actions'; import personalDetails from '../../__mocks__/reportData/personalDetails'; import {policy420A} from '../../__mocks__/reportData/policies'; import {chatReportR14932, iouReportR14932} from '../../__mocks__/reportData/reports'; +import {translateLocal} from '../utils/TestHelper'; import waitForBatchedUpdates from '../utils/waitForBatchedUpdates'; import waitForBatchedUpdatesWithAct from '../utils/waitForBatchedUpdatesWithAct'; @@ -250,7 +251,7 @@ describe('SearchReportAvatar', () => { describe('renders subscript avatars for workspace-linked reports', () => { it('renders user primary avatar and workspace subscript for an expense report', async () => { - const props = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, personalDetails, policy); + const props = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, translateLocal, personalDetails, policy); const {images, fragments} = await retrieveAvatarData({...props, reportID: expenseReport.reportID}); expect(props.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT); @@ -264,7 +265,7 @@ describe('SearchReportAvatar', () => { }); it('renders workspace primary avatar and user subscript for a policy expense chat', async () => { - const props = getSearchReportAvatarProps(chatReport, formatPhoneNumber, personalDetails, policy); + const props = getSearchReportAvatarProps(chatReport, formatPhoneNumber, translateLocal, personalDetails, policy); const {images, fragments} = await retrieveAvatarData({...props, reportID: chatReport.reportID}); expect(props.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT); @@ -278,7 +279,7 @@ describe('SearchReportAvatar', () => { }); it('renders user primary avatar and workspace subscript for a trip report', async () => { - const props = getSearchReportAvatarProps(iouTripReport, formatPhoneNumber, personalDetails, policy); + const props = getSearchReportAvatarProps(iouTripReport, formatPhoneNumber, translateLocal, personalDetails, policy); const {images, fragments} = await retrieveAvatarData({...props, reportID: iouTripReport.reportID}); expect(props.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT); @@ -294,7 +295,7 @@ describe('SearchReportAvatar', () => { describe('renders diagonal multiple avatars for IOU reports (both user avatars)', () => { it('renders manager as main and owner as secondary in diagonal layout for an IOU report', async () => { - const props = getSearchReportAvatarProps(iouReport, formatPhoneNumber, personalDetails, personalPolicy); + const props = getSearchReportAvatarProps(iouReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); const {images, fragments} = await retrieveAvatarData({...props, reportID: iouReport.reportID}); expect(props.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.MULTIPLE_DIAGONAL); @@ -308,7 +309,7 @@ describe('SearchReportAvatar', () => { }); it('renders manager as main and owner as secondary in diagonal layout for a DM IOU report', async () => { - const props = getSearchReportAvatarProps(iouDMReport, formatPhoneNumber, personalDetails, personalPolicy); + const props = getSearchReportAvatarProps(iouDMReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); const {images, fragments} = await retrieveAvatarData({...props, reportID: iouDMReport.reportID}); expect(props.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.MULTIPLE_DIAGONAL); @@ -324,7 +325,7 @@ describe('SearchReportAvatar', () => { describe('renders single avatar for personal policy expense reports', () => { it('renders single user avatar for a DM single-expense report', async () => { - const props = getSearchReportAvatarProps(iouDMSingleExpenseReport, formatPhoneNumber, personalDetails, personalPolicy); + const props = getSearchReportAvatarProps(iouDMSingleExpenseReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); const {images} = await retrieveAvatarData({...props, reportID: iouDMSingleExpenseReport.reportID}); expect(props.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SINGLE); @@ -351,7 +352,7 @@ describe('SearchReportAvatar', () => { }); it('renders single avatar when avatarType is SINGLE even if secondaryAvatar is provided', async () => { - const avatarIcons = getIcons(expenseReport, formatPhoneNumber, personalDetails, null, '', -1, policy); + const avatarIcons = getIcons(expenseReport, formatPhoneNumber, translateLocal, personalDetails, null, '', -1, policy); const {images, fragments} = await retrieveAvatarData({ primaryAvatar: avatarIcons.at(0), secondaryAvatar: avatarIcons.at(1), @@ -368,7 +369,7 @@ describe('SearchReportAvatar', () => { }); it('renders single avatar when secondaryAvatar is missing even if avatarType is SUBSCRIPT', async () => { - const avatarIcons = getIcons(expenseReport, formatPhoneNumber, personalDetails, null, '', -1, policy); + const avatarIcons = getIcons(expenseReport, formatPhoneNumber, translateLocal, personalDetails, null, '', -1, policy); const {images} = await retrieveAvatarData({ primaryAvatar: avatarIcons.at(0), secondaryAvatar: undefined, @@ -384,7 +385,7 @@ describe('SearchReportAvatar', () => { describe('getSearchReportAvatarProps computes avatar props correctly', () => { it('produces correct primaryAvatar and secondaryAvatar for expense reports', () => { - const {primaryAvatar, secondaryAvatar} = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, personalDetails, policy); + const {primaryAvatar, secondaryAvatar} = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, translateLocal, personalDetails, policy); expect(primaryAvatar).toBeDefined(); expect(parseSource(primaryAvatar?.source ?? '')).toBe(USER_AVATAR); @@ -394,32 +395,32 @@ describe('SearchReportAvatar', () => { }); it('returns SUBSCRIPT avatarType for expense reports', () => { - const {avatarType} = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, personalDetails, policy); + const {avatarType} = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, translateLocal, personalDetails, policy); expect(avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT); }); it('produces correct icons for IOU reports (manager as primary, owner as secondary)', () => { - const {primaryAvatar, secondaryAvatar} = getSearchReportAvatarProps(iouReport, formatPhoneNumber, personalDetails, personalPolicy); + const {primaryAvatar, secondaryAvatar} = getSearchReportAvatarProps(iouReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); expect(parseSource(primaryAvatar?.source ?? '')).toBe(SECOND_USER_AVATAR); expect(parseSource(secondaryAvatar?.source ?? '')).toBe(USER_AVATAR); }); it('returns MULTIPLE_DIAGONAL avatarType for personal policy IOU reports', () => { - const {avatarType} = getSearchReportAvatarProps(iouReport, formatPhoneNumber, personalDetails, personalPolicy); + const {avatarType} = getSearchReportAvatarProps(iouReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); expect(avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.MULTIPLE_DIAGONAL); }); it('uses SUBSCRIPT for workspace expense reports and MULTIPLE_DIAGONAL for personal IOU reports', () => { - const expenseProps = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, personalDetails, policy); + const expenseProps = getSearchReportAvatarProps(expenseReport, formatPhoneNumber, translateLocal, personalDetails, policy); expect(expenseProps.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT); - const iouProps = getSearchReportAvatarProps(iouReport, formatPhoneNumber, personalDetails, personalPolicy); + const iouProps = getSearchReportAvatarProps(iouReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); expect(iouProps.avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.MULTIPLE_DIAGONAL); }); it('produces correct icons for a trip report (user + workspace, subscript)', () => { - const {primaryAvatar, secondaryAvatar, avatarType} = getSearchReportAvatarProps(iouTripReport, formatPhoneNumber, personalDetails, policy); + const {primaryAvatar, secondaryAvatar, avatarType} = getSearchReportAvatarProps(iouTripReport, formatPhoneNumber, translateLocal, personalDetails, policy); expect(avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SUBSCRIPT); expect(parseSource(primaryAvatar?.source ?? '')).toBe(USER_AVATAR); @@ -429,7 +430,7 @@ describe('SearchReportAvatar', () => { }); it('produces correct icons for a DM IOU report (manager + owner, diagonal multiple)', () => { - const {primaryAvatar, secondaryAvatar, avatarType} = getSearchReportAvatarProps(iouDMReport, formatPhoneNumber, personalDetails, personalPolicy); + const {primaryAvatar, secondaryAvatar, avatarType} = getSearchReportAvatarProps(iouDMReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); expect(avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.MULTIPLE_DIAGONAL); expect(parseSource(primaryAvatar?.source ?? '')).toBe(SECOND_USER_AVATAR); @@ -439,7 +440,7 @@ describe('SearchReportAvatar', () => { }); it('produces correct icons for a DM single-expense report (single user, no subscript)', () => { - const {primaryAvatar, avatarType} = getSearchReportAvatarProps(iouDMSingleExpenseReport, formatPhoneNumber, personalDetails, personalPolicy); + const {primaryAvatar, avatarType} = getSearchReportAvatarProps(iouDMSingleExpenseReport, formatPhoneNumber, translateLocal, personalDetails, personalPolicy); expect(avatarType).toBe(CONST.REPORT_ACTION_AVATARS.TYPE.SINGLE); expect(parseSource(primaryAvatar?.source ?? '')).toBe(USER_AVATAR); diff --git a/tests/unit/LHNAvatarPipelineTest.ts b/tests/unit/LHNAvatarPipelineTest.ts index 2ce7ca5eed1f..2996dce0acfb 100644 --- a/tests/unit/LHNAvatarPipelineTest.ts +++ b/tests/unit/LHNAvatarPipelineTest.ts @@ -23,6 +23,7 @@ import { createWorkspaceTaskReport, createWorkspaceThread, } from '../utils/collections/reports'; +import {translateLocal} from '../utils/TestHelper'; import waitForBatchedUpdates from '../utils/waitForBatchedUpdates'; // ─── Test Constants ────────────────────────────────────────────────────────── @@ -96,7 +97,7 @@ function computeAvatarResult({report, policy = TEST_POLICY, isReportArchived = f const shouldShowSubscript = rawShouldShowSubscript && !threadSuppression && !taskSuppression; const formatPhoneNumber = (s: string) => s; - let icons = getIcons(report, formatPhoneNumber, PERSONAL_DETAILS, null, '', -1, policy, undefined, isReportArchived); + let icons = getIcons(report, formatPhoneNumber, translateLocal, PERSONAL_DETAILS, null, '', -1, policy, undefined, isReportArchived); if (!shouldShowSubscript && report.type !== CONST.REPORT.TYPE.IOU && report.type !== CONST.REPORT.TYPE.INVOICE && icons.length > 1) { const firstIcon = icons.at(0); diff --git a/tests/unit/ReportUtilsGetIconsTest.ts b/tests/unit/ReportUtilsGetIconsTest.ts index 8448edec070e..ef864d2d3a3b 100644 --- a/tests/unit/ReportUtilsGetIconsTest.ts +++ b/tests/unit/ReportUtilsGetIconsTest.ts @@ -1,3 +1,5 @@ +import type {LocalizedTranslate} from '@components/LocaleContextProvider'; + import {getOneTransactionThreadReportID} from '@libs/ReportActionsUtils'; import { getIcons, @@ -34,7 +36,7 @@ import Onyx from 'react-native-onyx'; import {actionR14932, actionR98765} from '../../__mocks__/reportData/actions'; import * as LHNTestUtils from '../utils/LHNTestUtils'; -import {formatPhoneNumber} from '../utils/TestHelper'; +import {formatPhoneNumber, translateLocal} from '../utils/TestHelper'; const FAKE_PERSONAL_DETAILS = LHNTestUtils.fakePersonalDetails; /* eslint-disable @typescript-eslint/naming-convention */ @@ -129,7 +131,7 @@ beforeAll(() => { describe('getIcons', () => { it('should return a fallback icon if the report is empty', () => { const report = {} as Report; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); }); @@ -146,7 +148,7 @@ describe('getIcons', () => { expect(isExpenseRequest(report)).toBe(true); expect(isThread(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); expect(icons.at(0)?.name).toBe('Email One'); }); @@ -161,7 +163,7 @@ describe('getIcons', () => { // Verify report type conditions expect(isArchivedNonExpenseReport(report, true)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy, undefined, true); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy, undefined, true); expect(icons).toHaveLength(1); expect(icons.at(0)?.name).toBe(policy.name); expect(icons.at(0)?.type).toBe('workspace'); @@ -178,7 +180,7 @@ describe('getIcons', () => { expect(isChatThread(report)).toBe(true); expect(isThread(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); expect(icons.at(0)?.name).toBe('Email\u00A0Two'); }); @@ -193,18 +195,33 @@ describe('getIcons', () => { // Verify report type conditions expect(isTaskReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); expect(icons.at(0)?.name).toBe('Email One'); }); + it('should resolve the task owner fallback name through the provided translate function', () => { + const report: Report = { + ...LHNTestUtils.getFakeReport([1], 0, true), + type: CONST.REPORT.TYPE.TASK, + // An owner without personal details resolves the icon name via translate('common.hidden'). + ownerAccountID: 999999, + }; + const translateWithHiddenMarker: LocalizedTranslate = (path, ...parameters) => (path === 'common.hidden' ? 'HiddenMarker' : translateLocal(path, ...parameters)); + + const icons = getIcons(report, formatPhoneNumber, translateWithHiddenMarker, FAKE_PERSONAL_DETAILS); + + expect(icons).toHaveLength(1); + expect(icons.at(0)?.name).toBe('HiddenMarker'); + }); + it('should return the correct icons for a domain room', () => { const report: Report = { ...LHNTestUtils.getFakeReport([], 0, true), chatType: CONST.REPORT.CHAT_TYPE.DOMAIN_ALL, reportName: '#domain-test', }; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); expect(icons.at(0)?.name).toBe('domain-test'); }); @@ -216,7 +233,7 @@ describe('getIcons', () => { policyID: '1', }; const policy = LHNTestUtils.getFakePolicy('1'); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(1); expect(icons.at(0)?.name).toBe('Workspace-Test-001'); }); @@ -234,7 +251,7 @@ describe('getIcons', () => { expect(isUserCreatedPolicyRoom(report)).toBe(true); expect(isChatReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(1); expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); expect(icons.at(0)?.source).toBe('https://example.com/avatar.png'); @@ -252,7 +269,7 @@ describe('getIcons', () => { expect(isPolicyExpenseChat(report)).toBe(true); expect(isChatReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); expect(icons.at(1)?.type).toBe(CONST.ICON_TYPE_AVATAR); @@ -269,7 +286,7 @@ describe('getIcons', () => { // Verify report type conditions expect(isExpenseReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_AVATAR); expect(icons.at(1)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); @@ -289,7 +306,7 @@ describe('getIcons', () => { expect(isIOUReport(report)).toBe(true); expect(isMoneyRequestReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(2); expect(icons.at(0)?.name).toBe('Email\u0020Two'); expect(icons.at(1)?.name).toBe('Email One'); @@ -305,7 +322,7 @@ describe('getIcons', () => { expect(isSelfDM(report)).toBe(true); expect(isChatReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); expect(icons.at(0)?.name).toBe('Email Five'); }); @@ -315,7 +332,7 @@ describe('getIcons', () => { ...LHNTestUtils.getFakeReport([], 0, true), chatType: CONST.REPORT.CHAT_TYPE.SYSTEM, }; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); expect(icons.at(0)?.id).toBe(CONST.ACCOUNT_ID.NOTIFICATIONS); }); @@ -330,7 +347,7 @@ describe('getIcons', () => { expect(isGroupChat(report)).toBe(true); expect(isChatReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); }); @@ -339,7 +356,7 @@ describe('getIcons', () => { ...LHNTestUtils.getFakeReport([1, 2, 3], 0, true), chatType: CONST.REPORT.CHAT_TYPE.GROUP, }; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); }); @@ -349,7 +366,7 @@ describe('getIcons', () => { chatType: CONST.REPORT.CHAT_TYPE.GROUP, avatarUrl: 'https://example.com/avatar.png', }; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); }); @@ -365,7 +382,7 @@ describe('getIcons', () => { // Verify report type conditions expect(isInvoiceReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); expect(icons.at(1)?.name).toBe('Email Three'); @@ -375,7 +392,7 @@ describe('getIcons', () => { const report: Report = { ...LHNTestUtils.getFakeReport([1], 0, true), }; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); expect(icons.at(0)?.name).toBe('Email One'); }); @@ -385,7 +402,7 @@ describe('getIcons', () => { ...LHNTestUtils.getFakeReport([1, 2, 3, 4], 0, true), type: undefined, }; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(4); }); @@ -404,7 +421,7 @@ describe('getIcons', () => { expect(isChatThread(report)).toBe(true); expect(isWorkspaceThread(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); // Actor + workspace icon expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_AVATAR); @@ -425,7 +442,7 @@ describe('getIcons', () => { expect(isTaskReport(report)).toBe(true); expect(isWorkspaceTaskReport(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); // Owner + workspace icon expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_AVATAR); @@ -444,7 +461,7 @@ describe('getIcons', () => { expect(isAdminRoom(report)).toBe(true); expect(isChatRoom(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(1); expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); }); @@ -461,7 +478,7 @@ describe('getIcons', () => { expect(isAnnounceRoom(report)).toBe(true); expect(isChatRoom(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(1); expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); }); @@ -482,7 +499,7 @@ describe('getIcons', () => { expect(isInvoiceRoom(report)).toBe(true); expect(isIndividualInvoiceRoom(report)).toBe(true); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); // Workspace + individual receiver expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); expect(icons.at(1)?.type).toBe(CONST.ICON_TYPE_AVATAR); @@ -500,7 +517,7 @@ describe('getIcons', () => { }, }; const policy = LHNTestUtils.getFakePolicy('1'); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy, receiverPolicy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy, receiverPolicy); expect(icons).toHaveLength(2); // Workspace + receiver workspace expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); expect(icons.at(1)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); @@ -532,7 +549,7 @@ describe('getIcons', () => { expect(isMoneyRequestReport(report)).toBe(true); expect(getOneTransactionThreadReportID(report, chatReport, reportActions)).toBeFalsy(); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(2); expect(icons.at(0)?.name).toBe('Email\u0020Two'); @@ -548,7 +565,7 @@ describe('getIcons', () => { }, }, }; - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS); expect(icons).toHaveLength(1); expect(icons.at(0)?.id).toBe(CONST.ACCOUNT_ID.CONCIERGE); }); @@ -565,7 +582,7 @@ describe('getIcons', () => { expect(isInvoiceReport(report)).toBe(true); const policy = LHNTestUtils.getFakePolicy('1'); - const icons = getIcons(report, formatPhoneNumber, FAKE_PERSONAL_DETAILS, null, '', -1, policy); + const icons = getIcons(report, formatPhoneNumber, translateLocal, FAKE_PERSONAL_DETAILS, null, '', -1, policy); expect(icons).toHaveLength(2); expect(icons.at(0)?.type).toBe(CONST.ICON_TYPE_WORKSPACE); expect(icons.at(1)?.name).toBe('Email Three'); diff --git a/tests/unit/Search/SearchUIUtilsTest.ts b/tests/unit/Search/SearchUIUtilsTest.ts index 3f62d163905b..118a25fb6d65 100644 --- a/tests/unit/Search/SearchUIUtilsTest.ts +++ b/tests/unit/Search/SearchUIUtilsTest.ts @@ -5053,6 +5053,76 @@ describe('SearchUIUtils', () => { expect(result.at(0)?.keyForList).toBe(taskReportID); }); + it('should compute parentReportName and parentReportIcon when the parent report exists in the data', () => { + const taskReportID = 'task_report_101'; + const parentReportID = 'parent_report_201'; + const taskCreatorAccountID = 11111; + const taskAssigneeAccountID = 22222; + + const taskReport = { + type: CONST.REPORT.TYPE.TASK, + reportID: taskReportID, + reportName: 'Fix the login bug', + description: 'The login page has a bug that needs fixing', + accountID: taskCreatorAccountID, + managerID: taskAssigneeAccountID, + parentReportID, + stateNum: CONST.REPORT.STATE_NUM.OPEN, + statusNum: CONST.REPORT.STATUS_NUM.OPEN, + created: '2025-01-15 10:00:00', + } as const; + + const parentReport = { + type: CONST.REPORT.TYPE.CHAT, + reportID: parentReportID, + reportName: 'Parent chat', + participants: { + [taskCreatorAccountID]: {notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS}, + [taskAssigneeAccountID]: {notificationPreference: CONST.REPORT.NOTIFICATION_PREFERENCE.ALWAYS}, + }, + } as const; + + const taskData: OnyxTypes.SearchResults['data'] = { + personalDetailsList: { + [taskCreatorAccountID]: { + accountID: taskCreatorAccountID, + avatar: '', + displayName: 'Task Creator', + login: 'creator@test.com', + }, + [taskAssigneeAccountID]: { + accountID: taskAssigneeAccountID, + avatar: '', + displayName: 'Task Assignee', + login: 'assignee@test.com', + }, + }, + [`report_${taskReportID}`]: taskReport, + [`report_${parentReportID}`]: parentReport, + }; + + const [result] = SearchUIUtils.getSections({ + type: CONST.SEARCH.DATA_TYPES.TASK, + data: taskData, + currentAccountID: taskCreatorAccountID, + currentUserEmail: 'creator@test.com', + translate: translateLocal, + formatPhoneNumber, + bankAccountList: {}, + conciergeReportID: '999', + convertToDisplayString, + reportAttributesDerivedValue: undefined, + }); + + expect(result).toHaveLength(1); + expect(result.at(0)).toEqual( + expect.objectContaining({ + parentReportName: 'Parent chat', + parentReportIcon: expect.objectContaining({id: taskCreatorAccountID, type: CONST.ICON_TYPE_AVATAR, name: 'Task Creator'}), + }), + ); + }); + it('resolves task assignee and creator fallback names through the provided translate function', () => { const taskReportID = 'task_report_hidden_members'; const taskReport = {