From 3cd7239fc070ffd1e84dad165b96980e9765092d Mon Sep 17 00:00:00 2001 From: "Situ Chandra Shil (via MelvinBot)" Date: Thu, 23 Jul 2026 03:55:20 +0000 Subject: [PATCH 1/3] Refactor BusinessInfo IncorporationStateBusiness loader to ActivityIndicator Co-authored-by: Situ Chandra Shil --- .../subSteps/IncorporationStateBusiness.tsx | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx b/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx index 817d5e99f0bd..43b4f4203436 100644 --- a/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx +++ b/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx @@ -1,7 +1,7 @@ +import ActivityIndicator from '@components/ActivityIndicator'; import FormProvider from '@components/Form/FormProvider'; import InputWrapper from '@components/Form/InputWrapper'; import type {FormInputErrors, FormOnyxValues} from '@components/Form/types'; -import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator'; import type {LocalizedTranslate} from '@components/LocaleContextProvider'; import StateSelector from '@components/StateSelector'; import Text from '@components/Text'; @@ -15,11 +15,13 @@ import useThemeStyles from '@hooks/useThemeStyles'; import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan'; import {getFieldRequiredErrors} from '@libs/ValidationUtils'; +import CONST from '@src/CONST'; import ONYXKEYS from '@src/ONYXKEYS'; import INPUT_IDS from '@src/types/form/ReimbursementAccountForm'; import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue'; import React from 'react'; +import {View} from 'react-native'; const COMPANY_INCORPORATION_STATE_KEY = INPUT_IDS.BUSINESS_INFO_STEP.INCORPORATION_STATE; const STEP_FIELDS = [COMPANY_INCORPORATION_STATE_KEY]; @@ -49,7 +51,14 @@ function IncorporationStateBusiness({onNext, isEditing}: SubPageProps) { context: 'IncorporationStateBusiness', isLoadingReimbursementAccount, }; - return ; + return ( + + + + ); } return ( From 8a93a134b242707ada2702988dab7ba2cda5116b Mon Sep 17 00:00:00 2001 From: "{\"message\":\"Not Found\",\"documentation_url\":\"https://docs.github.com/rest/issues/comments#get-an-issue-comment\",\"status\":\"404\"} (via MelvinBot)" Date: Sun, 2 Aug 2026 18:13:51 +0000 Subject: [PATCH 2/3] Use styles.fullScreenLoading and remove redundant alignItemsCenter/justifyContentCenter Co-authored-by: {"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"} <{"message":"Not Found","documentation_url":"https://docs.github.com/rest/issues/comments#get-an-issue-comment","status":"404"}@users.noreply.github.com> --- .../USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx b/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx index 43b4f4203436..6ee3d71b89bf 100644 --- a/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx +++ b/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx @@ -52,7 +52,7 @@ function IncorporationStateBusiness({onNext, isEditing}: SubPageProps) { isLoadingReimbursementAccount, }; return ( - + Date: Wed, 12 Aug 2026 19:13:29 +0000 Subject: [PATCH 3/3] Adapt IncorporationStateBusiness loader after skeleton-span telemetry removal on main Co-authored-by: Situ Chandra Shil --- .../subSteps/IncorporationStateBusiness.tsx | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx b/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx index 6ee3d71b89bf..de2bf51d3fc7 100644 --- a/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx +++ b/src/pages/ReimbursementAccount/USD/BusinessInfo/subSteps/IncorporationStateBusiness.tsx @@ -12,7 +12,6 @@ import useReimbursementAccountStepFormSubmit from '@hooks/useReimbursementAccoun import type {SubPageProps} from '@hooks/useSubPage/types'; import useThemeStyles from '@hooks/useThemeStyles'; -import type {SkeletonSpanReasonAttributes} from '@libs/telemetry/useSkeletonSpan'; import {getFieldRequiredErrors} from '@libs/ValidationUtils'; import CONST from '@src/CONST'; @@ -47,16 +46,9 @@ function IncorporationStateBusiness({onNext, isEditing}: SubPageProps) { }); if (isLoadingReimbursementAccount) { - const reasonAttributes: SkeletonSpanReasonAttributes = { - context: 'IncorporationStateBusiness', - isLoadingReimbursementAccount, - }; return ( - + ); }