Repository navigation
Conversation
Extend the weight-loading owner with source-bound byte, resident-state and oracle-path checks for streamed routed experts. Preserve candidate/not_run and synthetic-fixture limits. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex (gpt-6.1-sol, reasoning_effort=max)
Regenerate coverage and packaged skill discovery from actual source 8b29027. Signed-off-by: Dong1017 <55723162+Dong1017@users.noreply.github.com> Agent-assisted-by: Codex (gpt-6.1-sol, reasoning_effort=max)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Skill evaluationPLANNED: not executed; there are no task outcomes yet.
Author verification steps (nonpaid; not yet run)
python tools/build_skill_index.py --source-revision 8b290275cd757ae9baa3d7e75f98e8283846853d --checkThe declared source pin matches this head's canonical library bytes. The command has not run: retain its exit code and full drift/success output. It checks the generated projection, not claim truth or skill efficacy. Evidence and logs · Retention: 30 days. Plan bindings, budget, frozen exam and advisory detailsAdvisory: obtain missing evidenceRetained evidence availability: planned / unexecuted. No approval or merge authorization is issued.
Model/settings:
Automatic execution / cumulative PR budget: {"reason":"Trusted configuration or pricing missing, invalid or expired","remaining_usd":"unknown","reserved_or_unresolved_usd":"unknown","spent_or_legacy_usd":"unknown","state":"blocked"}Projection check selection (not an executed result): {"declared_in":"src/inferrsi/data/repo_packs/inferrsi/knowledge/README.md","source_revision":"8b290275cd757ae9baa3d7e75f98e8283846853d","status":"ready"}Provider/settings: Uncovered / unsupported paths (87)
|
Dong1017
added
the
area:knowledge
ChatGPT Codex Connector
Dong1017
left a comment
Dong1017
left a comment
There was a problem hiding this comment.
Scoped incremental review of #324 at fd7f8bad against the concurrently open #322 (76b680a6): the source/packaging checks described on each standalone head do not test their combined knowledge projections. One P2 conditional integration risk is noted inline: 83 changed files overlap, including shared generated cards and source-snapshot pointers. Please keep the existing knowledge integrator's sequential landing path and rederive projections from both canonical inputs after the first merge. This is a coordination recommendation, not a new merge gate or an empirical quality verdict. Reviewed the relevant source amendments, projection patches, current discussions and repo generation contract; did not run an upstream C suite, models, SkillEval or an integrated build.
| procedures use their corresponding backend; shared methods use `common`. | ||
|
|
||
| Source snapshot: [8115da15b9ef34978de500b08aa9f14ea790c35b](https://github.com/InferMatrixLab/InferRSI/tree/8115da15b9ef34978de500b08aa9f14ea790c35b/src/inferrsi/data/skill_library). | ||
| Source snapshot: [8b290275cd757ae9baa3d7e75f98e8283846853d](https://github.com/InferMatrixLab/InferRSI/tree/8b290275cd757ae9baa3d7e75f98e8283846853d/src/inferrsi/data/skill_library). |
There was a problem hiding this comment.
P2 · conditional cross-PR integration risk. #322 (Xe-Forge) also updates this generated Source snapshot pointer from the same 2baebf6e main, and its diff overlaps 83 of this PR's 87 paths, including docs/skill-coverage.md and the generated skill cards. Both heads can pass independently while a sequential merge that simply selects one projection/source revision drops or stales the other's addition. After the first PR lands, please regenerate the remaining PR's shared projections from the combined canonical sources and check that both Xe-Forge and DeepSeek references are still discoverable and the source/index --check succeeds. This is not a defect in either standalone source analysis.
Dong1017
left a comment
Dong1017
left a comment
There was a problem hiding this comment.
Independent source review found no additional actionable defect in the expert-cache amendment at fd7f8bad. This conclusion covers source fidelity and the observed software checks; the existing integration discussion remains applicable.
- Verified: the 15 selected upstream files match their recorded byte counts, SHA-256 and Git blob identities. The reference accurately separates buffered-byte independence from shared metadata, resident/pending ownership, actual callback selection and ordered per-
kaccumulation. - Coverage limits are preserved: the resident snapshot checks
w1; the tiny PyTorch comparison uses tolerance/argmax, while batched C output is compared bitwise with the anchored per-token C path. Missing fixtures can return exit-zero SKIP. These definitions do not establish released-model correctness or a performance gain. - Software: current Ready/declaration checks pass. The inspected 3.11 log reports 3,389 passed, 13 skipped and 284 passing subtests; its synthetic merge has exactly the head tree. The canonical-to-head delta is projection-only, and the 78 unrelated cards change only source headers.
- Next: Dong1017 retains this amendment's integration. Continue the existing sequential-integration thread; its conditional cross-PR finding is not duplicated here. Skill Eval has no executed comparison, and candidate/
not_runremains appropriate.
Evidence and review scope
- Head:
fd7f8bad0a97b1f7e398a1cf6a494fefbf853ae2; API base / observed main:2baebf6ebb815ebf07d21c41e3b3754858c0798e. - Canonical source:
8b290275cd757ae9baa3d7e75f98e8283846853d. Its head delta changes only 81 generated projection files; six canonical/manual paths comprise the remaining PR scope. - Pinned upstream:
d0402056d0da4bf7edfd2d4977de479a0db9d201. I verified the 15 selected file identities, not the author's separate 74-blob inventory claim, and traced the amendment through cache placement/reader lifecycle, aligned/buffered reads, per-token/batched consumers, CLI/oracle wiring and test/fixture definitions. The readset retains source rights/exclusions and claim boundaries. - Ready run, including the inspected 3.11 log. Tested merge
6c1ea6fb82db36a0fefffea82e006159ca9654f6has main/head parents; its tree equals head:62d25a49024f814e6ecc55abcfbe9d322ed1c049. - Per-head declarations passed. Skill Eval remains PLANNED: zero selected comparisons, execution skipped. The author's source-M index-check success establishes reported projection consistency; this maintenance session did not rerun it.
- Source claim disposition: verified within the inspected paths; unverified for native C/model execution, production-scale numerical quality, device/performance and skill benefit. The author's incomplete Windows/Python 3.13 run remains incomplete; hosted 3.10/3.11 evidence is separate.
- Independent maintenance review; I did not implement the amendment. This run used static reads, hashing and existing CI logs only. No upstream suite, model/device work, local suite, combined #322/#324 build or paid trial was executed. Concurrent #322 head is
76b680a6a2be842e7999ffaf4a1a31c76c3dfac2; standalone checks do not qualify that combination. This COMMENT does not grant formal approval, merge permission or governing-Issue acceptance.
Refs #91. Refs #177.
Problem and scope
Serial and concurrent expert-cache loads can agree while sharing the same byte-placement error. This source-only amendment extends the existing
weight-loading-optimizationowner with an operational reference and an ordinary source-readset JSON, an entry pointer, incremental metadata and the two matrix mappings.The guidance separates buffered byte-oracle independence from shared metadata, resident bytes from unpublished asynchronous misses, ordered caller accumulation from read completion order, and actual production callback coverage from a test wired only to synchronous access. It retains direct/buffered dispatch, reader-pool fallback, partial-I/O failure, cleanup and tiny-fixture limits.
Fixed source and provenance
d0402056d0da4bf7edfd2d4977de479a0db9d201.8b290275cd757ae9baa3d7e75f98e8283846853dprecedes native G/Hfd7f8bad0a97b1f7e398a1cf6a494fefbf853ae2, preserving actual main2baebf6ebb815ebf07d21c41e3b3754858c0798e. The six manual paths and 81 producer-generated paths introduce no new skill, registry entry, runtime, schema, backend or test implementation. Pending Xe-Forge content is not imported.Validation and limits
6c1ea6fb82db36a0fefffea82e006159ca9654f6has main/H parents and exactly H's tree.tests/test_skill_library.pyandtests/test_skill_index.pytimed out after 900.58 seconds without a completed summary. It remains incomplete and was not rerun. The complete suite evidence above comes from hosted Python 3.10 and 3.11 at the same H tree.Knowledge remains candidate/not_run and efficacy remains not_evaluated. The source's C/cache/model tests were inspected as definitions, not executed. No upstream suite, model/device execution, benchmark, service/quality experiment or paid model trial was run. An exit-zero missing-fixture SKIP, synthetic-reference agreement or source/package consistency does not establish full-model correctness or empirical benefit.
Knowledge authorship declaration