Repository navigation
third-party:glad: ignore pedantic directive for sensitive code - #11395
Merged
Merged
Conversation
ISO C forbids conversion of object pointer to function pointer type Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
Collaborator
|
Retriggered libci for jetson and it passed |
Nir-Az
reviewed
Feb 5, 2023
| PFNGLOBJECTPTRLABELKHRPROC glad_glObjectPtrLabelKHR = NULL; | ||
| PFNGLGETOBJECTPTRLABELKHRPROC glad_glGetObjectPtrLabelKHR = NULL; | ||
| PFNGLGETPOINTERVKHRPROC glad_glGetPointervKHR = NULL; | ||
| #pragma GCC diagnostic push |
Collaborator
There was a problem hiding this comment.
- This is a great initiative
- This warning is on Linux only - lets wrap the lines with
#if defined __linux__ && #endif - Lets also add a notice that we manually change this auto generated file to avoid compiler warnings
Signed-off-by: Dmitry Perchanov <dmitry.perchanov@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ISO C forbids conversion of object pointer to function pointer type
Signed-off-by: Dmitry Perchanov dmitry.perchanov@intel.com