Repository navigation
Legacy live test - Units transform test - #11880
Merged
Merged
Conversation
Nir-Az
reviewed
Jun 11, 2023
| @@ -0,0 +1,100 @@ | |||
| # License: Apache 2.0. See LICENSE file in root directory. | |||
Collaborator
There was a problem hiding this comment.
I suggest not to have a single file with all the test.
Lets make a test file for every test group.
This way if some tests will be unstable it will state the name and you will know exactly which one without investigating each time
Nir-Az
reviewed
Jun 11, 2023
| depth_distance = ut.process(f) | ||
|
|
||
| origin_frame = np.hstack(np.asarray(f.get_data(), dtype=np.uint16)) | ||
| ut_frame = np.hstack(np.asarray(depth_distance.get_data())).view(dtype=np.float32) |
Collaborator
There was a problem hiding this comment.
What?? :)
It was solved without needing to change the wrapper code??
Nir-Az
reviewed
Jun 15, 2023
|
|
||
| temp_dir = tempfile.gettempdir() | ||
| log_filename = os.path.join(temp_dir, 'port_legacy.log') | ||
| rs.log_to_file(rs.log_severity.debug, 'port_legacy.log') |
Collaborator
There was a problem hiding this comment.
Why do we need to log to a file?
Maybe those 3 lines are not necessary?
…brealsense into legacy_live_test_ut
Nir-Az
approved these changes
Jun 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LRS-683