Skip to content

Cherry pick PR#12162-rs-hdr fix for d457 - #12164

Merged
Nir-Az merged 2 commits into
realsenseai:R/2542from
Nir-Az:hdr_example
Sep 5, 2023
Merged

Nir-Az merged 2 commits into
realsenseai:R/2542from
Nir-Az:hdr_example

Conversation

@Nir-Az

@Nir-Az Nir-Az commented Sep 4, 2023

Copy link
Copy Markdown
Collaborator

Tracked on [DSO-19116]

@Nir-Az
Nir-Az requested a review from maloel September 4, 2023 13:00
Comment thread src/proc/hdr-merge.cpp Outdated
// checking frame counter of first depth and ir are the same
if (use_ir)
{
// on devices that does not support meta data on IR frames, do not use IR for hdr merging

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does -> do

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice if it explained which devices did or did not support metadata on IR frames...

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add to development too, no back merge is planned right?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right

@maloel maloel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@Nir-Az
Nir-Az merged commit f9f1f14 into realsenseai:R/2542 Sep 5, 2023
@Nir-Az
Nir-Az deleted the hdr_example branch September 30, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants