Repository navigation
try to fix global timestamp mapping issue when HW timestamp is rollback to 0 - #12451
Merged
remibettan merged 1 commit intoJul 28, 2024
Merged
Conversation
remibettan
approved these changes
Jul 28, 2024
remibettan
left a comment
remibettan
left a comment
Contributor
There was a problem hiding this comment.
Behavior of global timestamp on hardware timestamp rollback is improved by this change.
Great catch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HW timestamp is 32bit.
when the HW timestamp is rollbacked to 0 from 2^32, the global timestamp may drift a little in about 1 second.
the value of _base_sample._x is copied from the HW timestamp.
the value of _base_sample._y is host timestamp.
when the HW timestamp is rollback, _x should be changed.