Repository navigation
[Viewer] Option Open/Close dashboard area - #12636
Merged
OhadMeir merged 5 commits intoFeb 8, 2024
Merged
Conversation
The for loop is surrounded by an if statement that prevents dashboard drawing until the dashboard is fully open.
Nir-Az
reviewed
Feb 6, 2024
| static const char* last_calib_notice{ "viewer_model.last_calib_notice" }; | ||
| static const char* is_measuring{ "viewer_model.is_measuring" }; | ||
| static const char* output_open{ "viewer_model.output_open" }; | ||
| static const char* dashboard_open{ "viewer_model.dashbord_open" }; |
Nir-Az
reviewed
Feb 6, 2024
| search_line = config_file::instance().get_or_default( | ||
| configurations::viewer::search_term, std::string("")); | ||
| is_dashboard_open = config_file::instance().get_or_default( | ||
| configurations::viewer::dashboard_open, true ); |
Contributor
Author
There was a problem hiding this comment.
Sorry, I can't find the issue here.
OhadMeir
reviewed
Feb 7, 2024
|
|
||
| auto size = ImGui::CalcTextSize(name.c_str()); | ||
| ImGui::SetCursorPos(ImVec2( r.w / 2 - size.x / 2, 5 )); | ||
| auto collapse_buton_h = 28 + 3; |
Contributor
There was a problem hiding this comment.
What is 28 and what is 3?
Is it the same 3 used on line 1050 ImGui::SetCursorPosY( 3.f + collapse_buton_h );
Contributor
Author
There was a problem hiding this comment.
- 28 is the button size. It was declared in another function. Should we do it global for 1 usage only?
I can add a comment that explains what is 28.
- 3 is a space, it does not add a significant difference. I can remove it
Contributor
There was a problem hiding this comment.
Just add a comment // Dashboard button size plus some spacing
OhadMeir
reviewed
Feb 7, 2024
Type of button changed to float Comment added
OhadMeir
approved these changes
Feb 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked on [LRS-1021]
