Repository navigation
Extended HWM - Reuse first chunk - #12693
Merged
Merged
Conversation
remibettan
reviewed
Feb 22, 2024
| // in the future the FW should send chunk 1 in 0/0 command and then we can use it here. | ||
| // meaning remove the 'clear' and start the loop from 1 | ||
|
|
||
| recv_msg.clear(); |
Contributor
There was a problem hiding this comment.
you removed the clear command
So the received message on the second call with be appended after the first one - according to the title of this PR, it seems this was your aim, but please explain.
Collaborator
Author
There was a problem hiding this comment.
Yes, as you know, we have 2 use cases.
- HMC < 1000 bytes
We append the full message to recv_msg and skip the next loop - HMC > 1000 bytes
- _We append the first chunk message to recv_msg, then step into the loop and append chunk 1 - (num_of_chunks - 1) _
Sounds OK?
Nir-Az
marked this pull request as draft
February 22, 2024 11:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continue #12682