Repository navigation
Fixing Y12i stream output in MIPI with CUDA case - #13084
Conversation
There was a problem hiding this comment.
The code for mipi and not pipi is exactly the same - the only difference is the padding of 8 bits that has been added for mipi.
Few questions:
Is the other padding used anywhere? (y16_y16_from_y12i)?
If no - please remove it, and keep only the mipi one.
If yes - since the code is exactly the same besides the type used (y12i_pixel or y12i_pixel_mipi), could you change it to a template function that would be used for both cases (once with the y12i_pixel type, and once with the y12i_pixel_mipi type)?
@remibettan, UVC with CUDA must be using |
| */ | ||
| } | ||
|
|
||
| template void rscuda::y16_y16_from_y12i_10_cuda_helper<rscuda::y12i_pixel_mipi>(uint8_t* const dest[], int count, const rscuda::y12i_pixel_mipi * source); |
There was a problem hiding this comment.
As we talked, please delete this line and the above line, and see next comment
| auto count = width * height; | ||
| #ifdef RS2_USE_CUDA | ||
| rscuda::split_frame_y16_y16_from_y12i_cuda_mipi(dest, count, reinterpret_cast<const y12i_pixel_mipi *>(source)); | ||
| rscuda::split_frame_y16_y16_from_y12i_cuda(dest, count, reinterpret_cast<const rscuda::y12i_pixel_mipi *>(source)); |
There was a problem hiding this comment.
Instead of :rscuda::split_frame_y16_y16_from_y12i_cuda(dest, count, reinterpret_cast<const rscuda::y12i_pixel_mipi *>(source));
Please try:
rscuda::split_frame_y16_y16_from_y12i_cuda<rscuda::y12i_pixel_mipi *>(dest, count, reinterpret_cast<const rscuda::y12i_pixel_mipi *>(source));
| auto count = width * height; | ||
| #ifdef RS2_USE_CUDA | ||
| rscuda::split_frame_y16_y16_from_y12i_cuda(dest, count, reinterpret_cast<const y12i_pixel *>(source)); | ||
| rscuda::split_frame_y16_y16_from_y12i_cuda(dest, count, reinterpret_cast<const rscuda::y12i_pixel *>(source)); |
There was a problem hiding this comment.
Intead of:
rscuda::split_frame_y16_y16_from_y12i_cuda(dest, count, reinterpret_cast<const rscuda::y12i_pixel *>(source));
Please try:
rscuda::split_frame_y16_y16_from_y12i_cuda<rscuda::y12i_pixel *>(dest, count, reinterpret_cast<const rscuda::y12i_pixel *>(source));
remibettan
left a comment
remibettan
left a comment
There was a problem hiding this comment.
please see inline comments
Tracked by LRS-1052