Repository navigation
Add missing constants & fixed 6fps bug for live/FPS weekly CI - #14327
Conversation
|
@Nir-Az , please review and merge |
There was a problem hiding this comment.
Pull Request Overview
This PR addresses timing and measurement issues in the FPS performance testing system for Intel RealSense cameras. The changes improve test reliability for low FPS scenarios (particularly 6 FPS) and add better configuration management for CI environments.
- Added constants for device initialization timeouts and minimum frame count thresholds
- Fixed measurement intervals for very low FPS tests (≤6 FPS) to improve data collection
- Added a utility function for human-readable duration formatting
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@ttkhuong once the CI is passing you can add Nir A. to review no need to tag him. |
Nir-Az
left a comment
Nir-Az
left a comment
There was a problem hiding this comment.
Once Yogev approve we can merge
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| if min_fps <= 6: | ||
| warmup_frames = 2 # Reduced from 3 | ||
| measurement_interval = 3 | ||
| measurement_interval = 2 |
There was a problem hiding this comment.
This hardcoded value conflicts with the measurement_interval = 1 pattern established for very low FPS (≤6) in the single stream test function above. For consistency and to apply the same 6fps bug fix, this should also be set to 1.
| measurement_interval = 2 | |
| measurement_interval = 1 |
No description provided.