Skip to content

Fix format-security warnings (again) - #4721

Merged
dorodnic merged 2 commits into
realsenseai:developmentfrom
morxa:format-security-2
Aug 27, 2019
Merged

dorodnic merged 2 commits into
realsenseai:developmentfrom
morxa:format-security-2

Conversation

@morxa

@morxa morxa commented Aug 25, 2019

Copy link
Copy Markdown
Contributor

Use string literals in all format strings and cast to char * if necessary. Also include -Wformat, which is necessary if you want to use -Wformat-security.

See also #915 that did something similar.

@dorodnic

Copy link
Copy Markdown
Contributor

Hi @morxa
Thank you, again, we will try to avoid these in the future

@dorodnic
dorodnic merged commit f700d9a into realsenseai:development Aug 27, 2019
@morxa

morxa commented Aug 28, 2019

Copy link
Copy Markdown
Contributor Author

Thanks for merging! With the -Wformat fix, everyone should hopefully notice the problem earlier :)

@morxa
morxa deleted the format-security-2 branch August 28, 2019 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants