Repository navigation
HDR merge - discarding merged frame on resume - #9498
Merged
ev-mp merged 3 commits intoAug 3, 2021
Merged
Conversation
remibettan
force-pushed
the
hdr-merge-clean-after-hdr-stop
branch
from
July 27, 2021 06:14
628a9ad to
a740aac
Compare
ev-mp
requested changes
Aug 2, 2021
|
|
||
| bool frame_metadata_not_enabled = false; | ||
|
|
||
| if (!frame_metadata_not_enabled) |
Contributor
There was a problem hiding this comment.
The variable is used with double negation - maybe it should be renamed to metadata_is_present for clarity?
| REQUIRE(depth_sensor.get_option(RS2_OPTION_HDR_ENABLED) == 0.f); | ||
|
|
||
| if (!frame_metadata_not_enabled) | ||
| if (!stream_frames(pipe, 10, merging_filter)) |
Contributor
There was a problem hiding this comment.
The frame counter, 10, must be bigger than the internal threshold - I would recommend to make it 30-50 frames.
Also, there is no need to double-check for metadata as it is determined in the first iteration.
Can be skipped here and below
Contributor
Author
There was a problem hiding this comment.
if metadata is not enabled, the commands within the if statement need to be skipped. So, this flag must remain.
| } | ||
| } | ||
|
|
||
| bool stream_frames(rs2::pipeline& pipe, int num_of_frames, rs2::hdr_merge& merging_filter) |
remibettan
force-pushed
the
hdr-merge-clean-after-hdr-stop
branch
from
August 2, 2021 12:09
a740aac to
9936be2
Compare
remibettan
force-pushed
the
hdr-merge-clean-after-hdr-stop
branch
from
August 3, 2021 08:59
9936be2 to
1319324
Compare
ev-mp
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracked by: DSO-17341