Skip to content

feat(solana): align security scan contract, banners, and blockhash expiry - #617

Open
taran-a wants to merge 2 commits into
feat/solana-acknowledgement-interface-lockfrom
feat/solana-security-scan-and-expiry
Open

taran-a wants to merge 2 commits into
feat/solana-acknowledgement-interface-lockfrom
feat/solana-security-scan-and-expiry

Conversation

@taran-a

@taran-a taran-a commented Nov 16, 2026

Copy link
Copy Markdown
Contributor

Explanation

This is the last PR in a three-PR stack for Solana transaction confirmations. The earlier PRs cover the copy alignment and the malicious acknowledgement screen with the interface lock. This PR aligns the scan result contract, the banners, and the expiry handling with the shared transaction warning contract.

Scan result contract (TransactionScanService)

  • error now describes only simulation failures: an execution failure, or a requested simulation with no result.
  • validationError is new and describes failures of the security scan itself: a validation Error, an overall response error, or a requested validation with no verdict.
  • status is ERROR only when the security scan failed.
  • estimatedChanges is null when the simulation failed or is missing, so the UI shows "not available" instead of "no changes".
  • TransactionScanError gains message, and type is 'simulation' | 'validation' | 'response' | null.
  • Scan completed and scan failed analytics events are sent only when a validation was requested. A simulation-only scan is no longer reported as a security scan.

Banners

  • New SecurityScanAlert shows the security verdict. When the scan request or the validation fails, it shows an info "Security check unavailable" banner.
  • New TransactionFailureAlert shows a simulation failure as a warning, or local expiry as a danger banner.
  • Security and simulation banners can show together. When the transaction has expired, only the expiry banner shows.
  • getErrorMessage falls back to the API's message for unmapped codes, before the generic unknown-error copy.

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

@taran-a
taran-a added this pull request to stack #616 November 16, 2026 18:42
@taran-a
taran-a requested a review from a team as a code owner November 16, 2026 18:42
@taran-a
taran-a requested review from a team as code owners November 16, 2026 18:42
@taran-a
taran-a force-pushed the feat/solana-security-scan-and-expiry branch from 7617d8e to 3eb71ca Compare November 16, 2026 18:44
@taran-a
taran-a force-pushed the feat/solana-security-scan-and-expiry branch 5 times, most recently from 6acdb0b to bc9b9a4 Compare November 17, 2026 14:59
@taran-a
taran-a force-pushed the feat/solana-security-scan-and-expiry branch from bc9b9a4 to b6c620f Compare November 17, 2026 17:01
@taran-a
taran-a requested a review from Julink-eth November 17, 2026 17:24
@sonarqubecloud

Copy link
Copy Markdown

This branch was previously deployed

1 inactive (outdated) deployment
default-branch — 7617d8e1 Deployed Nov 16, 2026 by taran-a via Determine whether this PR is a release PR #2374
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants