Repository navigation
Conversation
taran-a
temporarily deployed
to
default-branch
November 16, 2026 18:43 — with
GitHub Actions
Inactive
taran-a
force-pushed
the
feat/solana-security-scan-and-expiry
branch
from
November 16, 2026 18:44
7617d8e to
3eb71ca
Compare
taran-a
force-pushed
the
feat/solana-security-scan-and-expiry
branch
5 times, most recently
from
November 17, 2026 14:59
6acdb0b to
bc9b9a4
Compare
Julink-eth
reviewed
Nov 17, 2026
taran-a
force-pushed
the
feat/solana-security-scan-and-expiry
branch
from
November 17, 2026 17:01
bc9b9a4 to
b6c620f
Compare
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Explanation
This is the last PR in a three-PR stack for Solana transaction confirmations. The earlier PRs cover the copy alignment and the malicious acknowledgement screen with the interface lock. This PR aligns the scan result contract, the banners, and the expiry handling with the shared transaction warning contract.
Scan result contract (
TransactionScanService)errornow describes only simulation failures: an execution failure, or a requested simulation with no result.validationErroris new and describes failures of the security scan itself: a validationError, an overall response error, or a requested validation with no verdict.statusisERRORonly when the security scan failed.estimatedChangesisnullwhen the simulation failed or is missing, so the UI shows "not available" instead of "no changes".TransactionScanErrorgainsmessage, andtypeis'simulation' | 'validation' | 'response' | null.Banners
SecurityScanAlertshows the security verdict. When the scan request or the validation fails, it shows an info "Security check unavailable" banner.TransactionFailureAlertshows a simulation failure as a warning, or local expiry as a danger banner.getErrorMessagefalls back to the API's message for unmapped codes, before the generic unknown-error copy.References
Checklist