Repository navigation
Commit 27e67db
chore(home): remove unused home class selectors (#47675)
## **Description**
Removes unused class selectors from `ui/pages/home/index.scss`. Owner
set: `@MetaMask/core-extension-ux`.
No component, HTML file, test, snapshot, story, or e2e selector applies
these classes, and no stylesheet `@extend`s them. The tooltip theme rule
is also dead: no `Tooltip` passes a `home__subheader-link--tooltip`
theme, so react-tippy never adds `home__subheader-link--tooltip-theme`.
The `.tippy-tooltip-content` and `.arrow-regular` rules nested under it
go with it. Live siblings (`home__connected-status-popover`,
`home__new-network-notification`, and
`home__new-tokens-imported-notification` with `-title`, `-message`,
`-icon`) are kept.
| path | removed | why dead |
| --- | --- | --- |
| `ui/pages/home/index.scss` | `.home__connected-status-popover-bg`,
`.home__connected-status-popover-bg-container` | unused class selector |
| `ui/pages/home/index.scss` | `.home__new-network-notification-icon`,
`.home__new-network-notification-close` | unused class selector |
| `ui/pages/home/index.scss` | `.home__error-message` | unused class
selector |
| `ui/pages/home/index.scss` |
`.home__new-tokens-imported-notification-close` | unused class selector
|
| `ui/pages/home/index.scss` | `.home__new-network-added` (+
`__check-circle`, `__switch-to-button`) | unused class selector |
| `ui/pages/home/index.scss` | `.home__subheader-link` (+
`--tooltip-content*`, `--tooltip-theme`, `--text`) | unused class
selector |
No user-facing behavior change.
Checks: `yarn lint:styles`, Sass compile of the file, `yarn test:unit
--coverage=false ui/pages/home` (no snapshot updates). No JS/TS changed,
so `yarn lint:tsc` and ESLint were not needed.
Docs/comments updated: none
## **Changelog**
CHANGELOG entry: null
## **Related issues**
Refs: proactive dead-code cleanup (extension counterpart of
metamask-mobile#37948)
## **Manual testing steps**
N/A — deletes unreachable code. There is no user-facing behavior to
click through.
## **Screenshots/Recordings**
N/A — no UI change
### **Before**
N/A — no UI change
### **After**
N/A — no UI change
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> CSS-only deletion of unreachable selectors; no JS/TS or markup
changes.
>
> **Overview**
> Removes **dead SCSS** from `ui/pages/home/index.scss`—roughly 150
lines of class rules that nothing in the extension references (no
JSX/HTML, tests, or `@extend`).
>
> Dropped blocks include connected-status popover background wrappers,
notification icon/close variants, `home__error-message`, the “new
network added” success panel styles, and the full `home__subheader-link`
tooltip theme subtree. **Still styled** are the live pieces called out
in the PR: `home__connected-status-popover`, the flex layout on
`home__new-network-notification`, and
`home__new-tokens-imported-notification` with `-title`, `-message`, and
`-icon`.
>
> **No user-facing or runtime change**—stylesheet size and maintenance
surface only.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
f19a568. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>1 parent e4e3333 commit 27e67db
1 file changed
Lines changed: 0 additions & 106 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
89 | 89 | | |
90 | 90 | | |
91 | 91 | | |
92 | | - | |
93 | | - | |
94 | | - | |
95 | | - | |
96 | | - | |
97 | | - | |
98 | | - | |
99 | | - | |
100 | | - | |
101 | | - | |
102 | | - | |
103 | | - | |
104 | | - | |
105 | | - | |
106 | | - | |
107 | | - | |
108 | 92 | | |
109 | 93 | | |
110 | 94 | | |
| |||
122 | 106 | | |
123 | 107 | | |
124 | 108 | | |
125 | | - | |
126 | | - | |
127 | | - | |
128 | | - | |
129 | | - | |
130 | | - | |
131 | | - | |
132 | | - | |
133 | | - | |
134 | | - | |
135 | | - | |
136 | | - | |
137 | | - | |
138 | | - | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | 109 | | |
144 | 110 | | |
145 | 111 | | |
| |||
167 | 133 | | |
168 | 134 | | |
169 | 135 | | |
170 | | - | |
171 | | - | |
172 | | - | |
173 | | - | |
174 | | - | |
175 | | - | |
176 | | - | |
177 | | - | |
178 | | - | |
179 | | - | |
180 | | - | |
181 | | - | |
182 | | - | |
183 | | - | |
184 | | - | |
185 | | - | |
186 | | - | |
187 | | - | |
188 | | - | |
189 | | - | |
190 | | - | |
191 | | - | |
192 | | - | |
193 | | - | |
194 | | - | |
195 | | - | |
196 | | - | |
197 | | - | |
198 | | - | |
199 | | - | |
200 | | - | |
201 | | - | |
202 | | - | |
203 | | - | |
204 | | - | |
205 | | - | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | | - | |
212 | | - | |
213 | | - | |
214 | | - | |
215 | | - | |
216 | | - | |
217 | | - | |
218 | | - | |
219 | | - | |
220 | | - | |
221 | | - | |
222 | | - | |
223 | | - | |
224 | | - | |
225 | | - | |
226 | | - | |
227 | | - | |
228 | | - | |
229 | | - | |
230 | | - | |
231 | | - | |
232 | | - | |
233 | | - | |
234 | | - | |
235 | | - | |
236 | | - | |
237 | | - | |
238 | | - | |
239 | | - | |
240 | | - | |
241 | | - | |
242 | 136 | | |
243 | 137 | | |
0 commit comments