Repository navigation
Commit 4e9f82d
authored
chore: upgrade phishing-warning to 6.0.0 (#47666)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Updates `phishing-warning` to 6.0.0 with several minor fixes.
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: phishing-warning changelog
https://github.com/MetaMask/phishing-warning/releases/tag/v6.0.0
## **Related issues**
Fixes:
https://consensyssoftware.atlassian.net/browse/PSAFE-782?xpis=eyJicmlkZ2UiOiJxdWlja0ZpbmQiLCJpZCI6IjE3OTM5MTM0OTAyNjgiLCJzb3VyY2UiOiJqaXJhLXNvZnR3YXJlIn0%3D
## **Manual testing steps**
1. Navigate to `metamask.org` (fake MetaMask website)
2. Observe phishing warning page
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **After**
<img width="959" height="720" alt="image"
src="https://github.com/user-attachments/assets/1c3ab634-d3d0-43e2-917b-2496ef985fd1"
/>
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes the user-facing phishing block/warning experience via a major
package bump and new default hosted page version, though extension logic
is unchanged.
>
> **Overview**
> Bumps the dev dependency **`@metamask/phishing-warning`** from
**5.1.0** to **6.0.0** and refreshes **`yarn.lock`**. There are **no
extension source changes**—only the dependency pin and lockfile.
>
> The new release pulls in **`@metamask/design-tokens` ^8.0.0**
(resolved to **8.7.0**) instead of the prior **7.x** line used by v5.
Because the build already sets the default phishing warning page URL
from **`@metamask/phishing-warning/package.json`**, production builds
will target **`https://metamask.github.io/phishing-warning/v6.0.0/`**
unless **`PHISHING_WARNING_PAGE_URL`** is overridden; e2e still serves
the package **`dist`** from **`node_modules`**.
>
> Reviewers should treat this as adopting **v6’s warning-page
UI/behavior** from the upstream package (the PR screenshot reflects that
visual update) and confirm the hosted **v6.0.0** page is available where
needed.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
509255b. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 7392fdf commit 4e9f82d
2 files changed
Lines changed: 11 additions & 11 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
669 | 669 | | |
670 | 670 | | |
671 | 671 | | |
672 | | - | |
| 672 | + | |
673 | 673 | | |
674 | 674 | | |
675 | 675 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8113 | 8113 | | |
8114 | 8114 | | |
8115 | 8115 | | |
8116 | | - | |
8117 | | - | |
8118 | | - | |
8119 | | - | |
| 8116 | + | |
| 8117 | + | |
| 8118 | + | |
| 8119 | + | |
8120 | 8120 | | |
8121 | 8121 | | |
8122 | 8122 | | |
| |||
9848 | 9848 | | |
9849 | 9849 | | |
9850 | 9850 | | |
9851 | | - | |
9852 | | - | |
9853 | | - | |
| 9851 | + | |
| 9852 | + | |
| 9853 | + | |
9854 | 9854 | | |
9855 | | - | |
| 9855 | + | |
9856 | 9856 | | |
9857 | 9857 | | |
9858 | 9858 | | |
9859 | 9859 | | |
9860 | 9860 | | |
9861 | 9861 | | |
9862 | | - | |
| 9862 | + | |
9863 | 9863 | | |
9864 | 9864 | | |
9865 | 9865 | | |
| |||
35597 | 35597 | | |
35598 | 35598 | | |
35599 | 35599 | | |
35600 | | - | |
| 35600 | + | |
35601 | 35601 | | |
35602 | 35602 | | |
35603 | 35603 | | |
| |||
0 commit comments