Skip to content

Commit 4e9f82d

Browse files
authored
chore: upgrade phishing-warning to 6.0.0 (#47666)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Updates `phishing-warning` to 6.0.0 with several minor fixes. <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: phishing-warning changelog https://github.com/MetaMask/phishing-warning/releases/tag/v6.0.0 ## **Related issues** Fixes: https://consensyssoftware.atlassian.net/browse/PSAFE-782?xpis=eyJicmlkZ2UiOiJxdWlja0ZpbmQiLCJpZCI6IjE3OTM5MTM0OTAyNjgiLCJzb3VyY2UiOiJqaXJhLXNvZnR3YXJlIn0%3D ## **Manual testing steps** 1. Navigate to `metamask.org` (fake MetaMask website) 2. Observe phishing warning page ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **After** <img width="959" height="720" alt="image" src="https://github.com/user-attachments/assets/1c3ab634-d3d0-43e2-917b-2496ef985fd1" /> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Changes the user-facing phishing block/warning experience via a major package bump and new default hosted page version, though extension logic is unchanged. > > **Overview** > Bumps the dev dependency **`@metamask/phishing-warning`** from **5.1.0** to **6.0.0** and refreshes **`yarn.lock`**. There are **no extension source changes**—only the dependency pin and lockfile. > > The new release pulls in **`@metamask/design-tokens` ^8.0.0** (resolved to **8.7.0**) instead of the prior **7.x** line used by v5. Because the build already sets the default phishing warning page URL from **`@metamask/phishing-warning/package.json`**, production builds will target **`https://metamask.github.io/phishing-warning/v6.0.0/`** unless **`PHISHING_WARNING_PAGE_URL`** is overridden; e2e still serves the package **`dist`** from **`node_modules`**. > > Reviewers should treat this as adopting **v6’s warning-page UI/behavior** from the upstream package (the PR screenshot reflects that visual update) and confirm the hosted **v6.0.0** page is available where needed. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 509255b. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent 7392fdf commit 4e9f82d

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -669,7 +669,7 @@
669669
"@metamask/foundryup": "^1.0.1",
670670
"@metamask/java-tron-up": "^1.0.0",
671671
"@metamask/messenger-cli": "^0.2.0",
672-
"@metamask/phishing-warning": "^5.1.0",
672+
"@metamask/phishing-warning": "^6.0.0",
673673
"@metamask/platform-api-docs": "^0.2.1",
674674
"@metamask/preferences-controller": "^23.0.0",
675675
"@metamask/skills": "^0.3.1",

‎yarn.lock‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -8113,10 +8113,10 @@ __metadata:
81138113
languageName: node
81148114
linkType: hard
81158115

8116-
"@metamask/design-tokens@npm:^7.1.0":
8117-
version: 7.1.0
8118-
resolution: "@metamask/design-tokens@npm:7.1.0"
8119-
checksum: 10/a4f1379bdf5f6b99c9a228ce4f5bb07ace4ed5abc61384e7f04cf5bdf943b32dd13ec9676a88f6b6c7314cdba6e2967b9fd99707a64a645865f21f8d8a2566d9
8116+
"@metamask/design-tokens@npm:^8.0.0":
8117+
version: 8.7.0
8118+
resolution: "@metamask/design-tokens@npm:8.7.0"
8119+
checksum: 10/5fa880ef16c2225d378a3dddf6e73b5b260cdd49722337ab894228df33b905042279252da52c5634897cbd2beb81bd93f7dda7cbb2dd94f17c2bd0aa3e6d1295
81208120
languageName: node
81218121
linkType: hard
81228122

@@ -9848,18 +9848,18 @@ __metadata:
98489848
languageName: node
98499849
linkType: hard
98509850

9851-
"@metamask/phishing-warning@npm:^5.1.0":
9852-
version: 5.1.0
9853-
resolution: "@metamask/phishing-warning@npm:5.1.0"
9851+
"@metamask/phishing-warning@npm:^6.0.0":
9852+
version: 6.0.0
9853+
resolution: "@metamask/phishing-warning@npm:6.0.0"
98549854
dependencies:
9855-
"@metamask/design-tokens": "npm:^7.1.0"
9855+
"@metamask/design-tokens": "npm:^8.0.0"
98569856
"@metamask/object-multiplex": "npm:^2.0.0"
98579857
"@metamask/post-message-stream": "npm:^8.0.0"
98589858
eth-phishing-detect: "npm:^1.2.0"
98599859
punycode: "npm:^2.3.1"
98609860
readable-stream: "npm:^3.6.2"
98619861
ses: "npm:^1.1.0"
9862-
checksum: 10/64c01a4a9ec1b6604f8ea532673b0f71d2884c543fc6daad2b3d5395599373f90a4dd220195da7b58f1b98202b546b6f8f7e67091e1543237f04589c933bb840
9862+
checksum: 10/2f50321cdf7fa89da8134dc6b5e6347cf6df5a786673986bdb148be5fe7bbe3c7c0de689bbe8b2d463387c9b2d3fef57132cb81ef6c8dcc07ae4c31146aa0c0c
98639863
languageName: node
98649864
linkType: hard
98659865

@@ -35597,7 +35597,7 @@ __metadata:
3559735597
"@metamask/permissions-kernel-snap": "npm:^1.3.0"
3559835598
"@metamask/perps-controller": "npm:^22.1.1"
3559935599
"@metamask/phishing-controller": "npm:^18.2.1"
35600-
"@metamask/phishing-warning": "npm:^5.1.0"
35600+
"@metamask/phishing-warning": "npm:^6.0.0"
3560135601
"@metamask/platform-api-docs": "npm:^0.2.1"
3560235602
"@metamask/polling-controller": "npm:^16.0.7"
3560335603
"@metamask/post-message-stream": "npm:^10.0.0"

0 commit comments

Comments
 (0)