Repository navigation
Commit 58e30f8
feat: update Perps withdraw transaction fee tooltip copy (#47723)
<!-- CURSOR_AGENT_PR_BODY_BEGIN -->
## **Description**
The MetaMask fee no longer applies to any withdrawal. On the Perps
withdraw confirmation, the Transaction fee tooltip still said no
MetaMask fee applies when you swap to mUSD, which suggests other
withdrawals still pay one. Mobile already shipped the same copy change.
This drops that sentence, so the tooltip now reads "MetaMask will swap
to your desired token for you." The English copy is updated in `en` and
`en_GB`. The 14 translated locales had the same two sentences, so only
the translated mUSD sentence is removed there. The first sentence is
unchanged, and Crowdin will sync any further wording changes.
**Decisions to confirm**
- [ ] Removed the mUSD sentence from the 14 translated locales (as the
Perps copy fix in #42435 did), instead of leaving the outdated sentence
until the next Crowdin sync.
## **Changelog**
CHANGELOG entry: Removed outdated mUSD fee wording from the Perps
withdraw transaction fee tooltip
## **Related issues**
Fixes: CONF-2232
## **Manual testing steps**
1. Run the extension with Perps enabled and open Perps with an account
that has a Perps balance.
2. Start a withdrawal, enter an amount, and pick a receive token so a
fee quote loads.
3. On the withdraw confirmation, click the question-mark icon next to
Transaction fee.
4. Verify the tooltip starts with "MetaMask will swap to your desired
token for you." and no longer mentions mUSD.
5. Switch the browser language to a translated locale (for example
German), repeat steps 2-3, and verify the tooltip no longer mentions
mUSD.
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_AGENT_PR_BODY_END -->
<div><a
href="https://cursor.com/agents/bc-f88e57dd-e2fe-57a7-9796-8461bf39ab29?cursor_ref=pr_footer&cursor_cta=open_in_web"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-web-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-web-light.png"><img
alt="Open in Web" width="114" height="28"
src="https://cursor.com/assets/images/open-in-web-dark.png"></picture></a> <a
href="https://cursor.com/background-agent?bcId=bc-f88e57dd-e2fe-57a7-9796-8461bf39ab29&cursor_ref=pr_footer&cursor_cta=open_in_cursor"><picture><source
media="(prefers-color-scheme: dark)"
srcset="https://cursor.com/assets/images/open-in-cursor-dark.png"><source
media="(prefers-color-scheme: light)"
srcset="https://cursor.com/assets/images/open-in-cursor-light.png"><img
alt="Open in Cursor" width="131" height="28"
src="https://cursor.com/assets/images/open-in-cursor-dark.png"></picture></a> </div>
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> String-only i18n updates on a tooltip; no behavioral or fee logic
changes.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
cd22a08. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: Daniel <dan437@users.noreply.github.com>1 parent 5fefd9d commit 58e30f8
16 files changed
Lines changed: 16 additions & 16 deletions
File tree
- app/_locales
- de
- el
- en_GB
- en
- es_419
- fr
- hi
- id
- ja
- ko
- pt
- ru
- tl
- tr
- vi
- zh_CN
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments