Skip to content

Commit 63d44a1

Browse files
github-actions[bot]LeVinhGithubcursoragent
authored
test: Sync Feature Flag Registry - 2026-10-27 01:21 UTC (#47373)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** **Root cause:** - Custom RPC history opens Add network and clicks the RPC dropdown before typing a name. - Chainlist v2 opens network suggestions on that empty form, and those rows cover the RPC dropdown. - Increase allowance and revoke allowance confirm a spend cap, then click the confirmed activity row. - The transaction confirmed toast stays on screen, and its link covers that row. - Request queuing confirms a send, then expects the home activity list. - That same toast link is open on the transaction details route, so the home activity list is not on screen. - A fresh default wallet now creates a Money account on unlock, while the committed fixture vault does not include the Money keyring yet. - The default fixture records `defaultMoneyAccountId` as null. Unlock with the Money account flag sets that field to the new account id, so the dist fixture check sees a string. - Solana swap tests have no local chain. Money account setup adds Monad, Infura is redirected, and the primary RPC fails over to QuickNode. - CHOMP's synced base URL is already `chomp.api.cx.metamask.io`, which the privacy snapshot already lists. **Solution:** - Set `extensionUxChainlistV2`, `moneyEnableMoneyAccount`, `moneyHomeScreenCardEnabled`, `moneyAccountGeoBlockedCountries`, and `moneyAccountChompConfig` to the 2026-10-27 production values - these specs now run against those defaults. - Close the Chainlist name dropdown with Escape before opening the add-RPC page - the RPC dropdown can be clicked. - Close the transaction confirmed toast with its close button before clicking the confirmed activity row - the row is no longer covered. - On the request-queuing send, close that toast and leave transaction details when the details route is open, then count the confirmed activity row. - Ignore `data.MoneyAccountController.moneyAccounts` and `data.MoneyAccountController.defaultMoneyAccountId` in fixture schema validation alongside `KeyringController.vault` and `AccountsController.internalAccounts.accounts` - unlock sets the default id to a string, and fresh wallet validation still passes while tests create the Money keyring on unlock. - Set `corePlatformRpcFailoverMode` to `disabled` in the Solana swap flag mock, the same way the Bitcoin and Tron tests do - Monad does not call the QuickNode host. - Leave `chomp.dev-api.cx.metamask.io` out of the privacy snapshot - this PR's CHOMP URL and the code default are already the production host. **Related pull requests:** - #47375 ## **Changelog** CHANGELOG entry: null <!-- ## **Related issues** Fixes: --> ## **Manual testing steps** 1. Start a test build with `yarn start:test`. 2. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/tests/network/custom-rpc-history.spec.ts --debug --leave-running`. 3. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/tests/confirmations/transactions/increase-token-allowance-redesign.spec.ts --debug --leave-running`. 4. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/tests/confirmations/transactions/revoke-allowance-redesign.spec.ts --debug --leave-running`. 5. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/tests/request-queuing/dapp1-switch-dapp2-send.spec.ts --debug --leave-running`. 6. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/tests/solana/swap.spec.ts --debug --leave-running`. 7. Build dist with `yarn dist`, then run `SELENIUM_BROWSER=chrome yarn test:e2e:single test/e2e/dist/wallet-fixture-validation.spec.ts --debug --leave-running`. ## **Screenshots/Recordings** ### **Before** Add network: the Chainlist panel is open under Network name. Ethereum, Orderly Mainnet, and PrimusChain cover the form, and the click meant for the RPC dropdown hits a Chainlist row. Activity: the Transaction confirmed toast stays up over the Increased spending row, and the click hits the toast link. Request queuing lands on Sent ETH details with that toast still open, so the activity count never sees the home list. Solana swap: the home screen shows the same Money card and a Transaction submitted toast. The test then fails because Monad's QuickNode failover host is not in the privacy snapshot. ### **After** No product UI change. The add-RPC step closes the Chainlist panel first. The activity click closes the confirmed toast first. Request queuing leaves transaction details when that route is open, then counts the activity row. Fixture validation ignores the unlock-populated `moneyAccounts` map and `defaultMoneyAccountId`. Solana swap disables RPC failover instead of allowing the QuickNode host. ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Harry Le <43307514+LeVinhGithub@users.noreply.github.com> Co-authored-by: LeVinhGithub <levinh.hcmut@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent 1744cd6 commit 63d44a1

7 files changed

Lines changed: 220 additions & 32 deletions

File tree

‎test/e2e/feature-flags/feature-flag-registry.ts‎

Lines changed: 155 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export type FeatureFlagRegistryEntry = {
7676
* Remote flag values are stored in the exact format returned by the production
7777
* client-config API, so they can be served directly by mock-e2e.js.
7878
*
79-
* Production defaults last synced: 2026-10-20
79+
* Production defaults last synced: 2026-10-27
8080
* Source: https://client-config.api.cx.metamask.io/v1/flags?client=extension&distribution=main&environment=prod
8181
*/
8282
/* eslint-disable @typescript-eslint/naming-convention -- production API flag names */
@@ -105,18 +105,21 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
105105
type: FeatureFlagType.Remote,
106106
},
107107

108-
addSolanaAccount: {
108+
addressResolution: {
109109
inProd: true,
110-
name: 'addSolanaAccount',
111-
productionDefault: true,
110+
name: 'addressResolution',
111+
productionDefault: {
112+
enabled: false,
113+
minimumVersion: '13.50.0',
114+
},
112115
status: FeatureFlagStatus.Active,
113116
type: FeatureFlagType.Remote,
114117
},
115118

116-
addressResolution: {
119+
addSolanaAccount: {
117120
inProd: true,
118-
name: 'addressResolution',
119-
productionDefault: false,
121+
name: 'addSolanaAccount',
122+
productionDefault: true,
120123
status: FeatureFlagStatus.Active,
121124
type: FeatureFlagType.Remote,
122125
},
@@ -219,13 +222,14 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
219222
minimumVersion: null,
220223
},
221224
'13.37.0': {
222-
deprecatedControllers: [],
225+
deprecatedControllers: ['TokenListController'],
223226
enabled: true,
224227
featureVersion: '1',
225228
minimumVersion: '13.38.0',
226229
},
227230
'13.42.0': {
228231
deprecatedControllers: [
232+
'TokenListController',
229233
'TokenDetectionController',
230234
'TokensController',
231235
'CurrencyRateController',
@@ -242,6 +246,7 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
242246
},
243247
'13.43.0': {
244248
deprecatedControllers: [
249+
'TokenListController',
245250
'TokenDetectionController',
246251
'TokensController',
247252
'CurrencyRateController',
@@ -259,6 +264,7 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
259264
},
260265
'13.46.1': {
261266
deprecatedControllers: [
267+
'TokenListController',
262268
'TokenDetectionController',
263269
'TokensController',
264270
'CurrencyRateController',
@@ -1491,11 +1497,10 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
14911497
},
14921498

14931499
confirmations_pay_rpc: {
1494-
inProd: false,
1500+
inProd: true,
14951501
name: 'confirmations_pay_rpc',
14961502
productionDefault: {
1497-
allowedTypes: [],
1498-
dapps: {},
1503+
enabled: false,
14991504
},
15001505
status: FeatureFlagStatus.Active,
15011506
type: FeatureFlagType.Remote,
@@ -1631,78 +1636,193 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
16311636
preferredTokens: {
16321637
default: [],
16331638
overrides: {
1639+
moneyAccountDeposit: [
1640+
{
1641+
address: '0x0000000000000000000000000000000000000000',
1642+
chainId: '0x1',
1643+
name: 'ETH',
1644+
},
1645+
{
1646+
address: '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eb48',
1647+
chainId: '0x1',
1648+
name: 'USDC',
1649+
},
1650+
{
1651+
address: '0xaf88d065e77c8cC2239327C5EDb3A432268e5831',
1652+
chainId: '0xa4b1',
1653+
name: 'USDC',
1654+
},
1655+
{
1656+
address: '0xdAC17F958D2ee523a2206206994597C13D831ec7',
1657+
chainId: '0x1',
1658+
name: 'USDT',
1659+
},
1660+
{
1661+
address: '0x55d398326f99059fF775485246999027B3197955',
1662+
chainId: '0x38',
1663+
name: 'USDT',
1664+
},
1665+
{
1666+
address: '0x0000000000000000000000000000000000000000',
1667+
chainId: '0xa4b1',
1668+
name: 'ETH',
1669+
},
1670+
{
1671+
address: '0x0000000000000000000000000000000000000000',
1672+
chainId: '0x2105',
1673+
name: 'ETH',
1674+
},
1675+
{
1676+
address: '0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9',
1677+
chainId: '0xa4b1',
1678+
name: 'USDT',
1679+
},
1680+
{
1681+
address: '0x8AC76a51cc950d9822D68b83fE1Ad97B32Cd580d',
1682+
chainId: '0x38',
1683+
name: 'USDC',
1684+
},
1685+
{
1686+
address: '0x0000000000000000000000000000000000000000',
1687+
chainId: '0x38',
1688+
name: 'BNB',
1689+
},
1690+
{
1691+
address: '0x0000000000000000000000000000000000000000',
1692+
chainId: '0x89',
1693+
name: 'POL',
1694+
},
1695+
{
1696+
address: '0xe2fceAc20813592220b8C56999000d08C7844E6c',
1697+
chainId: '0x1',
1698+
name: 'MUSD',
1699+
},
1700+
{
1701+
address: '0xaca92e438df0b2401ff60da7e4337b687a2435da',
1702+
chainId: '0x1',
1703+
name: 'mUSD',
1704+
},
1705+
{
1706+
address: '0x98c23e9d8f34fefb1b7bd6a91b7ff122f4e16f5c',
1707+
chainId: '0x1',
1708+
name: 'aEthUSDC',
1709+
},
1710+
{
1711+
address: '0x23878914efe38d27c4d67ab83ed1b93a74d4086a',
1712+
chainId: '0x1',
1713+
name: 'aEthUSDT',
1714+
},
1715+
{
1716+
address: '0x6b175474e89094c44da98b954eedeac495271d0f',
1717+
chainId: '0x1',
1718+
name: 'DAI',
1719+
},
1720+
{
1721+
address: '0x018008bfb33d285247a21d44e50697654f754e63',
1722+
chainId: '0x1',
1723+
name: 'aEthDAI',
1724+
},
1725+
{
1726+
address: '0x833589fcd6edb6e08f4c7c32d4f71b54bda02913',
1727+
chainId: '0x2105',
1728+
name: 'USDC',
1729+
},
1730+
{
1731+
address: '0x4e65fe4dba92790696d040ac24aa414708f5c0ab',
1732+
chainId: '0x2105',
1733+
name: 'aBasUSDC',
1734+
},
1735+
{
1736+
address: '0x00901a076785e0906d1028c7d6372d247bec7d61',
1737+
chainId: '0x38',
1738+
name: 'aBnbUSDC',
1739+
},
1740+
{
1741+
address: '0xa9251ca9de909cb71783723713b21e4233fbf1b1',
1742+
chainId: '0x38',
1743+
name: 'aBnbUSDT',
1744+
},
1745+
{
1746+
address: '0x754704bc059f8c67012fed69bc8a327a5aafb603',
1747+
chainId: '0x8f',
1748+
name: 'USDC',
1749+
},
1750+
{
1751+
address: '0xaca92e438df0b2401ff60da7e4337b687a2435da',
1752+
chainId: '0x8f',
1753+
name: 'mUSD',
1754+
},
1755+
{
1756+
address: '0x724dc807b04555b71ed48a6896b6f41593b8c637',
1757+
chainId: '0xa4b1',
1758+
name: 'aArbUSDC',
1759+
},
1760+
{
1761+
address: '0xaca92e438df0b2401ff60da7e4337b687a2435da',
1762+
chainId: '0xe708',
1763+
name: 'mUSD',
1764+
},
1765+
],
16341766
perpsDeposit: [
16351767
{
16361768
address: '0x0000000000000000000000000000000000000000',
16371769
chainId: '0x1',
16381770
name: 'ETH',
1639-
successRate: 93.89,
16401771
},
16411772
{
16421773
address: '0xA0b86991c6218b36c1d19D4a2e9Eb0cE3606eb48',
16431774
chainId: '0x1',
16441775
name: 'USDC',
1645-
successRate: 93.17,
16461776
},
16471777
{
16481778
address: '0xaf88d065e77c8cC2239327C5EDb3A432268e5831',
16491779
chainId: '0xa4b1',
16501780
name: 'USDC',
1651-
successRate: 90.73,
16521781
},
16531782
{
16541783
address: '0xdAC17F958D2ee523a2206206994597C13D831ec7',
16551784
chainId: '0x1',
16561785
name: 'USDT',
1657-
successRate: 90.4,
16581786
},
16591787
{
16601788
address: '0x55d398326f99059fF775485246999027B3197955',
16611789
chainId: '0x38',
16621790
name: 'USDT',
1663-
successRate: 91.4,
16641791
},
16651792
{
16661793
address: '0x0000000000000000000000000000000000000000',
16671794
chainId: '0xa4b1',
16681795
name: 'ETH',
1669-
successRate: 96.55,
16701796
},
16711797
{
16721798
address: '0x0000000000000000000000000000000000000000',
16731799
chainId: '0x2105',
16741800
name: 'ETH',
1675-
successRate: 91.15,
16761801
},
16771802
{
16781803
address: '0xFd086bC7CD5C481DCC9C85ebE478A1C0b69FCbb9',
16791804
chainId: '0xa4b1',
16801805
name: 'USDT',
1681-
successRate: 97.5,
16821806
},
16831807
{
16841808
address: '0x8AC76a51cc950d9822D68b83fE1Ad97B32Cd580d',
16851809
chainId: '0x38',
16861810
name: 'USDC',
1687-
successRate: 96.38,
16881811
},
16891812
{
16901813
address: '0x0000000000000000000000000000000000000000',
16911814
chainId: '0x38',
16921815
name: 'BNB',
1693-
successRate: 89.94,
16941816
},
16951817
{
16961818
address: '0x0000000000000000000000000000000000000000',
16971819
chainId: '0x89',
16981820
name: 'POL',
1699-
successRate: 89.65,
17001821
},
17011822
{
17021823
address: '0xe2fceAc20813592220b8C56999000d08C7844E6c',
17031824
chainId: '0x1',
17041825
name: 'MUSD',
1705-
successRate: 96.66,
17061826
},
17071827
],
17081828
perpsWithdraw: [
@@ -1714,7 +1834,6 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
17141834
],
17151835
},
17161836
},
1717-
rc: true,
17181837
},
17191838
status: FeatureFlagStatus.Active,
17201839
type: FeatureFlagType.Remote,
@@ -3233,8 +3352,8 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
32333352
inProd: true,
32343353
name: 'extensionUxChainlistV2',
32353354
productionDefault: {
3236-
enabled: false,
3237-
minimumVersion: '13.50.0',
3355+
enabled: true,
3356+
minimumVersion: '13.54.0',
32383357
},
32393358
status: FeatureFlagStatus.Active,
32403359
type: FeatureFlagType.Remote,
@@ -3401,7 +3520,7 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
34013520
inProd: true,
34023521
name: 'moneyAccountChompConfig',
34033522
productionDefault: {
3404-
baseUrl: 'https://chomp.dev-api.cx.metamask.io',
3523+
baseUrl: 'https://chomp.api.cx.metamask.io',
34053524
},
34063525
status: FeatureFlagStatus.Active,
34073526
type: FeatureFlagType.Remote,
@@ -3411,7 +3530,7 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
34113530
inProd: true,
34123531
name: 'moneyAccountGeoBlockedCountries',
34133532
productionDefault: {
3414-
blockedRegions: ['US', 'CA-ON'],
3533+
blockedRegions: ['GB'],
34153534
},
34163535
status: FeatureFlagStatus.Active,
34173536
type: FeatureFlagType.Remote,
@@ -3451,7 +3570,7 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
34513570
moneyEnableActivityDetails: {
34523571
inProd: true,
34533572
name: 'moneyEnableActivityDetails',
3454-
productionDefault: false,
3573+
productionDefault: true,
34553574
status: FeatureFlagStatus.Active,
34563575
type: FeatureFlagType.Remote,
34573576
},
@@ -3460,7 +3579,8 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
34603579
inProd: true,
34613580
name: 'moneyEnableMoneyAccount',
34623581
productionDefault: {
3463-
enabled: false,
3582+
enabled: true,
3583+
minimumVersion: '13.52.0',
34643584
},
34653585
status: FeatureFlagStatus.Active,
34663586
type: FeatureFlagType.Remote,
@@ -3470,7 +3590,8 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
34703590
inProd: true,
34713591
name: 'moneyHomeScreenCardEnabled',
34723592
productionDefault: {
3473-
enabled: false,
3593+
enabled: true,
3594+
minimumVersion: '0.0.0',
34743595
},
34753596
status: FeatureFlagStatus.Active,
34763597
type: FeatureFlagType.Remote,
@@ -3882,7 +4003,9 @@ export const FEATURE_FLAG_REGISTRY: Record<string, FeatureFlagRegistryEntry> = {
38824003
sentry: {
38834004
inProd: true,
38844005
name: 'sentry',
3885-
productionDefault: {},
4006+
productionDefault: {
4007+
persistenceWriteSampleRate: 0.0001,
4008+
},
38864009
status: FeatureFlagStatus.Active,
38874010
type: FeatureFlagType.Remote,
38884011
},

‎test/e2e/fixtures/fixture-validation.ts‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,11 @@ const getFixtureIgnoredKeys = (): string[] => [
8181
// Entire objects/controllers ignored (dynamic or impractical to validate)
8282
'data.AccountTreeController.selectedAccountGroup', // Entropy source is random and non-deterministic, and the selected group can change on each run.
8383
'data.AccountsController.internalAccounts.accounts',
84+
// MoneyAccountController populates moneyAccounts and defaultMoneyAccountId
85+
// on unlock alongside the Money keyring in KeyringController.vault
86+
// (which is also ignored below).
87+
'data.MoneyAccountController.moneyAccounts',
88+
'data.MoneyAccountController.defaultMoneyAccountId',
8489
'data.AccountTracker',
8590
'data.AssetsController',
8691
'data.AuthenticationController',

0 commit comments

Comments
 (0)