Repository navigation
Commit 63d44a1
test: Sync Feature Flag Registry - 2026-10-27 01:21 UTC (#47373)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
**Root cause:**
- Custom RPC history opens Add network and clicks the RPC dropdown
before typing a name.
- Chainlist v2 opens network suggestions on that empty form, and those
rows cover the RPC dropdown.
- Increase allowance and revoke allowance confirm a spend cap, then
click the confirmed activity row.
- The transaction confirmed toast stays on screen, and its link covers
that row.
- Request queuing confirms a send, then expects the home activity list.
- That same toast link is open on the transaction details route, so the
home activity list is not on screen.
- A fresh default wallet now creates a Money account on unlock, while
the committed fixture vault does not include the Money keyring yet.
- The default fixture records `defaultMoneyAccountId` as null. Unlock
with the Money account flag sets that field to the new account id, so
the dist fixture check sees a string.
- Solana swap tests have no local chain. Money account setup adds Monad,
Infura is redirected, and the primary RPC fails over to QuickNode.
- CHOMP's synced base URL is already `chomp.api.cx.metamask.io`, which
the privacy snapshot already lists.
**Solution:**
- Set `extensionUxChainlistV2`, `moneyEnableMoneyAccount`,
`moneyHomeScreenCardEnabled`, `moneyAccountGeoBlockedCountries`, and
`moneyAccountChompConfig` to the 2026-10-27 production values - these
specs now run against those defaults.
- Close the Chainlist name dropdown with Escape before opening the
add-RPC page - the RPC dropdown can be clicked.
- Close the transaction confirmed toast with its close button before
clicking the confirmed activity row - the row is no longer covered.
- On the request-queuing send, close that toast and leave transaction
details when the details route is open, then count the confirmed
activity row.
- Ignore `data.MoneyAccountController.moneyAccounts` and
`data.MoneyAccountController.defaultMoneyAccountId` in fixture schema
validation alongside `KeyringController.vault` and
`AccountsController.internalAccounts.accounts` - unlock sets the default
id to a string, and fresh wallet validation still passes while tests
create the Money keyring on unlock.
- Set `corePlatformRpcFailoverMode` to `disabled` in the Solana swap
flag mock, the same way the Bitcoin and Tron tests do - Monad does not
call the QuickNode host.
- Leave `chomp.dev-api.cx.metamask.io` out of the privacy snapshot -
this PR's CHOMP URL and the code default are already the production
host.
**Related pull requests:**
- #47375
## **Changelog**
CHANGELOG entry: null
<!--
## **Related issues**
Fixes:
-->
## **Manual testing steps**
1. Start a test build with `yarn start:test`.
2. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/network/custom-rpc-history.spec.ts --debug
--leave-running`.
3. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/confirmations/transactions/increase-token-allowance-redesign.spec.ts
--debug --leave-running`.
4. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/confirmations/transactions/revoke-allowance-redesign.spec.ts
--debug --leave-running`.
5. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/request-queuing/dapp1-switch-dapp2-send.spec.ts --debug
--leave-running`.
6. Run `SELENIUM_BROWSER=chrome yarn test:e2e:single
test/e2e/tests/solana/swap.spec.ts --debug --leave-running`.
7. Build dist with `yarn dist`, then run `SELENIUM_BROWSER=chrome yarn
test:e2e:single test/e2e/dist/wallet-fixture-validation.spec.ts --debug
--leave-running`.
## **Screenshots/Recordings**
### **Before**
Add network: the Chainlist panel is open under Network name. Ethereum,
Orderly Mainnet, and PrimusChain cover the form, and the click meant for
the RPC dropdown hits a Chainlist row.
Activity: the Transaction confirmed toast stays up over the Increased
spending row, and the click hits the toast link. Request queuing lands
on Sent ETH details with that toast still open, so the activity count
never sees the home list.
Solana swap: the home screen shows the same Money card and a Transaction
submitted toast. The test then fails because Monad's QuickNode failover
host is not in the privacy snapshot.
### **After**
No product UI change. The add-RPC step closes the Chainlist panel first.
The activity click closes the confirmed toast first. Request queuing
leaves transaction details when that route is open, then counts the
activity row. Fixture validation ignores the unlock-populated
`moneyAccounts` map and `defaultMoneyAccountId`. Solana swap disables
RPC failover instead of allowing the QuickNode host.
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Harry Le <43307514+LeVinhGithub@users.noreply.github.com>
Co-authored-by: LeVinhGithub <levinh.hcmut@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>1 parent 1744cd6 commit 63d44a1
7 files changed
Lines changed: 220 additions & 32 deletions
File tree
- test/e2e
- feature-flags
- fixtures
- page-objects
- components
- pages
- home
- networks
- tests
- request-queuing
- solana
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
76 | 76 | | |
77 | 77 | | |
78 | 78 | | |
79 | | - | |
| 79 | + | |
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| |||
105 | 105 | | |
106 | 106 | | |
107 | 107 | | |
108 | | - | |
| 108 | + | |
109 | 109 | | |
110 | | - | |
111 | | - | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
112 | 115 | | |
113 | 116 | | |
114 | 117 | | |
115 | 118 | | |
116 | | - | |
| 119 | + | |
117 | 120 | | |
118 | | - | |
119 | | - | |
| 121 | + | |
| 122 | + | |
120 | 123 | | |
121 | 124 | | |
122 | 125 | | |
| |||
219 | 222 | | |
220 | 223 | | |
221 | 224 | | |
222 | | - | |
| 225 | + | |
223 | 226 | | |
224 | 227 | | |
225 | 228 | | |
226 | 229 | | |
227 | 230 | | |
228 | 231 | | |
| 232 | + | |
229 | 233 | | |
230 | 234 | | |
231 | 235 | | |
| |||
242 | 246 | | |
243 | 247 | | |
244 | 248 | | |
| 249 | + | |
245 | 250 | | |
246 | 251 | | |
247 | 252 | | |
| |||
259 | 264 | | |
260 | 265 | | |
261 | 266 | | |
| 267 | + | |
262 | 268 | | |
263 | 269 | | |
264 | 270 | | |
| |||
1491 | 1497 | | |
1492 | 1498 | | |
1493 | 1499 | | |
1494 | | - | |
| 1500 | + | |
1495 | 1501 | | |
1496 | 1502 | | |
1497 | | - | |
1498 | | - | |
| 1503 | + | |
1499 | 1504 | | |
1500 | 1505 | | |
1501 | 1506 | | |
| |||
1631 | 1636 | | |
1632 | 1637 | | |
1633 | 1638 | | |
| 1639 | + | |
| 1640 | + | |
| 1641 | + | |
| 1642 | + | |
| 1643 | + | |
| 1644 | + | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
| 1655 | + | |
| 1656 | + | |
| 1657 | + | |
| 1658 | + | |
| 1659 | + | |
| 1660 | + | |
| 1661 | + | |
| 1662 | + | |
| 1663 | + | |
| 1664 | + | |
| 1665 | + | |
| 1666 | + | |
| 1667 | + | |
| 1668 | + | |
| 1669 | + | |
| 1670 | + | |
| 1671 | + | |
| 1672 | + | |
| 1673 | + | |
| 1674 | + | |
| 1675 | + | |
| 1676 | + | |
| 1677 | + | |
| 1678 | + | |
| 1679 | + | |
| 1680 | + | |
| 1681 | + | |
| 1682 | + | |
| 1683 | + | |
| 1684 | + | |
| 1685 | + | |
| 1686 | + | |
| 1687 | + | |
| 1688 | + | |
| 1689 | + | |
| 1690 | + | |
| 1691 | + | |
| 1692 | + | |
| 1693 | + | |
| 1694 | + | |
| 1695 | + | |
| 1696 | + | |
| 1697 | + | |
| 1698 | + | |
| 1699 | + | |
| 1700 | + | |
| 1701 | + | |
| 1702 | + | |
| 1703 | + | |
| 1704 | + | |
| 1705 | + | |
| 1706 | + | |
| 1707 | + | |
| 1708 | + | |
| 1709 | + | |
| 1710 | + | |
| 1711 | + | |
| 1712 | + | |
| 1713 | + | |
| 1714 | + | |
| 1715 | + | |
| 1716 | + | |
| 1717 | + | |
| 1718 | + | |
| 1719 | + | |
| 1720 | + | |
| 1721 | + | |
| 1722 | + | |
| 1723 | + | |
| 1724 | + | |
| 1725 | + | |
| 1726 | + | |
| 1727 | + | |
| 1728 | + | |
| 1729 | + | |
| 1730 | + | |
| 1731 | + | |
| 1732 | + | |
| 1733 | + | |
| 1734 | + | |
| 1735 | + | |
| 1736 | + | |
| 1737 | + | |
| 1738 | + | |
| 1739 | + | |
| 1740 | + | |
| 1741 | + | |
| 1742 | + | |
| 1743 | + | |
| 1744 | + | |
| 1745 | + | |
| 1746 | + | |
| 1747 | + | |
| 1748 | + | |
| 1749 | + | |
| 1750 | + | |
| 1751 | + | |
| 1752 | + | |
| 1753 | + | |
| 1754 | + | |
| 1755 | + | |
| 1756 | + | |
| 1757 | + | |
| 1758 | + | |
| 1759 | + | |
| 1760 | + | |
| 1761 | + | |
| 1762 | + | |
| 1763 | + | |
| 1764 | + | |
| 1765 | + | |
1634 | 1766 | | |
1635 | 1767 | | |
1636 | 1768 | | |
1637 | 1769 | | |
1638 | 1770 | | |
1639 | | - | |
1640 | 1771 | | |
1641 | 1772 | | |
1642 | 1773 | | |
1643 | 1774 | | |
1644 | 1775 | | |
1645 | | - | |
1646 | 1776 | | |
1647 | 1777 | | |
1648 | 1778 | | |
1649 | 1779 | | |
1650 | 1780 | | |
1651 | | - | |
1652 | 1781 | | |
1653 | 1782 | | |
1654 | 1783 | | |
1655 | 1784 | | |
1656 | 1785 | | |
1657 | | - | |
1658 | 1786 | | |
1659 | 1787 | | |
1660 | 1788 | | |
1661 | 1789 | | |
1662 | 1790 | | |
1663 | | - | |
1664 | 1791 | | |
1665 | 1792 | | |
1666 | 1793 | | |
1667 | 1794 | | |
1668 | 1795 | | |
1669 | | - | |
1670 | 1796 | | |
1671 | 1797 | | |
1672 | 1798 | | |
1673 | 1799 | | |
1674 | 1800 | | |
1675 | | - | |
1676 | 1801 | | |
1677 | 1802 | | |
1678 | 1803 | | |
1679 | 1804 | | |
1680 | 1805 | | |
1681 | | - | |
1682 | 1806 | | |
1683 | 1807 | | |
1684 | 1808 | | |
1685 | 1809 | | |
1686 | 1810 | | |
1687 | | - | |
1688 | 1811 | | |
1689 | 1812 | | |
1690 | 1813 | | |
1691 | 1814 | | |
1692 | 1815 | | |
1693 | | - | |
1694 | 1816 | | |
1695 | 1817 | | |
1696 | 1818 | | |
1697 | 1819 | | |
1698 | 1820 | | |
1699 | | - | |
1700 | 1821 | | |
1701 | 1822 | | |
1702 | 1823 | | |
1703 | 1824 | | |
1704 | 1825 | | |
1705 | | - | |
1706 | 1826 | | |
1707 | 1827 | | |
1708 | 1828 | | |
| |||
1714 | 1834 | | |
1715 | 1835 | | |
1716 | 1836 | | |
1717 | | - | |
1718 | 1837 | | |
1719 | 1838 | | |
1720 | 1839 | | |
| |||
3233 | 3352 | | |
3234 | 3353 | | |
3235 | 3354 | | |
3236 | | - | |
3237 | | - | |
| 3355 | + | |
| 3356 | + | |
3238 | 3357 | | |
3239 | 3358 | | |
3240 | 3359 | | |
| |||
3401 | 3520 | | |
3402 | 3521 | | |
3403 | 3522 | | |
3404 | | - | |
| 3523 | + | |
3405 | 3524 | | |
3406 | 3525 | | |
3407 | 3526 | | |
| |||
3411 | 3530 | | |
3412 | 3531 | | |
3413 | 3532 | | |
3414 | | - | |
| 3533 | + | |
3415 | 3534 | | |
3416 | 3535 | | |
3417 | 3536 | | |
| |||
3451 | 3570 | | |
3452 | 3571 | | |
3453 | 3572 | | |
3454 | | - | |
| 3573 | + | |
3455 | 3574 | | |
3456 | 3575 | | |
3457 | 3576 | | |
| |||
3460 | 3579 | | |
3461 | 3580 | | |
3462 | 3581 | | |
3463 | | - | |
| 3582 | + | |
| 3583 | + | |
3464 | 3584 | | |
3465 | 3585 | | |
3466 | 3586 | | |
| |||
3470 | 3590 | | |
3471 | 3591 | | |
3472 | 3592 | | |
3473 | | - | |
| 3593 | + | |
| 3594 | + | |
3474 | 3595 | | |
3475 | 3596 | | |
3476 | 3597 | | |
| |||
3882 | 4003 | | |
3883 | 4004 | | |
3884 | 4005 | | |
3885 | | - | |
| 4006 | + | |
| 4007 | + | |
| 4008 | + | |
3886 | 4009 | | |
3887 | 4010 | | |
3888 | 4011 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
84 | 89 | | |
85 | 90 | | |
86 | 91 | | |
| |||
0 commit comments