Repository navigation
Commit 7bd4b42
authored
fix(bridge): reorder minimum received row and fix quote card tooltip copy (#47642)
## **Description**
Fixes three UI issues in the swaps/bridge quote card:
1. Moved the "Minimum received" row directly under "Slippage" and above
"Price impact".
2. Fixed a typo in the "Price impact" tooltip: "availale liquidity" is
now "available liquidity".
3. Changed the "Minimum received" tooltip header from "Minimum amount
received" to "Minimum received", matching the row label.
Copy changes are applied to `en` and `en_GB`; other locales will be
picked up by translators.
## **Changelog**
CHANGELOG entry: Fixed the order of the "Minimum received" row and typos
in the swap quote card tooltips
## **Related issues**
Fixes:
[SWAPS-5007](https://consensyssoftware.atlassian.net/browse/SWAPS-5007)
## **Manual testing steps**
1. Run the extension and open Swap.
2. Select a source and destination token and enter an amount to fetch a
quote.
3. In the quote card, verify the rows appear in the order: Slippage,
Minimum received, Price impact.
4. Hover the "Price impact" info icon and verify the tooltip reads
"available liquidity".
5. Hover the "Minimum received" info icon and verify the tooltip header
reads "Minimum received".
<!--
## **Screenshots/Recordings**
### **Before**
### **After**
-->
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
[SWAPS-5007]:
https://consensyssoftware.atlassian.net/browse/SWAPS-5007?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Presentation-only changes to quote card row order and localized
strings, with no logic or transaction-handling impact.
>
> **Overview**
> Reorders the multichain bridge quote details so **Minimum received**
sits directly under **Slippage** and above **Price impact**, matching
the intended layout (snapshot test updated).
>
> Updates English copy: fixes the price-impact tooltip typo **availale →
available liquidity**, and shortens the minimum-received tooltip title
from **Minimum amount received** to **Minimum received** so it matches
the row label (`en` and `en_GB`).
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
4885997. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 0190053 commit 7bd4b42
4 files changed
Lines changed: 25 additions & 25 deletions
File tree
- app/_locales
- en_GB
- en
- ui/pages/bridge/quotes
- __snapshots__
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
766 | 766 | | |
767 | 767 | | |
768 | 768 | | |
769 | | - | |
| 769 | + | |
770 | 770 | | |
771 | | - | |
| 771 | + | |
772 | 772 | | |
773 | 773 | | |
774 | 774 | | |
| |||
783 | 783 | | |
784 | 784 | | |
785 | 785 | | |
786 | | - | |
787 | | - | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
788 | 789 | | |
789 | | - | |
790 | | - | |
791 | | - | |
792 | | - | |
793 | | - | |
794 | | - | |
| 790 | + | |
| 791 | + | |
795 | 792 | | |
796 | 793 | | |
797 | 794 | | |
| |||
800 | 797 | | |
801 | 798 | | |
802 | 799 | | |
803 | | - | |
| 800 | + | |
804 | 801 | | |
805 | | - | |
| 802 | + | |
806 | 803 | | |
807 | 804 | | |
808 | 805 | | |
| |||
817 | 814 | | |
818 | 815 | | |
819 | 816 | | |
820 | | - | |
821 | | - | |
822 | | - | |
| 817 | + | |
| 818 | + | |
823 | 819 | | |
824 | | - | |
825 | | - | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
826 | 826 | | |
827 | 827 | | |
828 | 828 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
424 | 424 | | |
425 | 425 | | |
426 | 426 | | |
427 | | - | |
428 | | - | |
429 | | - | |
430 | | - | |
431 | 427 | | |
432 | 428 | | |
433 | 429 | | |
| |||
461 | 457 | | |
462 | 458 | | |
463 | 459 | | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
464 | 464 | | |
465 | 465 | | |
466 | 466 | | |
| |||
0 commit comments