Repository navigation
Commit 904fb44
authored
test: Run E2E on Chrome 137 (#47453)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
Modifies E2E configuration to run tests on Chrome 137, in preparation
for updating the minimum required browser versions. Fixes the problems
that crop up following that:
- E2Es now require access to `Window` without scuttling (we already do
not scuttle `window`)
- Increased height of headless viewport to prevent issues with toasts
- Enable `--enable-unsafe-extension-debugging` as the extension cannot
be reloaded during test without it
- Enable `enableExtensionTargets` in order for popups to show up in
window handles.
- Allowlist Chrome GCM check-in endpoint
- Defer calls to `runtime.reload()`/`stateHooks.reloadExtension()` on
Chrome to prevent ChromeDriver crashes
- Use a timestamp further in the future for a Snaps test
- Retry phishing detection clicks to prevent timing issues
- Wait for disconnect to finish in dapp tests
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Low Risk**
> Changes are confined to E2E WebDriver configuration, test helpers, and
test-only Lavamoat scuttling exceptions, with no production user-facing
behavior changes.
>
> **Overview**
> Updates Selenium Chrome E2E to **Chrome 137** and adjusts
driver/options so extension reloads, popups, and headless layout work
reliably on the new version: **`--enable-unsafe-extension-debugging`**,
**`enableExtensionTargets`**, larger headless window height, and
skipping fixed **`--window-size`** when headless.
>
> **ChromeDriver stability:** extension reload helpers now
**`setTimeout(..., 100)`** before **`runtime.reload()`** /
**`stateHooks.reloadExtension()`** on Chrome, with an extra delay in
state-persistence helpers.
>
> **Test harness fixes:** Lavamoat test scuttling adds **`Window`** to
e2e globals; onboarding privacy allowlist adds
**`android.clients.google.com`**; phishing **Proceed anyway** gets
retries and optional **`waitForNavigation`**; dapp disconnect waits for
connect enabled; Snaps background event schedule uses **+30s**; deposit
spec asserts **10%** preset.
>
> **Risk:** Low — test-only wiring plus a test-build Lavamoat exception.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
618f1c6. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->1 parent 216e863 commit 904fb44
11 files changed
Lines changed: 57 additions & 10 deletions
File tree
- development/webpack/utils/plugins/LavamoatPlugin
- test/e2e
- dist
- page-objects/pages
- security
- snaps
- tests
- confirmations/metamask-pay
- phishing-controller
- privacy
- state-persistence
- tokens
- webdriver
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
98 | 98 | | |
99 | 99 | | |
100 | 100 | | |
101 | | - | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
102 | 104 | | |
103 | 105 | | |
104 | 106 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
27 | 31 | | |
28 | 32 | | |
29 | 33 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
86 | 87 | | |
87 | 88 | | |
88 | 89 | | |
89 | | - | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
90 | 93 | | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
91 | 101 | | |
92 | 102 | | |
93 | 103 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
984 | 984 | | |
985 | 985 | | |
986 | 986 | | |
| 987 | + | |
| 988 | + | |
| 989 | + | |
987 | 990 | | |
988 | 991 | | |
989 | 992 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
147 | 147 | | |
148 | 148 | | |
149 | 149 | | |
150 | | - | |
| 150 | + | |
151 | 151 | | |
152 | 152 | | |
153 | 153 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
49 | 52 | | |
50 | 53 | | |
51 | 54 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
207 | 207 | | |
208 | 208 | | |
209 | 209 | | |
210 | | - | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
211 | 213 | | |
212 | 214 | | |
213 | 215 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
96 | 97 | | |
97 | 98 | | |
98 | 99 | | |
99 | | - | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
100 | 103 | | |
101 | 104 | | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
102 | 110 | | |
103 | 111 | | |
104 | 112 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
3 | 4 | | |
4 | 5 | | |
5 | 6 | | |
| |||
314 | 315 | | |
315 | 316 | | |
316 | 317 | | |
317 | | - | |
| 318 | + | |
| 319 | + | |
| 320 | + | |
318 | 321 | | |
319 | 322 | | |
320 | 323 | | |
| |||
0 commit comments