Skip to content

Commit c3a708b

Browse files
authored
chore: trim urls from known violations list that pass the tests (#47662)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> Remove the urls from the knownViolations list that are not being called anymore with privacy on. ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** 1. Go to this page... 2. 3. ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test fixture only; no production or security logic changed. Risk is limited to e2e expectations if behavior drifts again. > > **Overview** > **Updates the privacy e2e allowlist** so `basic-functionality-off-known-violations.json` no longer lists hosts that no longer trigger violations when basic functionality is off (Infura mainnet hosts, `bridge.api.cx.metamask.io`, `execution.metamask.io`, `price.api.cx.metamask.io`, and `tokens.api.cx.metamask.io`). > > This keeps the known-violations list aligned with current network behavior and avoids false positives in the privacy suite. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit af0e0b0. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
1 parent afd6c6f commit c3a708b

1 file changed

Lines changed: 0 additions & 7 deletions

File tree

‎test/e2e/tests/privacy/basic-functionality-off-known-violations.json‎

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3,22 +3,15 @@
33
"accounts.api.cx.metamask.io",
44
"acl.execution.metamask.io",
55
"authentication.api.cx.metamask.io",
6-
"bitcoin-mainnet.infura.io",
7-
"bridge.api.cx.metamask.io",
86
"chainid.network",
97
"client-side-detection.api.cx.metamask.io",
10-
"execution.metamask.io",
118
"geolocation.dev-api.cx.metamask.io",
129
"nft.api.cx.metamask.io",
1310
"oidc.api.cx.metamask.io",
1411
"phishing-detection.api.cx.metamask.io",
1512
"preview.contentful.com",
16-
"price.api.cx.metamask.io",
1713
"static.cx.metamask.io",
18-
"stellar-mainnet.infura.io",
1914
"token.api.cx.metamask.io",
20-
"tokens.api.cx.metamask.io",
21-
"tron-mainnet.infura.io",
2215
"user-storage.api.cx.metamask.io"
2316
]
2417
}

0 commit comments

Comments
 (0)