Repository navigation
Commit cb932bc
chore: Bump subscription-controller to 15.2.0 (#47819)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
`@metamask/subscription-controller` is severely out of date: we're using
8.0.1, but the latest version is 15.2.0. This blocks an initiative by
the Core Platform team to streamline the background<->UI connection API
so that it goes through the root messenger instead of a bespoke object
(as not all SubscriptionController methods that should be registered
through the messenger actually are). This PR bumps
`subscription-controller` accordingly.
The good news is that SubscriptionController,
SubscriptionDelegationService, and SubscriptionService are all
initialized through the `wallet` package, which is already using 15.2.0.
We do import some types, constants, and enums through
`subscription-controller` directly, but none of the breaking changes
between 8.x and 15.x affect how those symbols are used, so there's
nothing we need to adapt to.
[You can view the changelog for `subscription-controller` here.](
https://github.com/MetaMask/core/blob/%40metamask/subscription-controller%4015.2.0/packages/subscription-controller/CHANGELOG.md)
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: null
## **Related issues**
https://consensyssoftware.atlassian.net/browse/WPC-1582
## **Manual testing steps**
Despite bumping a controller package by 7 major versions, this should
not have any functional impact. All user flows should work as-is.
## **Screenshots/Recordings**
(N/A)
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Large major-version controller upgrade with broad transitive
dependencies; behavior should be unchanged per PR notes but subscription
flows and messenger wiring merit regression checks.
>
> **Overview**
> Bumps **`@metamask/subscription-controller`** from **8.0.1** to
**15.2.0** in `package.json` and `yarn.lock`, aligning the extension’s
direct dependency with the version already used via `@metamask/wallet`.
>
> **LavaMoat** webpack policies (MV2/MV3, all channels) are regenerated
so `@metamask/subscription-controller` is modeled as a **top-level**
package instead of only
`@metamask/wallet>@metamask/subscription-controller`. That includes a
new `@metamask/subscription-controller>@metamask/controller-utils` entry
and updated nested allowances for `money-account-utils`,
`polling-controller`, `delegation-deployments`, and `bignumber.js`. **No
application source files** change in this diff—only dependency lockfile
and policy metadata.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
cb5bffc. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: Xiaoming Wang <dawnseeker8@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Xiaoming Wang <7315988+dawnseeker8@users.noreply.github.com>
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>
Co-authored-by: Xiaoming Wang <dawnseeker8@users.noreply.github.com>1 parent 8190582 commit cb932bc
10 files changed
Lines changed: 251 additions & 134 deletions
File tree
- lavamoat/webpack
- mv2
- beta
- experimental
- flask
- main
- mv3
- beta
- experimental
- flask
- main
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1635 | 1635 | | |
1636 | 1636 | | |
1637 | 1637 | | |
| 1638 | + | |
| 1639 | + | |
| 1640 | + | |
| 1641 | + | |
| 1642 | + | |
| 1643 | + | |
| 1644 | + | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
1638 | 1655 | | |
1639 | 1656 | | |
1640 | 1657 | | |
| |||
2519 | 2536 | | |
2520 | 2537 | | |
2521 | 2538 | | |
2522 | | - | |
| 2539 | + | |
2523 | 2540 | | |
2524 | 2541 | | |
2525 | 2542 | | |
| |||
2918 | 2935 | | |
2919 | 2936 | | |
2920 | 2937 | | |
2921 | | - | |
| 2938 | + | |
2922 | 2939 | | |
2923 | 2940 | | |
2924 | 2941 | | |
| |||
3363 | 3380 | | |
3364 | 3381 | | |
3365 | 3382 | | |
3366 | | - | |
| 3383 | + | |
3367 | 3384 | | |
3368 | 3385 | | |
3369 | 3386 | | |
3370 | 3387 | | |
3371 | 3388 | | |
3372 | 3389 | | |
3373 | 3390 | | |
3374 | | - | |
| 3391 | + | |
3375 | 3392 | | |
3376 | 3393 | | |
3377 | 3394 | | |
3378 | 3395 | | |
3379 | 3396 | | |
3380 | | - | |
| 3397 | + | |
3381 | 3398 | | |
3382 | | - | |
3383 | | - | |
3384 | | - | |
| 3399 | + | |
| 3400 | + | |
| 3401 | + | |
3385 | 3402 | | |
3386 | 3403 | | |
3387 | 3404 | | |
3388 | | - | |
| 3405 | + | |
3389 | 3406 | | |
3390 | 3407 | | |
3391 | 3408 | | |
| |||
3548 | 3565 | | |
3549 | 3566 | | |
3550 | 3567 | | |
3551 | | - | |
| 3568 | + | |
3552 | 3569 | | |
3553 | 3570 | | |
3554 | 3571 | | |
| |||
4788 | 4805 | | |
4789 | 4806 | | |
4790 | 4807 | | |
4791 | | - | |
| 4808 | + | |
4792 | 4809 | | |
4793 | 4810 | | |
4794 | 4811 | | |
4795 | 4812 | | |
4796 | | - | |
| 4813 | + | |
4797 | 4814 | | |
4798 | 4815 | | |
4799 | 4816 | | |
4800 | 4817 | | |
4801 | | - | |
| 4818 | + | |
4802 | 4819 | | |
4803 | 4820 | | |
4804 | 4821 | | |
4805 | 4822 | | |
4806 | | - | |
| 4823 | + | |
4807 | 4824 | | |
4808 | 4825 | | |
4809 | 4826 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1635 | 1635 | | |
1636 | 1636 | | |
1637 | 1637 | | |
| 1638 | + | |
| 1639 | + | |
| 1640 | + | |
| 1641 | + | |
| 1642 | + | |
| 1643 | + | |
| 1644 | + | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
1638 | 1655 | | |
1639 | 1656 | | |
1640 | 1657 | | |
| |||
2519 | 2536 | | |
2520 | 2537 | | |
2521 | 2538 | | |
2522 | | - | |
| 2539 | + | |
2523 | 2540 | | |
2524 | 2541 | | |
2525 | 2542 | | |
| |||
2918 | 2935 | | |
2919 | 2936 | | |
2920 | 2937 | | |
2921 | | - | |
| 2938 | + | |
2922 | 2939 | | |
2923 | 2940 | | |
2924 | 2941 | | |
| |||
3363 | 3380 | | |
3364 | 3381 | | |
3365 | 3382 | | |
3366 | | - | |
| 3383 | + | |
3367 | 3384 | | |
3368 | 3385 | | |
3369 | 3386 | | |
3370 | 3387 | | |
3371 | 3388 | | |
3372 | 3389 | | |
3373 | 3390 | | |
3374 | | - | |
| 3391 | + | |
3375 | 3392 | | |
3376 | 3393 | | |
3377 | 3394 | | |
3378 | 3395 | | |
3379 | 3396 | | |
3380 | | - | |
| 3397 | + | |
3381 | 3398 | | |
3382 | | - | |
3383 | | - | |
3384 | | - | |
| 3399 | + | |
| 3400 | + | |
| 3401 | + | |
3385 | 3402 | | |
3386 | 3403 | | |
3387 | 3404 | | |
3388 | | - | |
| 3405 | + | |
3389 | 3406 | | |
3390 | 3407 | | |
3391 | 3408 | | |
| |||
3548 | 3565 | | |
3549 | 3566 | | |
3550 | 3567 | | |
3551 | | - | |
| 3568 | + | |
3552 | 3569 | | |
3553 | 3570 | | |
3554 | 3571 | | |
| |||
4788 | 4805 | | |
4789 | 4806 | | |
4790 | 4807 | | |
4791 | | - | |
| 4808 | + | |
4792 | 4809 | | |
4793 | 4810 | | |
4794 | 4811 | | |
4795 | 4812 | | |
4796 | | - | |
| 4813 | + | |
4797 | 4814 | | |
4798 | 4815 | | |
4799 | 4816 | | |
4800 | 4817 | | |
4801 | | - | |
| 4818 | + | |
4802 | 4819 | | |
4803 | 4820 | | |
4804 | 4821 | | |
4805 | 4822 | | |
4806 | | - | |
| 4823 | + | |
4807 | 4824 | | |
4808 | 4825 | | |
4809 | 4826 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1635 | 1635 | | |
1636 | 1636 | | |
1637 | 1637 | | |
| 1638 | + | |
| 1639 | + | |
| 1640 | + | |
| 1641 | + | |
| 1642 | + | |
| 1643 | + | |
| 1644 | + | |
| 1645 | + | |
| 1646 | + | |
| 1647 | + | |
| 1648 | + | |
| 1649 | + | |
| 1650 | + | |
| 1651 | + | |
| 1652 | + | |
| 1653 | + | |
| 1654 | + | |
1638 | 1655 | | |
1639 | 1656 | | |
1640 | 1657 | | |
| |||
2519 | 2536 | | |
2520 | 2537 | | |
2521 | 2538 | | |
2522 | | - | |
| 2539 | + | |
2523 | 2540 | | |
2524 | 2541 | | |
2525 | 2542 | | |
| |||
2918 | 2935 | | |
2919 | 2936 | | |
2920 | 2937 | | |
2921 | | - | |
| 2938 | + | |
2922 | 2939 | | |
2923 | 2940 | | |
2924 | 2941 | | |
| |||
3363 | 3380 | | |
3364 | 3381 | | |
3365 | 3382 | | |
3366 | | - | |
| 3383 | + | |
3367 | 3384 | | |
3368 | 3385 | | |
3369 | 3386 | | |
3370 | 3387 | | |
3371 | 3388 | | |
3372 | 3389 | | |
3373 | 3390 | | |
3374 | | - | |
| 3391 | + | |
3375 | 3392 | | |
3376 | 3393 | | |
3377 | 3394 | | |
3378 | 3395 | | |
3379 | 3396 | | |
3380 | | - | |
| 3397 | + | |
3381 | 3398 | | |
3382 | | - | |
3383 | | - | |
3384 | | - | |
| 3399 | + | |
| 3400 | + | |
| 3401 | + | |
3385 | 3402 | | |
3386 | 3403 | | |
3387 | 3404 | | |
3388 | | - | |
| 3405 | + | |
3389 | 3406 | | |
3390 | 3407 | | |
3391 | 3408 | | |
| |||
3548 | 3565 | | |
3549 | 3566 | | |
3550 | 3567 | | |
3551 | | - | |
| 3568 | + | |
3552 | 3569 | | |
3553 | 3570 | | |
3554 | 3571 | | |
| |||
4788 | 4805 | | |
4789 | 4806 | | |
4790 | 4807 | | |
4791 | | - | |
| 4808 | + | |
4792 | 4809 | | |
4793 | 4810 | | |
4794 | 4811 | | |
4795 | 4812 | | |
4796 | | - | |
| 4813 | + | |
4797 | 4814 | | |
4798 | 4815 | | |
4799 | 4816 | | |
4800 | 4817 | | |
4801 | | - | |
| 4818 | + | |
4802 | 4819 | | |
4803 | 4820 | | |
4804 | 4821 | | |
4805 | 4822 | | |
4806 | | - | |
| 4823 | + | |
4807 | 4824 | | |
4808 | 4825 | | |
4809 | 4826 | | |
| |||
0 commit comments