Skip to content

Commit e4517b0

Browse files
chore(network-manager): remove unused networks button icon class (#47719)
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** Removes the unused `.network-manager__networks-button-icon` ruleset from the network manager stylesheet. The other rules in that file stay (`.network-manager__tab-list`, `.network-manager__tab-content`, `.network-manager__additional-network-item`, `.add-network__warning-icon`). Owner set: `@MetaMask/core-extension-ux` (`ui/components/multichain/network-manager/`). | path | removed (file / symbol / class) | why dead | | --- | --- | --- | | `ui/components/multichain/network-manager/index.scss` | `.network-manager__networks-button-icon` | unused class selector | No user-facing behavior change. Docs/comments updated: none Checks: `yarn stylelint` on the stylesheet (`yarn lint:styles` is the same stylelint invocation), `yarn test:unit --coverage=false ui/components/multichain/network-manager` (no snapshot updates). No JS/TS files changed, so `yarn lint:tsc` was not required. ## **Changelog** CHANGELOG entry: null ## **Related issues** Refs: proactive dead-code cleanup (extension counterpart of metamask-mobile#37948). ## **Manual testing steps** N/A — deletes unreachable code. There is no user-facing behavior to click through. ## **Screenshots/Recordings** N/A — no UI change. ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Extension Coding Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Dead-code cleanup in SCSS only; no functional or security impact. > > **Overview** > Removes the unused `.network-manager__networks-button-icon` ruleset from `ui/components/multichain/network-manager/index.scss`. No user-facing or styling behavior change for active network manager UI. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 88799fc. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: George Marshall <georgewrmarshall@users.noreply.github.com>
1 parent a61d6dc commit e4517b0

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

  • ui/components/multichain/network-manager

‎ui/components/multichain/network-manager/index.scss‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,11 +26,6 @@
2626
max-height: none;
2727
}
2828

29-
.network-manager__networks-button-icon {
30-
justify-content: center;
31-
display: flex;
32-
}
33-
3429
.network-manager__additional-network-item {
3530
.mm-button-icon {
3631
--button-icon-size: 20px;

0 commit comments

Comments
 (0)