Repository navigation
Commit f2a2d0b
chore: update bridge submitTx interface + location enum (#47426)
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->
## **Description**
<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->
Bumps the bridge controllers and integrates the new `submitTx` function
signature
## **Changelog**
<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`
If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`
(This helps the Release Engineer do their job more quickly and
accurately)
-->
CHANGELOG entry: chore: update bridge submitTx interface + location enum
## **Related issues**
Fixes: N/A
## **Manual testing steps**
1. Go to this page...
2.
3.
## **Screenshots/Recordings**
<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->
### **Before**
<!-- [screenshots/recordings] -->
### **After**
<!-- [screenshots/recordings] -->
## **Pre-merge author checklist**
- [ ] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask
Extension Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.
## **Pre-merge reviewer checklist**
- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
<!-- CURSOR_SUMMARY -->
---
> [!NOTE]
> **Medium Risk**
> Changes the bridge transaction submission RPC payload and upgrades
bridge-related controllers; misalignment could break swaps/bridges until
manually verified.
>
> **Overview**
> Bumps **@metamask/bridge-controller** to `^83.1.3` and
**@metamask/bridge-status-controller** to `^78.0.0`, with lockfile churn
for related controller/network/Solana deps. Drops the old
`bridge-controller@82.0.2` yarn resolution.
>
> **submitTx** calls from `ui/ducks/bridge-status/actions.ts` now pass a
**single options object** to `BridgeStatusController:submitTx`
(`quoteResponses`, `isStxEnabled`, `quotesReceivedContext`, `location`,
migration phase, etc.) instead of a long positional argument list; the
unit test expectation matches that shape.
>
> LavaMoat policies across MV2/MV3 builds narrow
**@metamask/bridge-controller>uuid** globals from blanket `crypto` to
`crypto.getRandomValues` and `crypto.randomUUID`.
>
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
f65d53e. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
---------
Co-authored-by: MetaMask Bot <metamaskbot@users.noreply.github.com>1 parent 6c864f3 commit f2a2d0b
12 files changed
Lines changed: 192 additions & 99 deletions
File tree
- lavamoat/webpack
- mv2
- beta
- experimental
- flask
- main
- mv3
- beta
- experimental
- flask
- main
- ui/ducks/bridge-status
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7705 | 7705 | | |
7706 | 7706 | | |
7707 | 7707 | | |
7708 | | - | |
| 7708 | + | |
| 7709 | + | |
7709 | 7710 | | |
7710 | 7711 | | |
7711 | 7712 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7705 | 7705 | | |
7706 | 7706 | | |
7707 | 7707 | | |
7708 | | - | |
| 7708 | + | |
| 7709 | + | |
7709 | 7710 | | |
7710 | 7711 | | |
7711 | 7712 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7705 | 7705 | | |
7706 | 7706 | | |
7707 | 7707 | | |
7708 | | - | |
| 7708 | + | |
| 7709 | + | |
7709 | 7710 | | |
7710 | 7711 | | |
7711 | 7712 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7705 | 7705 | | |
7706 | 7706 | | |
7707 | 7707 | | |
7708 | | - | |
| 7708 | + | |
| 7709 | + | |
7709 | 7710 | | |
7710 | 7711 | | |
7711 | 7712 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8039 | 8039 | | |
8040 | 8040 | | |
8041 | 8041 | | |
8042 | | - | |
| 8042 | + | |
| 8043 | + | |
8043 | 8044 | | |
8044 | 8045 | | |
8045 | 8046 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8039 | 8039 | | |
8040 | 8040 | | |
8041 | 8041 | | |
8042 | | - | |
| 8042 | + | |
| 8043 | + | |
8043 | 8044 | | |
8044 | 8045 | | |
8045 | 8046 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8039 | 8039 | | |
8040 | 8040 | | |
8041 | 8041 | | |
8042 | | - | |
| 8042 | + | |
| 8043 | + | |
8043 | 8044 | | |
8044 | 8045 | | |
8045 | 8046 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8039 | 8039 | | |
8040 | 8040 | | |
8041 | 8041 | | |
8042 | | - | |
| 8042 | + | |
| 8043 | + | |
8043 | 8044 | | |
8044 | 8045 | | |
8045 | 8046 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
180 | 180 | | |
181 | 181 | | |
182 | 182 | | |
183 | | - | |
184 | 183 | | |
185 | 184 | | |
186 | 185 | | |
| |||
424 | 423 | | |
425 | 424 | | |
426 | 425 | | |
427 | | - | |
428 | | - | |
| 426 | + | |
| 427 | + | |
429 | 428 | | |
430 | 429 | | |
431 | 430 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
43 | 43 | | |
44 | 44 | | |
45 | 45 | | |
| |||
0 commit comments