From 1368848f0f84152adf09c5496ae5f5f6eabf82e7 Mon Sep 17 00:00:00 2001 From: Maggie Date: Mon, 21 Sep 2026 12:27:10 +0300 Subject: [PATCH 1/3] test: fix flaky test Test Snap Homepage tests snap home page functionality --- test/e2e/snaps/test-snap-homepage.spec.ts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/test/e2e/snaps/test-snap-homepage.spec.ts b/test/e2e/snaps/test-snap-homepage.spec.ts index 84d69963679b..250c7d948711 100644 --- a/test/e2e/snaps/test-snap-homepage.spec.ts +++ b/test/e2e/snaps/test-snap-homepage.spec.ts @@ -5,6 +5,7 @@ import { withFixtures } from '../helpers'; import FixtureBuilderV2 from '../fixtures/fixture-builder-v2'; import HeaderNavbar from '../page-objects/pages/home/header-navbar'; import SnapListPage from '../page-objects/pages/snaps/list-page'; +import { TestSnaps } from '../page-objects/pages/test-snaps'; import { login } from '../page-objects/flows/login.flow'; import { openTestSnapClickButtonAndInstall } from '../page-objects/flows/install-test-snap.flow'; import { mockHomePageSnap } from '../mock-response-data/snaps/snap-binary-mocks'; @@ -27,12 +28,23 @@ describe('Test Snap Homepage', function (this: Suite) { const headerNavbar = new HeaderNavbar(driver); const snapListPage = new SnapListPage(driver); + const testSnaps = new TestSnaps(driver); await openTestSnapClickButtonAndInstall( driver, 'connectHomePageButton', ); + // Wait for the snap installation to be confirmed on the TestSnaps page. + // This gives the AccountActivity WebSocket time to connect and process + // its initial "chains up" notification before we switch to MetaMask, + // preventing a race condition where that notification fires concurrently + // with the global-menu drawer interaction and closes the drawer. + await testSnaps.checkInstallationComplete( + 'connectHomePageButton', + 'Reconnect to Home Page Snap', + ); + // switch to metamask page and open the three dots menu await driver.switchToWindowWithTitle( WINDOW_TITLES.ExtensionInFullScreenView, From ee806df96a53414899cff919bb71c8ad19cfb9a9 Mon Sep 17 00:00:00 2001 From: Maggie Date: Mon, 21 Sep 2026 13:50:54 +0300 Subject: [PATCH 2/3] test: fix flaky test Test Snap Homepage tests snap home page- update open global menu --- test/e2e/page-objects/pages/home/header-navbar.ts | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/test/e2e/page-objects/pages/home/header-navbar.ts b/test/e2e/page-objects/pages/home/header-navbar.ts index 12fd3f806513..b586b5187488 100644 --- a/test/e2e/page-objects/pages/home/header-navbar.ts +++ b/test/e2e/page-objects/pages/home/header-navbar.ts @@ -299,7 +299,16 @@ class HeaderNavbar { } catch { await this.driver.clickElementUsingMouseMove(this.globalMenuButton); } - await this.driver.waitForElementToStopMoving(this.drawerBackButton); + // Confirm the drawer is open: findVisibleElement checks actual viewport + // visibility, unlike waitForElementToStopMoving which passes even when the + // close button is at its stable off-screen position (drawer closed). Retry + // with clickElementUsingMouseMove if the click had no effect. + try { + await this.driver.findVisibleElement(this.drawerBackButton); + } catch { + await this.driver.clickElementUsingMouseMove(this.globalMenuButton); + await this.driver.findVisibleElement(this.drawerBackButton); + } } async openGlobalNetworksMenu({ From 9fe31673c376582c6335fc578b387dd2c527e753 Mon Sep 17 00:00:00 2001 From: Maggie Date: Mon, 21 Sep 2026 17:23:13 +0300 Subject: [PATCH 3/3] test: drop homepage snap install wait and drawer comment --- test/e2e/page-objects/pages/home/header-navbar.ts | 4 ---- test/e2e/snaps/test-snap-homepage.spec.ts | 12 ------------ 2 files changed, 16 deletions(-) diff --git a/test/e2e/page-objects/pages/home/header-navbar.ts b/test/e2e/page-objects/pages/home/header-navbar.ts index b586b5187488..d8bd95883501 100644 --- a/test/e2e/page-objects/pages/home/header-navbar.ts +++ b/test/e2e/page-objects/pages/home/header-navbar.ts @@ -299,10 +299,6 @@ class HeaderNavbar { } catch { await this.driver.clickElementUsingMouseMove(this.globalMenuButton); } - // Confirm the drawer is open: findVisibleElement checks actual viewport - // visibility, unlike waitForElementToStopMoving which passes even when the - // close button is at its stable off-screen position (drawer closed). Retry - // with clickElementUsingMouseMove if the click had no effect. try { await this.driver.findVisibleElement(this.drawerBackButton); } catch { diff --git a/test/e2e/snaps/test-snap-homepage.spec.ts b/test/e2e/snaps/test-snap-homepage.spec.ts index 250c7d948711..84d69963679b 100644 --- a/test/e2e/snaps/test-snap-homepage.spec.ts +++ b/test/e2e/snaps/test-snap-homepage.spec.ts @@ -5,7 +5,6 @@ import { withFixtures } from '../helpers'; import FixtureBuilderV2 from '../fixtures/fixture-builder-v2'; import HeaderNavbar from '../page-objects/pages/home/header-navbar'; import SnapListPage from '../page-objects/pages/snaps/list-page'; -import { TestSnaps } from '../page-objects/pages/test-snaps'; import { login } from '../page-objects/flows/login.flow'; import { openTestSnapClickButtonAndInstall } from '../page-objects/flows/install-test-snap.flow'; import { mockHomePageSnap } from '../mock-response-data/snaps/snap-binary-mocks'; @@ -28,23 +27,12 @@ describe('Test Snap Homepage', function (this: Suite) { const headerNavbar = new HeaderNavbar(driver); const snapListPage = new SnapListPage(driver); - const testSnaps = new TestSnaps(driver); await openTestSnapClickButtonAndInstall( driver, 'connectHomePageButton', ); - // Wait for the snap installation to be confirmed on the TestSnaps page. - // This gives the AccountActivity WebSocket time to connect and process - // its initial "chains up" notification before we switch to MetaMask, - // preventing a race condition where that notification fires concurrently - // with the global-menu drawer interaction and closes the drawer. - await testSnaps.checkInstallationComplete( - 'connectHomePageButton', - 'Reconnect to Home Page Snap', - ); - // switch to metamask page and open the three dots menu await driver.switchToWindowWithTitle( WINDOW_TITLES.ExtensionInFullScreenView,