Move common W3C classes from web to base - #1064
Merged
Merged
Conversation
Liudmila Molkova (lmolkova)
requested review from
Dmitry-Matveev and
Sergey Kanzhelev (SergeyKanzhelev)
January 18, 2019 04:10
Cijo Thomas (cijothomas)
approved these changes
Jan 22, 2019
Author
|
Dmitry-Matveev did you decide if we are allowed to do this? |
Member
|
Liudmila Molkova (@lmolkova) , I'm addressing this offline with OSS team, will add you to an email thread. |
Liudmila Molkova (lmolkova)
force-pushed
the
lmolkova/moveW3CToBase
branch
from
January 24, 2019 00:19
d077eb9 to
547e28e
Compare
Author
|
as per offline conversation with Dmitry-Matveev and OSS team:
no breaking changes. DepCollector W3C APIs will be removed in 3.0 |
Author
|
Dmitry-Matveev are you ok with this? Can I merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
W3C implementation is used by Web and AspNetCore SDKs.
We are going to enable W3C for some 1DS users that do not necessarily use Web SDK (and reference DependencyCollector that declares W3C implementation).
Without this change, we would require everyone to install base + dependency collector just to onboard W3C. With this change, it is still explicit choice to enable it.
This change is pure file move: no new functionality, namespace change, etc.