Repository navigation
Fix for AppDomain creation should honor runsettings - #427
Merged
Jayarani garg (jayaranigarg) merged 3 commits intoMay 24, 2018
Merged
Conversation
Siddhartha Pandey (acesiddhu)
approved these changes
May 24, 2018
Nitin Gurram (nigurr)
approved these changes
May 24, 2018
Nitin Gurram (nigurr)
left a comment
Nitin Gurram (nigurr)
left a comment
There was a problem hiding this comment.
Please do add test for enabled case too. thanks
| if (this.runSettings != null && MSTestAdapterSettings.IsAppDomainCreationDisabled(this.runSettings.SettingsXml)) | ||
| { | ||
| this.isAppDomainCreationDisabled = true; | ||
| return; |
Contributor
There was a problem hiding this comment.
Change the function name to IsAppDomainCreationDisabledInRunSettings make return type bool. or assign value of this.runSettings != null && MSTestAdapterSettings.IsAppDomainCreationDisabled(this.runSettings.SettingsXml) to isAppDomainCreationDisabled in .ctor and remove this function.
| var mockRunSettings = new Mock<IRunSettings>(); | ||
| mockRunSettings.Setup(rs => rs.SettingsXml).Returns(runSettingxml); | ||
|
|
||
| Mock<TestSourceHost> sourceHost = new Mock<TestSourceHost>(location, mockRunSettings.Object, null) { CallBase = true }; |
Contributor
There was a problem hiding this comment.
Nit: testSourceHost
Member
Author
|
dotnet bot (@dotnet-bot) Test Windows / Release Build please |
This was referenced Oct 3, 2025
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.