Improved performance of splitAroundQuotation - #5599
Merged
Merged
Conversation
Contributor
|
@Horusiath this is the hot path for the report you sent us. When this is merged and a nightly is produced, would you be interested in trying out the nightly when using your code that makes use of Type Providers? Based on some perf testing we think this should help. |
Contributor
KevinRansom
approved these changes
Sep 12, 2018
Contributor
|
@cartermp What is the tool that produces that table with profiling results? |
Contributor
|
PerfView: https://github.com/Microsoft/perfview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This increases perf of
splitAroundQuotationup to 50% and reduces GC 0 allocation counts by 60-70% roughly.