Skip to content

Commit 4e2b20b

Browse files
nftpoetristteknium1
authored andcommitted
fix(cli): sync use_gateway in _reconfigure_provider for tts, browser, and web
_reconfigure_provider() updates cloud_provider/backend/tts.provider when switching tool providers via "hermes setup tools → Reconfigure", but did not update the matching use_gateway flag. _configure_provider() (the initial-setup path) sets use_gateway on all three tool categories. The omission in _reconfigure_provider leaves a stale value in config.yaml: switching from a Nous-managed provider (use_gateway=True) to a self-hosted one keeps use_gateway=True, continuing to route requests through the Nous gateway; switching the other way leaves use_gateway unset so the managed feature does not activate. Fix: mirror _configure_provider's use_gateway = bool(managed_feature) assignment in the tts, browser, and web blocks of _reconfigure_provider. Symmetric across all three tool categories. No behavior change for any provider that does not set tts_provider, browser_provider, or web_backend. Fixes #15229
1 parent ba83374 commit 4e2b20b

2 files changed

Lines changed: 37 additions & 4 deletions

File tree

‎hermes_cli/tools_config.py‎

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1920,21 +1920,27 @@ def _reconfigure_provider(provider: dict, config: dict):
19201920
return
19211921

19221922
if provider.get("tts_provider"):
1923-
config.setdefault("tts", {})["provider"] = provider["tts_provider"]
1923+
tts_cfg = config.setdefault("tts", {})
1924+
tts_cfg["provider"] = provider["tts_provider"]
1925+
tts_cfg["use_gateway"] = bool(managed_feature)
19241926
_print_success(f" TTS provider set to: {provider['tts_provider']}")
19251927

19261928
if "browser_provider" in provider:
19271929
bp = provider["browser_provider"]
1930+
browser_cfg = config.setdefault("browser", {})
19281931
if bp == "local":
1929-
config.setdefault("browser", {})["cloud_provider"] = "local"
1932+
browser_cfg["cloud_provider"] = "local"
19301933
_print_success(" Browser set to local mode")
19311934
elif bp:
1932-
config.setdefault("browser", {})["cloud_provider"] = bp
1935+
browser_cfg["cloud_provider"] = bp
19331936
_print_success(f" Browser cloud provider set to: {bp}")
1937+
browser_cfg["use_gateway"] = bool(managed_feature)
19341938

19351939
# Set web search backend in config if applicable
19361940
if provider.get("web_backend"):
1937-
config.setdefault("web", {})["backend"] = provider["web_backend"]
1941+
web_cfg = config.setdefault("web", {})
1942+
web_cfg["backend"] = provider["web_backend"]
1943+
web_cfg["use_gateway"] = bool(managed_feature)
19381944
_print_success(f" Web backend set to: {provider['web_backend']}")
19391945

19401946
if managed_feature and managed_feature not in ("web", "tts", "browser"):

‎tests/hermes_cli/test_tools_config.py‎

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,13 @@
22

33
from unittest.mock import patch
44

5+
import pytest
6+
57
from hermes_cli.tools_config import (
68
_DEFAULT_OFF_TOOLSETS,
79
_apply_toolset_change,
810
_configure_provider,
11+
_reconfigure_provider,
912
_get_platform_tools,
1013
_platform_toolset_summary,
1114
_reconfigure_tool,
@@ -898,3 +901,27 @@ def test_get_effective_configurable_toolsets_dedupes_bundled_plugins():
898901
assert len(spotify_rows) == 1, spotify_rows
899902
# Built-in label wins over the plugin label.
900903
assert spotify_rows[0][1] == "🎵 Spotify"
904+
905+
906+
@pytest.mark.parametrize("provider,config_key,expected", [
907+
# managed provider → use_gateway True
908+
({"name": "T", "tts_provider": "elevenlabs", "managed_nous_feature": "tts", "env_vars": []}, "tts", True),
909+
({"name": "B", "browser_provider": "browserbase", "managed_nous_feature": "browser", "env_vars": []}, "browser", True),
910+
({"name": "W", "web_backend": "tavily", "managed_nous_feature": "web", "env_vars": []}, "web", True),
911+
# self-hosted provider → use_gateway False
912+
({"name": "T", "tts_provider": "elevenlabs", "env_vars": []}, "tts", False),
913+
({"name": "B", "browser_provider": "browserbase", "env_vars": []}, "browser", False),
914+
({"name": "W", "web_backend": "tavily", "env_vars": []}, "web", False),
915+
])
916+
def test_reconfigure_provider_syncs_use_gateway(provider, config_key, expected):
917+
config = {}
918+
_reconfigure_provider(provider, config)
919+
assert config[config_key]["use_gateway"] is expected
920+
921+
922+
def test_reconfigure_browser_provider_overwrites_stale_use_gateway():
923+
# Switching from managed (use_gateway=True) to self-hosted must clear the stale flag.
924+
config = {"browser": {"cloud_provider": "managed-browser", "use_gateway": True}}
925+
provider = {"name": "Browserbase", "browser_provider": "browserbase", "env_vars": []}
926+
_reconfigure_provider(provider, config)
927+
assert config["browser"]["use_gateway"] is False

0 commit comments

Comments
 (0)