Redo modern syntax rollout in react-native (facebook#57034)

Summary:
Pull Request resolved: facebook#57034

With D107165685, it should work this time.

Changelog: [Internal]

Differential Revision: D107111468

Author: SamChou19815

packages/assets-registry/registry.js

@@ -14,16 +14,16 @@
 export type AssetDestPathResolver = 'android' | 'generic';
 
 export type PackagerAsset = {
-  +__packager_asset: boolean,
-  +fileSystemLocation: string,
-  +httpServerLocation: string,
-  +width: ?number,
-  +height: ?number,
-  +scales: Array<number>,
-  +hash: string,
-  +name: string,
-  +type: string,
-  +resolver?: AssetDestPathResolver,
+  readonly __packager_asset: boolean,
+  readonly fileSystemLocation: string,
+  readonly httpServerLocation: string,
+  readonly width: ?number,
+  readonly height: ?number,
+  readonly scales: Array<number>,
+  readonly hash: string,
+  readonly name: string,
+  readonly type: string,
+  readonly resolver?: AssetDestPathResolver,
   ...
 };
 */

packages/dev-middleware/src/__tests__/InspectorDebuggerUtils.js

@@ -84,7 +84,7 @@ export class DebuggerAgent {
 
 export class DebuggerMock extends DebuggerAgent {
   // Empty handlers
-  +handle: JestMockFn<[message: JSONSerializable], void> = jest.fn();
+  readonly handle: JestMockFn<[message: JSONSerializable], void> = jest.fn();
 
   __handle(message: JSONSerializable): void {
     this.handle(message);

packages/dev-middleware/src/__tests__/InspectorDeviceUtils.js

@@ -98,16 +98,18 @@ export class DeviceAgent {
 
 export class DeviceMock extends DeviceAgent {
   // Empty handlers
-  +connect: JestMockFn<[message: ConnectRequest], void> = jest.fn();
-  +disconnect: JestMockFn<[message: DisconnectRequest], void> = jest.fn();
-  +getPages: JestMockFn<
+  readonly connect: JestMockFn<[message: ConnectRequest], void> = jest.fn();
+  readonly disconnect: JestMockFn<[message: DisconnectRequest], void> =
+    jest.fn();
+  readonly getPages: JestMockFn<
     [message: GetPagesRequest],
     | GetPagesResponse['payload']
     | Promise<GetPagesResponse['payload'] | void>
     | void,
   > = jest.fn();
-  +wrappedEvent: JestMockFn<[message: WrappedEventToDevice], void> = jest.fn();
-  +wrappedEventParsed: JestMockFn<
+  readonly wrappedEvent: JestMockFn<[message: WrappedEventToDevice], void> =
+    jest.fn();
+  readonly wrappedEventParsed: JestMockFn<
     [
       payload: {
         ...WrappedEventToDevice['payload'],

packages/dev-middleware/src/__tests__/StandaloneFuseboxShell-test.js

@@ -25,7 +25,7 @@ const PAGES_POLLING_DELAY = 2100;
 jest.useFakeTimers();
 
 async function setupDevice(
-  serverRef: {+serverBaseWsUrl: string, ...},
+  serverRef: {readonly serverBaseWsUrl: string, ...},
   signal: AbortSignal,
 ) {
   const device = await createDeviceMock(

packages/dev-middleware/src/inspector-proxy/Device.js

@@ -138,7 +138,7 @@ export default class Device {
   // Logging reporting batches of cdp messages
   #cdpDebugLogging: CdpDebugLogging;
 
-  +#experiments: Experiments;
+  readonly #experiments: Experiments;
 
   constructor(deviceOptions: DeviceOptions) {
     this.#experiments = deviceOptions.experiments;

packages/dev-middleware/src/inspector-proxy/InspectorProxy.js

@@ -93,7 +93,7 @@ export default class InspectorProxy implements InspectorProxyQueries {
 
   #eventReporter: ?EventReporter;
 
-  +#experiments: Experiments;
+  readonly #experiments: Experiments;
 
   // custom message handler factory allowing implementers to handle unsupported CDP messages.
   #customMessageHandler: ?CreateCustomMessageHandlerFn;

packages/dev-middleware/src/inspector-proxy/types.js

@@ -156,11 +156,11 @@ export type JSONSerializable =
   | string
   | null
   | ReadonlyArray<JSONSerializable>
-  | {+[string]: JSONSerializable};
+  | {readonly [string]: JSONSerializable};
 
 export type DeepReadOnly<T> =
   T extends ReadonlyArray<infer V>
     ? ReadonlyArray<DeepReadOnly<V>>
     : T extends {...}
-      ? {+[K in keyof T]: DeepReadOnly<T[K]>}
+      ? {readonly [K in keyof T]: DeepReadOnly<T[K]>}
       : T;

packages/dev-middleware/src/types/DevToolLauncher.js

@@ -27,7 +27,7 @@ export interface DevToolLauncher {
    * the host of dev-middleware. Implementations are responsible for rewriting
    * this as necessary where the server is remote.
    */
-  +launchDebuggerAppWindow: (url: string) => Promise<void>;
+  readonly launchDebuggerAppWindow: (url: string) => Promise<void>;
 
   /**
    * Attempt to open a debugger frontend URL in a standalone shell window
@@ -47,7 +47,10 @@ export interface DevToolLauncher {
    * the host of dev-middleware. Implementations are responsible for rewriting
    * this as necessary where the server is remote.
    */
-  +launchDebuggerShell?: (url: string, windowKey: string) => Promise<void>;
+  readonly launchDebuggerShell?: (
+    url: string,
+    windowKey: string,
+  ) => Promise<void>;
 
   /**
    * Attempt to prepare the debugger shell for use and returns a coded result
@@ -60,5 +63,5 @@ export interface DevToolLauncher {
    * SHOULD NOT return a rejecting promise in any case, and instead SHOULD report
    * errors via the returned result object.
    */
-  +prepareDebuggerShell?: () => Promise<DebuggerShellPreparationResult>;
+  readonly prepareDebuggerShell?: () => Promise<DebuggerShellPreparationResult>;
 }

packages/dev-middleware/src/types/ReadonlyURL.js

@@ -15,7 +15,7 @@ export interface ReadonlyURLSearchParams {
   get(name: string): string | null;
   getAll(name: string): Array<string>;
   has(name: string, value?: string): boolean;
-  +size: number;
+  readonly size: number;
   entries(): Iterator<[string, string]>;
   keys(): Iterator<string>;
   values(): Iterator<string>;
@@ -37,18 +37,18 @@ export interface ReadonlyURLSearchParams {
  * Used for URLs passed between module boundaries.
  */
 export interface ReadonlyURL {
-  +hash: string;
-  +host: string;
-  +hostname: string;
-  +href: string;
-  +origin: string;
-  +password: string;
-  +pathname: string;
-  +port: string;
-  +protocol: string;
-  +search: string;
-  +searchParams: ReadonlyURLSearchParams;
-  +username: string;
+  readonly hash: string;
+  readonly host: string;
+  readonly hostname: string;
+  readonly href: string;
+  readonly origin: string;
+  readonly password: string;
+  readonly pathname: string;
+  readonly port: string;
+  readonly protocol: string;
+  readonly search: string;
+  readonly searchParams: ReadonlyURLSearchParams;
+  readonly username: string;
   toString(): string;
   toJSON(): string;
 }

packages/react-native-codegen/e2e/deep_imports/__test_fixtures__/modules/NativeArrayTurboModule.js

@@ -16,9 +16,12 @@ export type ArrayType = string;
 type AnotherArray = Array<ArrayType>;
 
 export interface Spec extends TurboModule {
-  +getArray: (a: Array<any>) => Array<string>;
-  +getReadOnlyArray: (a: Array<any>) => ReadonlyArray<string>;
-  +getArrayWithAlias: (a: AnotherArray, b: Array<ArrayType>) => AnotherArray;
+  readonly getArray: (a: Array<any>) => Array<string>;
+  readonly getReadOnlyArray: (a: Array<any>) => ReadonlyArray<string>;
+  readonly getArrayWithAlias: (
+    a: AnotherArray,
+    b: Array<ArrayType>,
+  ) => AnotherArray;
 }
 
 export default TurboModuleRegistry.getEnforcing<Spec>(