From 6f7aca5e2cd73a33dd0c4bb0bafef78b39137369 Mon Sep 17 00:00:00 2001 From: romsharon98 Date: Mon, 15 Jan 2024 13:15:39 +0200 Subject: [PATCH 1/2] Fix assignment of template field in __init__ in vertex_ai --- .../cloud/operators/vertex_ai/custom_job.py | 36 +++++++++++++++++-- 1 file changed, 33 insertions(+), 3 deletions(-) diff --git a/airflow/providers/google/cloud/operators/vertex_ai/custom_job.py b/airflow/providers/google/cloud/operators/vertex_ai/custom_job.py index 0b3d221675e07..e94c39efea1d3 100644 --- a/airflow/providers/google/cloud/operators/vertex_ai/custom_job.py +++ b/airflow/providers/google/cloud/operators/vertex_ai/custom_job.py @@ -445,9 +445,19 @@ def __init__( self, *, command: Sequence[str] = [], + region: str, + parent_model: str | None = None, + impersonation_chain: str | Sequence[str] | None = None, + dataset_id: str | None = None, **kwargs, ) -> None: - super().__init__(**kwargs) + super().__init__( + region=region, + parent_model=parent_model, + impersonation_chain=impersonation_chain, + dataset_id=dataset_id, + **kwargs, + ) self.command = command def execute(self, context: Context): @@ -816,9 +826,19 @@ def __init__( *, python_package_gcs_uri: str, python_module_name: str, + region: str, + parent_model: str | None = None, + impersonation_chain: str | Sequence[str] | None = None, + dataset_id: str | None = None, **kwargs, ) -> None: - super().__init__(**kwargs) + super().__init__( + region=region, + parent_model=parent_model, + impersonation_chain=impersonation_chain, + dataset_id=dataset_id, + **kwargs, + ) self.python_package_gcs_uri = python_package_gcs_uri self.python_module_name = python_module_name @@ -1190,9 +1210,19 @@ def __init__( *, script_path: str, requirements: Sequence[str] | None = None, + region: str, + parent_model: str | None = None, + impersonation_chain: str | Sequence[str] | None = None, + dataset_id: str | None = None, **kwargs, ) -> None: - super().__init__(**kwargs) + super().__init__( + region=region, + parent_model=parent_model, + impersonation_chain=impersonation_chain, + dataset_id=dataset_id, + **kwargs, + ) self.requirements = requirements self.script_path = script_path From a4df2a54c062aa470e95947e215ba16010e935a6 Mon Sep 17 00:00:00 2001 From: romsharon98 Date: Sat, 20 Jan 2024 21:20:11 +0200 Subject: [PATCH 2/2] remove file from exclude --- .pre-commit-config.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 8be555de3a6b2..f1697038d4015 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -331,7 +331,6 @@ repos: ^airflow\/providers\/google\/cloud\/transfers\/bigquery_to_mysql\.py$| ^airflow\/providers\/amazon\/aws\/transfers\/redshift_to_s3\.py$| ^airflow\/providers\/google\/cloud\/operators\/compute\.py$| - ^airflow\/providers\/google\/cloud\/operators\/vertex_ai\/custom_job\.py$| ^airflow\/providers\/amazon\/aws\/operators\/emr\.py$| ^airflow\/providers\/amazon\/aws\/operators\/eks\.py$ )$