From 690df2e4b8e020de9ea0986be08f2735a4cafc96 Mon Sep 17 00:00:00 2001 From: dirrao Date: Mon, 22 Jul 2024 16:40:47 +0530 Subject: [PATCH 1/2] store_serialized_dags parameter usage removal --- airflow/models/dagbag.py | 23 ----------------------- 1 file changed, 23 deletions(-) diff --git a/airflow/models/dagbag.py b/airflow/models/dagbag.py index 96b6ecf035d43..289e9f346bc62 100644 --- a/airflow/models/dagbag.py +++ b/airflow/models/dagbag.py @@ -25,7 +25,6 @@ import sys import textwrap import traceback -import warnings import zipfile from datetime import datetime, timedelta from pathlib import Path @@ -46,7 +45,6 @@ AirflowClusterPolicyViolation, AirflowDagCycleException, AirflowDagDuplicatedIdException, - RemovedInAirflow3Warning, ) from airflow.models.base import Base from airflow.stats import Stats @@ -111,7 +109,6 @@ class DagBag(LoggingMixin): to filter python modules to scan for dags. :param read_dags_from_db: Read DAGs from DB if ``True`` is passed. If ``False`` DAGs are read from python files. - :param store_serialized_dags: deprecated parameter, same effect as `read_dags_from_db` :param load_op_links: Should the extra operator link be loaded via plugins when de-serializing the DAG? This flag is set to False in Scheduler so that Extra Operator links are not loaded to not run User code in Scheduler. @@ -124,7 +121,6 @@ def __init__( include_examples: bool | ArgNotSet = NOTSET, safe_mode: bool | ArgNotSet = NOTSET, read_dags_from_db: bool = False, - store_serialized_dags: bool | None = None, load_op_links: bool = True, collect_dags: bool = True, ): @@ -141,15 +137,6 @@ def __init__( safe_mode if isinstance(safe_mode, bool) else conf.getboolean("core", "DAG_DISCOVERY_SAFE_MODE") ) - if store_serialized_dags: - warnings.warn( - "The store_serialized_dags parameter has been deprecated. " - "You should pass the read_dags_from_db parameter.", - RemovedInAirflow3Warning, - stacklevel=2, - ) - read_dags_from_db = store_serialized_dags - dag_folder = dag_folder or settings.DAGS_FOLDER self.dag_folder = dag_folder self.dags: dict[str, DAG] = {} @@ -180,16 +167,6 @@ def size(self) -> int: """:return: the amount of dags contained in this dagbag""" return len(self.dags) - @property - def store_serialized_dags(self) -> bool: - """Whether to read dags from DB.""" - warnings.warn( - "The store_serialized_dags property has been deprecated. Use read_dags_from_db instead.", - RemovedInAirflow3Warning, - stacklevel=2, - ) - return self.read_dags_from_db - @property def dag_ids(self) -> list[str]: """ From 199c068eb059bf8160e9fd9c2a7eb21fc43231d5 Mon Sep 17 00:00:00 2001 From: dirrao Date: Fri, 16 Aug 2024 16:26:09 +0530 Subject: [PATCH 2/2] news fragment added --- newsfragments/40931.significant.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 newsfragments/40931.significant.rst diff --git a/newsfragments/40931.significant.rst b/newsfragments/40931.significant.rst new file mode 100644 index 0000000000000..b5d47f0c36b8a --- /dev/null +++ b/newsfragments/40931.significant.rst @@ -0,0 +1 @@ +Removed dagbag deprecated ``store_serialized_dags`` parameter. Please use ``read_dags_from_db`` parameter.