From 067fa57ccd624f93d767ca1b6858717b75e33a1a Mon Sep 17 00:00:00 2001 From: dirrao Date: Wed, 2 Oct 2024 07:43:03 +0530 Subject: [PATCH 1/2] Removed unused and deprecated custom dag dependancy detector from serilization tests --- tests/serialization/test_dag_serialization.py | 33 ------------------- 1 file changed, 33 deletions(-) diff --git a/tests/serialization/test_dag_serialization.py b/tests/serialization/test_dag_serialization.py index 6910514776afe..d063b3e78035a 100644 --- a/tests/serialization/test_dag_serialization.py +++ b/tests/serialization/test_dag_serialization.py @@ -65,12 +65,10 @@ from airflow.providers.cncf.kubernetes.pod_generator import PodGenerator from airflow.security import permissions from airflow.sensors.bash import BashSensor -from airflow.serialization.dag_dependency import DagDependency from airflow.serialization.enums import Encoding from airflow.serialization.json_schema import load_dag_schema_dict from airflow.serialization.serialized_objects import ( BaseSerialization, - DependencyDetector, SerializedBaseOperator, SerializedDAG, ) @@ -87,42 +85,11 @@ from tests.test_utils.timetables import CustomSerializationTimetable, cron_timetable, delta_timetable if TYPE_CHECKING: - from airflow.models.operator import Operator from airflow.utils.context import Context repo_root = Path(airflow.__file__).parent.parent -class CustomDepOperator(BashOperator): - """ - Used for testing custom dependency detector. - - TODO: remove in Airflow 3.0 - """ - - -class CustomDependencyDetector(DependencyDetector): - """ - Prior to deprecation of custom dependency detector, the return type as DagDependency | None. - This class verifies that custom dependency detector classes which assume that return type will still - work until support for them is removed in 3.0. - - TODO: remove in Airflow 3.0 - """ - - @staticmethod - def detect_task_dependencies(task: Operator) -> DagDependency | None: # type: ignore - if isinstance(task, CustomDepOperator): - return DagDependency( - source=task.dag_id, - target="nothing", - dependency_type="abc", - dependency_id=task.task_id, - ) - else: - return DependencyDetector().detect_task_dependencies(task) # type: ignore - - executor_config_pod = k8s.V1Pod( metadata=k8s.V1ObjectMeta(name="my-name"), spec=k8s.V1PodSpec( From 62cd7fa2517e680b3847ae63fdc57af1907cba57 Mon Sep 17 00:00:00 2001 From: dirrao Date: Fri, 4 Oct 2024 11:26:13 +0530 Subject: [PATCH 2/2] Added news fragment --- newsfragments/42640.significant.rst | 1 + 1 file changed, 1 insertion(+) create mode 100644 newsfragments/42640.significant.rst diff --git a/newsfragments/42640.significant.rst b/newsfragments/42640.significant.rst new file mode 100644 index 0000000000000..a6f09eba8b437 --- /dev/null +++ b/newsfragments/42640.significant.rst @@ -0,0 +1 @@ +Removed deprecated custom dag dependency detector.