Skip to content

Commit 6b10958

Browse files
fix(navbar): restore small caret icon on right-menu dropdowns
The "+", theme switcher, and Settings dropdowns in the navbar's right menu were switched from Icons.CaretDownOutlined to Icons.DownOutlined, whose glyph fills noticeably more of its bounding box even at the same iconSize="xs", making the caret look larger and inconsistent with the language picker's caret (still CaretDownOutlined) in the same menu. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
1 parent 7e3d092 commit 6b10958

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎superset-frontend/src/features/home/RightMenu.tsx‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -614,7 +614,7 @@ const RightMenu = ({
614614
key: 'new-dropdown',
615615
label: <Icons.PlusOutlined data-test="new-dropdown-icon" />,
616616
className: 'submenu-with-caret',
617-
icon: <Icons.DownOutlined iconSize="xs" />,
617+
icon: <Icons.CaretDownOutlined iconSize="xs" />,
618618
children: buildNewDropdownItems(),
619619
popupOffset: NAVBAR_MENU_POPUP_OFFSET,
620620
});
@@ -631,7 +631,7 @@ const RightMenu = ({
631631
items.push({
632632
key: 'settings',
633633
label: t('Settings'),
634-
icon: <Icons.DownOutlined iconSize="xs" />,
634+
icon: <Icons.CaretDownOutlined iconSize="xs" />,
635635
children: buildSettingsMenuItems(),
636636
className: 'submenu-with-caret',
637637
popupOffset: NAVBAR_MENU_POPUP_OFFSET,

‎superset-frontend/src/hooks/useThemeMenuItems.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ export const useThemeMenuItems = ({
136136
return {
137137
key: 'theme-sub-menu',
138138
label: selectedThemeModeIcon,
139-
icon: <Icons.DownOutlined iconSize="xs" />,
139+
icon: <Icons.CaretDownOutlined iconSize="xs" />,
140140
className: 'submenu-with-caret',
141141
children,
142142
popupOffset: NAVBAR_MENU_POPUP_OFFSET,

0 commit comments

Comments
 (0)