From 1e5789760fd364da4167c047df61f094e09d9cc6 Mon Sep 17 00:00:00 2001 From: Le Xich Long Date: Fri, 28 Feb 2025 09:44:43 +0000 Subject: [PATCH 1/2] cast url query to dict --- superset/db_engine_specs/clickhouse.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/superset/db_engine_specs/clickhouse.py b/superset/db_engine_specs/clickhouse.py index 0d40acbe673d..49990f8a4cc4 100644 --- a/superset/db_engine_specs/clickhouse.py +++ b/superset/db_engine_specs/clickhouse.py @@ -334,9 +334,9 @@ def get_parameters_from_uri( cls, uri: str, encrypted_extra: dict[str, Any] | None = None ) -> BasicParametersType: url = make_url_safe(uri) - query = url.query + query = dict(url.query) if "secure" in query: - encryption = url.query.get("secure") == "true" + encryption = query == "true" query.pop("secure") else: encryption = False @@ -346,7 +346,7 @@ def get_parameters_from_uri( host=url.host, port=url.port, database="" if url.database == "__default__" else cast(str, url.database), - query=dict(query), + query=query, encryption=encryption, ) From 7a69804e183efe4b14140f0ca56d58f20e4fa7a3 Mon Sep 17 00:00:00 2001 From: Le Xich Long Date: Fri, 28 Feb 2025 10:00:20 +0000 Subject: [PATCH 2/2] fix --- superset/db_engine_specs/clickhouse.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/superset/db_engine_specs/clickhouse.py b/superset/db_engine_specs/clickhouse.py index 49990f8a4cc4..8fb8e1d09923 100644 --- a/superset/db_engine_specs/clickhouse.py +++ b/superset/db_engine_specs/clickhouse.py @@ -336,7 +336,7 @@ def get_parameters_from_uri( url = make_url_safe(uri) query = dict(url.query) if "secure" in query: - encryption = query == "true" + encryption = query.get("secure") == "true" query.pop("secure") else: encryption = False