From 6b3e7731e0f13607f0a63644259bfae6923ff9b1 Mon Sep 17 00:00:00 2001
From: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Date: Fri, 29 Aug 2025 11:12:11 +0200
Subject: [PATCH] fix: Filter bar orientation submenu should not be highlighted

---
 .../FilterBar/FilterBarSettings/index.tsx        | 16 +++++++++++++---
 1 file changed, 13 insertions(+), 3 deletions(-)

diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx
index ce5c3efd16df..54f7810b6b43 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBarSettings/index.tsx
@@ -190,6 +190,7 @@ const FilterBarSettings = () => {
       items.push({
         key: 'placement',
         label: t('Orientation of filter bar'),
+        className: 'filter-bar-orientation-submenu',
         children: [
           {
             key: FilterBarOrientation.Vertical,
@@ -200,9 +201,6 @@ const FilterBarSettings = () => {
                   FilterBarOrientation.Vertical && (
                   <Icons.CheckOutlined
                     iconColor={theme.colorPrimary}
-                    css={css`
-                      vertical-align: -${theme.sizeUnit * 0.03125}em;
-                    `}
                     iconSize="m"
                   />
                 )}
@@ -252,6 +250,18 @@ const FilterBarSettings = () => {
           selectedKeys: [selectedFilterBarOrientation],
         }}
         trigger={['click']}
+        popupRender={menu => (
+          <div
+            css={css`
+              .filter-bar-orientation-submenu.ant-dropdown-menu-submenu-selected
+                > .ant-dropdown-menu-submenu-title {
+                color: inherit;
+              }
+            `}
+          >
+            {menu}
+          </div>
+        )}
       >
         <Button
           buttonStyle="link"