Generic delegate construction isn't marked as unnecessary with overloads

Source:

var s = new Socket(new SocketInformation());
Task.Factory.FromAsync(s.BeginAccept, s.EndAccept, null);
Task.Factory.FromAsync(new Func<AsyncCallback, object, IAsyncResult>(s.BeginAccept), s.EndAccept, null);

The last two lines bind to the same methods, but the delegate construction isn't marked as unnecessary.

@SLaks

@SLaks this is by design, or rather an unsupported simplification.

Our cast simplifier currently tries to detect unnecessary explicit casts, but doesn't deal with trying to detect redundant invocation expressions, which would be semantically equivalent via an implicit conversion in the simplified code. Note that implementing such a simplifier would be no trivial as there is no easy way to determine if the implicit conversion is equivalent to invoking a specific method/constructor.

I'm only talking about delegate constructors, which (I think?) should always be semantically equivalent to an explicit cast.

How is this harder?

@srivatsn

@srivatsn this is basically a mini-feature request for simplifying redundant object creation expressions for delegates. We would need to add a new simplifier to deal with object creation expression.

[PR tagger] Add repo path parameter (#1254)

Navigation Menu

Repository navigation

Generic delegate construction isn't marked as unnecessary with overloads #1254

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Generic delegate construction isn't marked as unnecessary with overloads #1254

Description

Activity

mavasani commented on Apr 1, 2015

SLaks commented on Apr 1, 2015

mavasani commented on Apr 18, 2015

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions