Skip to content

[RC2] Unable to specify values to /keepalive for compiler server #1499

Closed
Closed
[RC2] Unable to specify values to /keepalive for compiler server#1499
Assignees
jaredpar
Labels
Approved to mergeArea-CompilersBugResolution-FixedThe bug has been fixed and/or the requested behavior has been implementedVerified
Milestone
1.0-rc2

Description

@agocke
agocke
opened on Mar 23, 2015

This issue represents porting the fix for the /keepalive switch in 752d7cc to the preview branch.

Importance

Without this fix, every valid use of the /keepalive switch results in

error CS2007: Unrecognized option: '/keepalive:10'

and keepalive is completely unusable. This switch is mandatory for Roslyn use in ASP.NET classic.

Fix Description

The proposed fix for RC2 is represented a pull request #1518.

Validation

There are already a variety of unit tests for this feature, but this change also adds an end-to-end test that verifies the complete scenario.

Risk

This is a targeted fix to the keepalive switch and should not effect any other compiler scenarios.

Activity

  1. agocke commented on Mar 23, 2015

    @agocke
    agocke
    on Mar 23, 2015
    MemberAuthor

    @theoy FYI

  2. gafter
    added
    Area-Compilers
    on Mar 23, 2015
  3. theoy
    added this to the 1.0-rc2 milestone on Mar 24, 2015
  4. theoy
    added
    Bug
    on Mar 24, 2015
  5. theoy
    changed the title [-]Port fix for /keepalive to preview branch[/-] [+][RC2] Unable to specify values to /keepalive for compiler server[/+] on Mar 24, 2015
  6. theoy
    assigned
    agocke
    on Mar 24, 2015

  7. theoy commented on Mar 24, 2015

    @theoy
    theoy
    on Mar 24, 2015
    Contributor

    @agocke - let's tee up a PR before we get approval for this as well.

  8. agocke commented on Mar 24, 2015

    @agocke
    agocke
    on Mar 24, 2015
    MemberAuthor

    @theoy PR created at #1518.

  9. theoy
    added
    3 - Working
    4 - In ReviewA fix for the issue is submitted for review.
    Approved to merge
    and removed
    3 - Working
    on Mar 25, 2015

  10. MattGertz commented on Mar 26, 2015

    @MattGertz
    MattGertz
    on Mar 26, 2015
    Contributor

    Approved for next preview.

  11. agocke commented on Mar 26, 2015

    @agocke
    agocke
    on Mar 26, 2015
    MemberAuthor

    Merged #1518

  12. agocke
    closed this as completedon Mar 26, 2015
  13. agocke
    removed their assignment
    on Apr 7, 2015
  14. srivatsn
    assigned
    theoy
    on Apr 17, 2015
  15. gafter
    added
    Resolution-FixedThe bug has been fixed and/or the requested behavior has been implemented
    and removed
    4 - In ReviewA fix for the issue is submitted for review.
    on Apr 19, 2015
  16. theoy
    assigned
    jaredpar
    and unassigned
    theoy
    on May 5, 2015
  17. jaredpar
    added
    Verified
    on Jun 8, 2015
  18. JoeRobich
    added a commit that references this issue on Aug 18, 2026

    Allow create-release-tags to looks up repo SHA from vmr build (#1499)

    5ccfec0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Approved to mergeArea-CompilersBugResolution-FixedThe bug has been fixed and/or the requested behavior has been implementedVerified

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions