Repository navigation
Remove InternalImplementationOnlyAttribute and constrain the analyzer to directly to ISymbol #1510
Description
Activity
- changed the title
[-]Remove InternalImplementationOnlyAttribute and implement the constraint directly[/-][+]Remove InternalImplementationOnlyAttribute and constrain the analyzer to directly to ISymbol[/+]on Mar 24, 2015 @srivatsn @JohnHamby @mavasani @jaredpar
Removing my self-assignment, as I won't have time for this in the 1.0 timeframe.
I suspect this is an opportunity for performance improvement in our analyzers.
While this would be nice, it's not critical for 1.0. Moving to unknown.
@mavasani As this issue related to RS1009, I think it should be moved to roslyn-analyzers repository.
I don't think we really want to make this change, there is no net user or code maintenance value add here, and potential perf gain mentioned is likely not significant. I am going to close this out.
- added a commit that references this issue
on Aug 18, 2026
When we specified
InternalImplementationOnlyAttribute, it was to be implemented in its own nuget package and imported by the compilers forISymboland friends. We never implemented that. Instead the implementation we have is tied intimately to the compilers.The constraints for
ISymboland friends can be implemented much more efficiently than the general mechanism currently implemented.Since we do not appear to be doing the general mechanism, please remove
InternalImplementationOnlyAttributeand implement the desired constraints directly for the typeISymboland friends.