From 4d3d313e3f76faf470c794f67e6319166f551aef Mon Sep 17 00:00:00 2001 From: Jonathon Marolf Date: Sun, 7 May 2017 00:43:19 -0700 Subject: [PATCH 1/3] Ignoring compiler warnings --- src/CodeStyle/VisualBasic/Analyzers/BasicCodeStyle.vbproj | 1 + src/CodeStyle/VisualBasic/CodeFixes/BasicCodeStyleFixes.vbproj | 1 + src/CodeStyle/VisualBasic/Tests/BasicCodeStyleTests.vbproj | 1 + src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj | 2 +- .../Source/ExpressionCompiler/BasicExpressionCompiler.vbproj | 1 + .../ResultProvider/NetFX20/BasicResultProvider.NetFX20.vbproj | 1 + .../ResultProvider/Portable/BasicResultProvider.Portable.vbproj | 1 + src/Features/VisualBasic/Portable/BasicFeatures.vbproj | 1 + src/Interactive/VbiCore/VbiCore.vbproj | 1 + src/Scripting/VisualBasic/BasicScripting.vbproj | 1 + src/Scripting/VisualBasicTest/BasicScriptingTest.vbproj | 1 + .../VisualBasicErrorFactsGenerator.vbproj | 1 + .../VisualBasicSyntaxGenerator.vbproj | 1 + src/Workspaces/VisualBasic/Portable/BasicWorkspace.vbproj | 1 + 14 files changed, 14 insertions(+), 1 deletion(-) diff --git a/src/CodeStyle/VisualBasic/Analyzers/BasicCodeStyle.vbproj b/src/CodeStyle/VisualBasic/Analyzers/BasicCodeStyle.vbproj index cfb607d10d63b..808ef60935971 100644 --- a/src/CodeStyle/VisualBasic/Analyzers/BasicCodeStyle.vbproj +++ b/src/CodeStyle/VisualBasic/Analyzers/BasicCodeStyle.vbproj @@ -10,6 +10,7 @@ Microsoft.CodeAnalysis.VisualBasic.CodeStyle netstandard1.3 portable-net45+win8;dotnet + $(NoWarn);40057 diff --git a/src/CodeStyle/VisualBasic/CodeFixes/BasicCodeStyleFixes.vbproj b/src/CodeStyle/VisualBasic/CodeFixes/BasicCodeStyleFixes.vbproj index 8be31b2375f70..0723c7240362b 100644 --- a/src/CodeStyle/VisualBasic/CodeFixes/BasicCodeStyleFixes.vbproj +++ b/src/CodeStyle/VisualBasic/CodeFixes/BasicCodeStyleFixes.vbproj @@ -10,6 +10,7 @@ Microsoft.CodeAnalysis.VisualBasic.CodeStyle.Fixes netstandard1.3 portable-net45+win8;dotnet + $(NoWarn);40057 diff --git a/src/CodeStyle/VisualBasic/Tests/BasicCodeStyleTests.vbproj b/src/CodeStyle/VisualBasic/Tests/BasicCodeStyleTests.vbproj index d4167746d1b00..dd58c86df3fd1 100644 --- a/src/CodeStyle/VisualBasic/Tests/BasicCodeStyleTests.vbproj +++ b/src/CodeStyle/VisualBasic/Tests/BasicCodeStyleTests.vbproj @@ -12,6 +12,7 @@ netstandard1.3 portable-net45+win8;dotnet UnitTestPortable + $(NoWarn);40057 diff --git a/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj b/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj index aef1ff02a7a12..01c41ca224d90 100644 --- a/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj +++ b/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj @@ -10,7 +10,7 @@ Microsoft.CodeAnalysis.VisualBasic netstandard1.3 true - $(NoWarn);42014 + $(NoWarn);42014;40057;42016;41999 ..\BasicCodeAnalysisRules.ruleset diff --git a/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/NetFX20/BasicResultProvider.NetFX20.vbproj b/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/NetFX20/BasicResultProvider.NetFX20.vbproj index 973c1b53661b3..0b1a76f72bf1c 100644 --- a/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/NetFX20/BasicResultProvider.NetFX20.vbproj +++ b/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/NetFX20/BasicResultProvider.NetFX20.vbproj @@ -12,6 +12,7 @@ Library Microsoft.CodeAnalysis.VisualBasic.ExpressionEvaluator.ResultProvider net20 + $(NoWarn);40057 diff --git a/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/Portable/BasicResultProvider.Portable.vbproj b/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/Portable/BasicResultProvider.Portable.vbproj index 7344f2e4c6ae3..927ec6ffb56a3 100644 --- a/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/Portable/BasicResultProvider.Portable.vbproj +++ b/src/ExpressionEvaluator/VisualBasic/Source/ResultProvider/Portable/BasicResultProvider.Portable.vbproj @@ -11,6 +11,7 @@ netstandard1.3 portable-net45+win8 false + $(NoWarn);40057 diff --git a/src/Features/VisualBasic/Portable/BasicFeatures.vbproj b/src/Features/VisualBasic/Portable/BasicFeatures.vbproj index 6bfd88518e196..352ccc1c9746a 100644 --- a/src/Features/VisualBasic/Portable/BasicFeatures.vbproj +++ b/src/Features/VisualBasic/Portable/BasicFeatures.vbproj @@ -10,6 +10,7 @@ Microsoft.CodeAnalysis.VisualBasic.Features netstandard1.3 portable-net45+win8;dotnet + $(NoWarn);40057 diff --git a/src/Interactive/VbiCore/VbiCore.vbproj b/src/Interactive/VbiCore/VbiCore.vbproj index 1173ab452732c..24da7ac09ae0b 100644 --- a/src/Interactive/VbiCore/VbiCore.vbproj +++ b/src/Interactive/VbiCore/VbiCore.vbproj @@ -16,6 +16,7 @@ win7-x64;ubuntu.14.04-x64;ubuntu.16.04-x64;osx.10.12-x64 portable-net452 true + $(NoWarn);40057 diff --git a/src/Scripting/VisualBasic/BasicScripting.vbproj b/src/Scripting/VisualBasic/BasicScripting.vbproj index 2cf39f64ce46d..51cda3aa86ee9 100644 --- a/src/Scripting/VisualBasic/BasicScripting.vbproj +++ b/src/Scripting/VisualBasic/BasicScripting.vbproj @@ -10,6 +10,7 @@ Microsoft.CodeAnalysis.VisualBasic.Scripting netstandard1.3 portable-net452 + $(NoWarn);40057 diff --git a/src/Scripting/VisualBasicTest/BasicScriptingTest.vbproj b/src/Scripting/VisualBasicTest/BasicScriptingTest.vbproj index 18f8eefa40256..a7e851f98705d 100644 --- a/src/Scripting/VisualBasicTest/BasicScriptingTest.vbproj +++ b/src/Scripting/VisualBasicTest/BasicScriptingTest.vbproj @@ -12,6 +12,7 @@ netstandard1.3 portable-net452 UnitTestDesktop + $(NoWarn);40057;42016 diff --git a/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicErrorFactsGenerator/VisualBasicErrorFactsGenerator.vbproj b/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicErrorFactsGenerator/VisualBasicErrorFactsGenerator.vbproj index 01303056087b6..bf950924681ed 100644 --- a/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicErrorFactsGenerator/VisualBasicErrorFactsGenerator.vbproj +++ b/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicErrorFactsGenerator/VisualBasicErrorFactsGenerator.vbproj @@ -16,6 +16,7 @@ netcoreapp1.1 win7-x64;ubuntu.14.04-x64;ubuntu.16.04-x64;osx.10.12-x64 true + $(NoWarn);40057 diff --git a/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicSyntaxGenerator/VisualBasicSyntaxGenerator.vbproj b/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicSyntaxGenerator/VisualBasicSyntaxGenerator.vbproj index fd78b5813f6f5..9aa9b9d8967e7 100644 --- a/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicSyntaxGenerator/VisualBasicSyntaxGenerator.vbproj +++ b/src/Tools/Source/CompilerGeneratorTools/Source/VisualBasicSyntaxGenerator/VisualBasicSyntaxGenerator.vbproj @@ -17,6 +17,7 @@ netcoreapp1.1 win7-x64;ubuntu.14.04-x64;ubuntu.16.04-x64;osx.10.12-x64 true + $(NoWarn);40057 diff --git a/src/Workspaces/VisualBasic/Portable/BasicWorkspace.vbproj b/src/Workspaces/VisualBasic/Portable/BasicWorkspace.vbproj index d7bbf9fdc831e..db2cf36f964f2 100644 --- a/src/Workspaces/VisualBasic/Portable/BasicWorkspace.vbproj +++ b/src/Workspaces/VisualBasic/Portable/BasicWorkspace.vbproj @@ -11,6 +11,7 @@ netstandard1.3 portable-net45+win8;dotnet true + $(NoWarn);40057 From b4fc03602e2d197b7a0b3a45eda5deec7b804eba Mon Sep 17 00:00:00 2001 From: Jonathon Marolf Date: Sun, 7 May 2017 04:01:41 -0700 Subject: [PATCH 2/3] fixing implicit comversion errors --- .../VisualBasic/Portable/BasicCodeAnalysis.vbproj | 2 +- .../Portable/Compilation/VisualBasicCompilation.vb | 4 ++-- .../Emit/EditAndContinue/VisualBasicSymbolMatcher.vb | 2 +- .../Portable/Symbols/Source/SourceLambdaSymbol.vb | 2 +- .../Portable/Symbols/Source/SourceMethodSymbol.vb | 2 +- .../SynthesizedSymbols/SynthesizedMethodBase.vb | 2 +- .../VisualBasicTest/BasicScriptingTest.vbproj | 2 +- .../VisualBasicTest/InteractiveSessionTests.vb | 12 ++++++------ src/Scripting/VisualBasicTest/ScriptTests.vb | 10 +++++----- 9 files changed, 19 insertions(+), 19 deletions(-) diff --git a/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj b/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj index 01c41ca224d90..c0c40fb4981fb 100644 --- a/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj +++ b/src/Compilers/VisualBasic/Portable/BasicCodeAnalysis.vbproj @@ -10,7 +10,7 @@ Microsoft.CodeAnalysis.VisualBasic netstandard1.3 true - $(NoWarn);42014;40057;42016;41999 + $(NoWarn);42014;40057 ..\BasicCodeAnalysisRules.ruleset